From 917770f547deb937061ec243b52736bd0cab8167 Mon Sep 17 00:00:00 2001 From: rusttech Date: Wed, 16 Oct 2024 16:35:17 +0800 Subject: [PATCH] app/vmctl: fixes opentsdb source metric tags Previously it was incorrectly used append for pre-allocated slice of labels. This commit fixes slice append by allocating zero length slice with needed capacity. --------- Co-authored-by: Nikolay --- app/vmctl/opentsdb.go | 2 +- docs/changelog/CHANGELOG.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/vmctl/opentsdb.go b/app/vmctl/opentsdb.go index 437da9e690..6ac4a60503 100644 --- a/app/vmctl/opentsdb.go +++ b/app/vmctl/opentsdb.go @@ -158,7 +158,7 @@ func (op *otsdbProcessor) do(s queryObj) error { if len(data.Timestamps) < 1 || len(data.Values) < 1 { return nil } - labels := make([]vm.LabelPair, len(data.Tags)) + labels := make([]vm.LabelPair, 0, len(data.Tags)) for k, v := range data.Tags { labels = append(labels, vm.LabelPair{Name: k, Value: v}) } diff --git a/docs/changelog/CHANGELOG.md b/docs/changelog/CHANGELOG.md index cf2ddd0128..49d5c752d8 100644 --- a/docs/changelog/CHANGELOG.md +++ b/docs/changelog/CHANGELOG.md @@ -29,6 +29,7 @@ See also [LTS releases](https://docs.victoriametrics.com/lts-releases/). * BUGFIX: [vmgateway](https://docs.victoriametrics.com/vmgateway/): fix possible panic during parsing of a token without `vm_access` claim. This issue was introduced in v1.104.0. * BUGFIX: [vmui](https://docs.victoriametrics.com/#vmui): fix error messages rendering from overflowing the screen with long messages. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/7207). * BUGFIX: `vmselect` in [VictoriaMetrics cluster](https://docs.victoriametrics.com/cluster-victoriametrics/): properly process response in [multi-level cluster setup](https://docs.victoriametrics.com/cluster-victoriametrics/#multi-level-cluster-setup). Before, vmselect could return no data in multi-level setup. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/7270) for details. The issue was introduced in [v1.104.0](https://docs.victoriametrics.com/changelog/#v11040). +* BUGFIX: [vmctl](https://docs.victoriametrics.com/vmctl/): properly add metrics tags for `opentsdb` migration source. Previously it could have empty values. See [this PR](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/7161). ## [v1.104.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.104.0)