github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/mergeset: skip comparison for every item in the block during merge if the last item in the block is smaller than the first item in the next block

Browse source 
Thanks to @ahfuzhang for the suggestion at https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5651
This commit is contained in:
Aliaksandr Valialkin 2024-01-23 03:15:49 +02:00
parent bc7d19c8ca
commit 980338861f
No known key found for this signature in database
GPG key ID: 52C003EE2BCDB9EB
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lib/mergeset/merge.go
View file

@ -125,9 +125,16 @@ again:
}
items := bsr.Block.items
data := bsr.Block.data
for bsr.currItemIdx < len(bsr.Block.items) {
compareEveryItem := true
if bsr.currItemIdx < len(items) {
// An optimization, which allows skipping costly comparison for every merged item in the loop below.
// Thanks to @ahfuzhang for the suggestion at https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5651
lastItem := items[len(items)-1].Bytes(data)
compareEveryItem = hasNextItem && string(lastItem) > nextItem
}
for bsr.currItemIdx < len(items) {
item := items[bsr.currItemIdx].Bytes(data)
if hasNextItem && string(item) > nextItem {
if compareEveryItem && string(item) > nextItem {
break
}
if !bsm.ib.Add(item) {
@ -137,7 +144,7 @@ again:
}
bsr.currItemIdx++
}
if bsr.currItemIdx == len(bsr.Block.items) {
if bsr.currItemIdx == len(items) {
// bsr.Block is fully read. Proceed to the next block.
if bsr.Next() {
heap.Fix(&bsm.bsrHeap, 0)