github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-02-19 15:30:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/storage: do not cache inmemoryBlock entries requested only once (aka one-time-wonder items)

Browse source 
This should reduce the cache size and memory usage for the indexdb/dataBlocks cache
This commit is contained in:
Aliaksandr Valialkin 2021-07-07 10:57:38 +03:00
parent 74ace9340d
commit 9826f7c1be
1 changed files with 21 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
lib/mergeset/part.go
View file

@ -234,7 +234,6 @@ func (idxbc *indexBlockCache) Get(k uint64) *indexBlock {
// Put puts idxb under the key k into idxbc. // Put puts idxb under the key k into idxbc.
func (idxbc *indexBlockCache) Put(k uint64, idxb *indexBlock) { func (idxbc *indexBlockCache) Put(k uint64, idxb *indexBlock) {
idxbc.mu.Lock() idxbc.mu.Lock()
// Remove superfluous entries. // Remove superfluous entries.
if overflow := len(idxbc.m) - getMaxCachedIndexBlocksPerPart(); overflow > 0 { if overflow := len(idxbc.m) - getMaxCachedIndexBlocksPerPart(); overflow > 0 {
// Remove 10% of items from the cache. // Remove 10% of items from the cache.
@ -292,6 +291,9 @@ type inmemoryBlockCache struct {
m map[inmemoryBlockCacheKey]*inmemoryBlockCacheEntry m map[inmemoryBlockCacheKey]*inmemoryBlockCacheEntry
mu sync.RWMutex mu sync.RWMutex
perKeyMisses map[inmemoryBlockCacheKey]int
perKeyMissesLock sync.Mutex
cleanerStopCh chan struct{} cleanerStopCh chan struct{}
cleanerWG sync.WaitGroup cleanerWG sync.WaitGroup
} }
@ -316,7 +318,7 @@ type inmemoryBlockCacheEntry struct {
func newInmemoryBlockCache() *inmemoryBlockCache { func newInmemoryBlockCache() *inmemoryBlockCache {
var ibc inmemoryBlockCache var ibc inmemoryBlockCache
ibc.m = make(map[inmemoryBlockCacheKey]*inmemoryBlockCacheEntry) ibc.m = make(map[inmemoryBlockCacheKey]*inmemoryBlockCacheEntry)
ibc.perKeyMisses = make(map[inmemoryBlockCacheKey]int)
ibc.cleanerStopCh = make(chan struct{}) ibc.cleanerStopCh = make(chan struct{})
ibc.cleanerWG.Add(1) ibc.cleanerWG.Add(1)
go func() { go func() {
@ -330,6 +332,7 @@ func (ibc *inmemoryBlockCache) MustClose() {
close(ibc.cleanerStopCh) close(ibc.cleanerStopCh)
ibc.cleanerWG.Wait() ibc.cleanerWG.Wait()
ibc.m = nil ibc.m = nil
ibc.perKeyMisses = nil
} }
// cleaner periodically cleans least recently used items. // cleaner periodically cleans least recently used items.
@ -357,6 +360,10 @@ func (ibc *inmemoryBlockCache) cleanByTimeout() {
} }
} }
ibc.mu.Unlock() ibc.mu.Unlock()
ibc.perKeyMissesLock.Lock()
ibc.perKeyMisses = make(map[inmemoryBlockCacheKey]int, len(ibc.perKeyMisses))
ibc.perKeyMissesLock.Unlock()
} }
func (ibc *inmemoryBlockCache) Get(k inmemoryBlockCacheKey) *inmemoryBlock { func (ibc *inmemoryBlockCache) Get(k inmemoryBlockCacheKey) *inmemoryBlock {
@ -373,14 +380,25 @@ func (ibc *inmemoryBlockCache) Get(k inmemoryBlockCacheKey) *inmemoryBlock {
} }
return ibe.ib return ibe.ib
} }
ibc.perKeyMissesLock.Lock()
ibc.perKeyMisses[k]++
ibc.perKeyMissesLock.Unlock()
atomic.AddUint64(&ibc.misses, 1) atomic.AddUint64(&ibc.misses, 1)
return nil return nil
} }
// Put puts ib under key k into ibc. // Put puts ib under key k into ibc.
func (ibc *inmemoryBlockCache) Put(k inmemoryBlockCacheKey, ib *inmemoryBlock) { func (ibc *inmemoryBlockCache) Put(k inmemoryBlockCacheKey, ib *inmemoryBlock) {
ibc.mu.Lock() ibc.perKeyMissesLock.Lock()
doNotCache := ibc.perKeyMisses[k] == 1
ibc.perKeyMissesLock.Unlock()
if doNotCache {
// Do not cache ib if it has been requested only once (aka one-time-wonders items).
// This should reduce memory usage for the ibc cache.
return
}
ibc.mu.Lock()
// Clean superfluous entries in cache. // Clean superfluous entries in cache.
if overflow := len(ibc.m) - getMaxCachedInmemoryBlocksPerPart(); overflow > 0 { if overflow := len(ibc.m) - getMaxCachedInmemoryBlocksPerPart(); overflow > 0 {
// Remove 10% of items from the cache. // Remove 10% of items from the cache.