github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/promscrape: restore red highlighting for DOWN targets at /targets page

Browse source 
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1461
This commit is contained in:
Aliaksandr Valialkin 2021-08-15 16:03:54 +03:00
parent 40a859a760
commit a0e18f06eb
3 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
docs/CHANGELOG.md
View file

@ -26,6 +26,7 @@ sort: 15
* BUGFIX: vmselect: prevent from possible deadlock when multiple `target` query args are passed to [Graphite Render API](https://docs.victoriametrics.com/#graphite-render-api-usage). * BUGFIX: vmselect: prevent from possible deadlock when multiple `target` query args are passed to [Graphite Render API](https://docs.victoriametrics.com/#graphite-render-api-usage).
* BUGFIX: return series with `a op b` labels and `N` values for `(a op b) default N` if `(a op b)` returns series with all NaN values. Previously such series were removed. * BUGFIX: return series with `a op b` labels and `N` values for `(a op b) default N` if `(a op b)` returns series with all NaN values. Previously such series were removed.
* BUGFIX: vmui: fix layout when the query selects more than 27 time series. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1497). * BUGFIX: vmui: fix layout when the query selects more than 27 time series. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1497).
* BUGFIX: vmagent: restore highlighting in red for DOWN targets at `/targets` page. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1461).
## [v1.63.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.63.0) ## [v1.63.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.63.0)

2
lib/promscrape/targets_response.qtpl
View file

@ -74,7 +74,7 @@ job={%q= jobName %} (0/0 up)
<tbody> <tbody>
{% for _, ts := range js.targetsStatus %} {% for _, ts := range js.targetsStatus %}
{% if onlyUnhealthy && ts.up %}{% continue %}{% endif %} {% if onlyUnhealthy && ts.up %}{% continue %}{% endif %}
<tr {% if !ts.up %}class="alert alert-danger" role="alert"{% endif %}> <tr {% if !ts.up %}{%space%}class="alert alert-danger" role="alert"{% endif %}>
<td><a href="{%s ts.endpoint %}">{%s ts.endpoint %}</a><br></td> <td><a href="{%s ts.endpoint %}">{%s ts.endpoint %}</a><br></td>
<td>{% if ts.up %}UP{% else %}DOWN{% endif %}</td> <td>{% if ts.up %}UP{% else %}DOWN{% endif %}</td>
<td title="Original labels: {%= formatLabel(ts.originalLabels) %}"> <td title="Original labels: {%= formatLabel(ts.originalLabels) %}">

2
lib/promscrape/targets_response.qtpl.go
View file

@ -258,6 +258,8 @@ func StreamTargetsResponseHTML(qw422016 *qt422016.Writer, jts []jobTargetsStatus
qw422016.N().S(`<tr`) qw422016.N().S(`<tr`)
//line lib/promscrape/targets_response.qtpl:77 //line lib/promscrape/targets_response.qtpl:77
if !ts.up { if !ts.up {
//line lib/promscrape/targets_response.qtpl:77
qw422016.N().S(` `)
//line lib/promscrape/targets_response.qtpl:77 //line lib/promscrape/targets_response.qtpl:77
qw422016.N().S(`class="alert alert-danger" role="alert"`) qw422016.N().S(`class="alert alert-danger" role="alert"`)
//line lib/promscrape/targets_response.qtpl:77 //line lib/promscrape/targets_response.qtpl:77