github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

app/vmagent/remotewrite: clarify the comment explaining why vmagent drops blocks if remote storage returns 400 or 409 status code

Browse source
This commit is contained in:
Aliaksandr Valialkin 2021-05-13 16:16:16 +03:00
parent fc3519fa26
commit a422165dc6
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/vmagent/remotewrite/client.go
View file

@ -260,11 +260,9 @@ again:
} }
metrics.GetOrCreateCounter(fmt.Sprintf(`vmagent_remotewrite_requests_total{url=%q, status_code="%d"}`, c.sanitizedURL, statusCode)).Inc() metrics.GetOrCreateCounter(fmt.Sprintf(`vmagent_remotewrite_requests_total{url=%q, status_code="%d"}`, c.sanitizedURL, statusCode)).Inc()
if statusCode == 409 || statusCode == 400 { if statusCode == 409 || statusCode == 400 {
// Just drop block on 409 status code like Prometheus does. // Just drop block on 409 and 400 status codes like Prometheus does.
// See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/873 // See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/873
// drop block on 400 status code, // and https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1149
// not expected that remote server will be able to handle it on retry
// should fix https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1149
_ = resp.Body.Close() _ = resp.Body.Close()
c.packetsDropped.Inc() c.packetsDropped.Inc()
return true return true