github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-02-09 15:27:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/logger: add -loggerWarnsPerSecondLimit command-line flag for rate limiting of WARN log messages

Browse source 
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/905
This commit is contained in:
Aliaksandr Valialkin 2020-11-18 03:40:12 +02:00
parent c2afa3fdd7
commit a6b2b2c005
1 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
lib/logger/logger.go
View file

@ -25,6 +25,8 @@ var (
errorsPerSecondLimit = flag.Int("loggerErrorsPerSecondLimit", 10, "Per-second limit on the number of ERROR messages. If more than the given number of errors "+ errorsPerSecondLimit = flag.Int("loggerErrorsPerSecondLimit", 10, "Per-second limit on the number of ERROR messages. If more than the given number of errors "+
"are emitted per second, then the remaining errors are suppressed. Zero value disables the rate limit") "are emitted per second, then the remaining errors are suppressed. Zero value disables the rate limit")
warnsPerSecondLimit = flag.Int("loggerWarnsPerSecondLimit", 10, "Per-second limit on the number of WARN messages. If more than the given number of warns "+
"are emitted per second, then the remaining warns are suppressed. Zero value disables the rate limit")
) )
// Init initializes the logger. // Init initializes the logger.
@ -36,7 +38,7 @@ func Init() {
setLoggerOutput() setLoggerOutput()
validateLoggerLevel() validateLoggerLevel()
validateLoggerFormat() validateLoggerFormat()
go errorsLoggedCleaner() go errorsAndWarnsLoggedCleaner()
logAllFlags() logAllFlags()
} }
@ -125,14 +127,18 @@ func logLevelSkipframes(skipframes int, level, format string, args ...interface{
logMessage(level, msg, 3+skipframes) logMessage(level, msg, 3+skipframes)
} }
func errorsLoggedCleaner() { func errorsAndWarnsLoggedCleaner() {
for { for {
time.Sleep(time.Second) time.Sleep(time.Second)
atomic.StoreUint64(&errorsLogged, 0) atomic.StoreUint64(&errorsLogged, 0)
atomic.StoreUint64(&warnsLogged, 0)
} }
} }
var errorsLogged uint64 var (
errorsLogged uint64
warnsLogged uint64
)
type logWriter struct { type logWriter struct {
} }
@ -149,6 +155,11 @@ func logMessage(level, msg string, skipframes int) {
return return
} }
} }
if level == "WARN" {
if n := atomic.AddUint64(&warnsLogged, 1); *warnsPerSecondLimit > 0 && n > uint64(*warnsPerSecondLimit) {
return
}
}
timestamp := "" timestamp := ""
if !*disableTimestamps { if !*disableTimestamps {