From a88bcdee24c93c9ac35387bb0a003a63813e243e Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Thu, 8 Dec 2022 16:41:22 -0800 Subject: [PATCH] all: update Go builder from v1.19.3 to v1.19.4 See https://github.com/golang/go/issues?q=milestone%3AGo1.19.4+label%3ACherryPickApproved --- .github/workflows/check-licenses.yml | 2 +- .github/workflows/main.yml | 2 +- README.md | 2 +- app/vmagent/README.md | 4 ++-- app/vmalert/README.md | 4 ++-- app/vmauth/README.md | 2 +- app/vmbackup/README.md | 2 +- app/vmctl/README.md | 4 ++-- app/vmrestore/README.md | 2 +- app/vmui/Dockerfile-web | 2 +- deployment/docker/Makefile | 6 +++--- docs/CHANGELOG.md | 3 +++ docs/Cluster-VictoriaMetrics.md | 2 +- docs/README.md | 6 +++--- docs/Single-server-VictoriaMetrics.md | 6 +++--- docs/vmagent.md | 4 ++-- docs/vmalert.md | 4 ++-- docs/vmauth.md | 2 +- docs/vmbackup.md | 2 +- docs/vmctl.md | 4 ++-- docs/vmrestore.md | 2 +- 21 files changed, 35 insertions(+), 32 deletions(-) diff --git a/.github/workflows/check-licenses.yml b/.github/workflows/check-licenses.yml index f577d0940..304df1297 100644 --- a/.github/workflows/check-licenses.yml +++ b/.github/workflows/check-licenses.yml @@ -17,7 +17,7 @@ jobs: - name: Setup Go uses: actions/setup-go@main with: - go-version: 1.17 + go-version: 1.19.4 id: go - name: Code checkout uses: actions/checkout@master diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 02ce14ab0..3f2fa8467 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -19,7 +19,7 @@ jobs: - name: Setup Go uses: actions/setup-go@main with: - go-version: 1.17 + go-version: 1.19.4 id: go - name: Code checkout uses: actions/checkout@master diff --git a/README.md b/README.md index 456fd2491..6dab87fe1 100644 --- a/README.md +++ b/README.md @@ -92,7 +92,7 @@ vmstorage-prod ### Development Builds -1. [Install go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make` from [the repository root](https://github.com/VictoriaMetrics/VictoriaMetrics). It should build `vmstorage`, `vmselect` and `vminsert` binaries and put them into the `bin` folder. diff --git a/app/vmagent/README.md b/app/vmagent/README.md index ee69ce6a7..79db7afd1 100644 --- a/app/vmagent/README.md +++ b/app/vmagent/README.md @@ -789,7 +789,7 @@ We recommend using [binary releases](https://github.com/VictoriaMetrics/Victoria ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmagent` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds the `vmagent` binary and puts it into the `bin` folder. @@ -818,7 +818,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b ### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmagent-linux-arm` or `make vmagent-linux-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics) It builds `vmagent-linux-arm` or `vmagent-linux-arm64` binary respectively and puts it into the `bin` folder. diff --git a/app/vmalert/README.md b/app/vmalert/README.md index a466c1e1d..126e1326d 100644 --- a/app/vmalert/README.md +++ b/app/vmalert/README.md @@ -1090,7 +1090,7 @@ spec: ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmalert` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmalert` binary and puts it into the `bin` folder. @@ -1106,7 +1106,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b ### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmalert-linux-arm` or `make vmalert-linux-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmalert-linux-arm` or `vmalert-linux-arm64` binary respectively and puts it into the `bin` folder. diff --git a/app/vmauth/README.md b/app/vmauth/README.md index e0128ae43..f2edfc322 100644 --- a/app/vmauth/README.md +++ b/app/vmauth/README.md @@ -166,7 +166,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmauth` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmauth` binary and puts it into the `bin` folder. diff --git a/app/vmbackup/README.md b/app/vmbackup/README.md index 51fa65fa9..de71ae412 100644 --- a/app/vmbackup/README.md +++ b/app/vmbackup/README.md @@ -268,7 +268,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmbackup` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmbackup` binary and puts it into the `bin` folder. diff --git a/app/vmctl/README.md b/app/vmctl/README.md index fc2b1be05..262b6cb7e 100644 --- a/app/vmctl/README.md +++ b/app/vmctl/README.md @@ -631,7 +631,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmctl` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmctl` binary and puts it into the `bin` folder. @@ -660,7 +660,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b #### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmctl-linux-arm` or `make vmctl-linux-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmctl-linux-arm` or `vmctl-linux-arm64` binary respectively and puts it into the `bin` folder. diff --git a/app/vmrestore/README.md b/app/vmrestore/README.md index 73985e440..7983e8e36 100644 --- a/app/vmrestore/README.md +++ b/app/vmrestore/README.md @@ -168,7 +168,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmrestore` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmrestore` binary and puts it into the `bin` folder. diff --git a/app/vmui/Dockerfile-web b/app/vmui/Dockerfile-web index 326121fba..e62aa2fd8 100644 --- a/app/vmui/Dockerfile-web +++ b/app/vmui/Dockerfile-web @@ -1,4 +1,4 @@ -FROM golang:1.19.3 as build-web-stage +FROM golang:1.19.4 as build-web-stage COPY build /build WORKDIR /build diff --git a/deployment/docker/Makefile b/deployment/docker/Makefile index 8d3fd45d1..274022d08 100644 --- a/deployment/docker/Makefile +++ b/deployment/docker/Makefile @@ -2,9 +2,9 @@ DOCKER_NAMESPACE := victoriametrics -ROOT_IMAGE ?= alpine:3.16.2 -CERTS_IMAGE := alpine:3.16.2 -GO_BUILDER_IMAGE := golang:1.19.3-alpine +ROOT_IMAGE ?= alpine:3.17.0 +CERTS_IMAGE := alpine:3.17.0 +GO_BUILDER_IMAGE := golang:1.19.4-alpine BUILDER_IMAGE := local/builder:2.0.0-$(shell echo $(GO_BUILDER_IMAGE) | tr :/ __)-1 BASE_IMAGE := local/base:1.1.3-$(shell echo $(ROOT_IMAGE) | tr :/ __)-$(shell echo $(CERTS_IMAGE) | tr :/ __) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 7ef8e467e..d63e2e36e 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -15,6 +15,9 @@ The following tip changes can be tested by building VictoriaMetrics components f ## v1.79.x long-time support release (LTS) +* SECURITY: update Go builder from v1.19.3 to v1.19.4. See [the changelog](https://github.com/golang/go/issues?q=milestone%3AGo1.19.4+label%3ACherryPickApproved). +* SECURITY: update base Docker image for VictoriaMetrics components from Alpine 3.16.2 to Alpine v3.17.0. See [the changelog](https://alpinelinux.org/releases/). + * BUGFIX: [vmagent](https://docs.victoriametrics.com/vmagent.html): fix the `The request did not have a subscription or a valid tenant level resource provider` error when discovering Azure targets with [azure_sd_configs](https://docs.victoriametrics.com/sd_configs.html#azure_sd_configs). See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3247). * BUGFIX: [vmagent](https://docs.victoriametrics.com/vmagent.html): properly discover GCE zones when `filter` option is set at [gce_sd_configs](https://docs.victoriametrics.com/sd_configs.html#gce_sd_configs). See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3202). * BUGFIX: [vmalert](https://docs.victoriametrics.com/vmalert.html): properly specify rule evaluation step during the [replay mode](https://docs.victoriametrics.com/vmalert.html#rules-backfilling). The `step` value was previously overriden by `-datasource.queryStep` command-line flag. diff --git a/docs/Cluster-VictoriaMetrics.md b/docs/Cluster-VictoriaMetrics.md index eb209e55e..e134b5147 100644 --- a/docs/Cluster-VictoriaMetrics.md +++ b/docs/Cluster-VictoriaMetrics.md @@ -96,7 +96,7 @@ vmstorage-prod ### Development Builds -1. [Install go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make` from [the repository root](https://github.com/VictoriaMetrics/VictoriaMetrics). It should build `vmstorage`, `vmselect` and `vminsert` binaries and put them into the `bin` folder. diff --git a/docs/README.md b/docs/README.md index 6211c543a..8ccb9e85b 100644 --- a/docs/README.md +++ b/docs/README.md @@ -729,7 +729,7 @@ to your needs or when testing bugfixes. ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make victoria-metrics` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `victoria-metrics` binary and puts it into the `bin` folder. @@ -745,7 +745,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b ### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make victoria-metrics-linux-arm` or `make victoria-metrics-linux-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `victoria-metrics-linux-arm` or `victoria-metrics-linux-arm64` binary respectively and puts it into the `bin` folder. @@ -759,7 +759,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b `Pure Go` mode builds only Go code without [cgo](https://golang.org/cmd/cgo/) dependencies. -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make victoria-metrics-pure` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `victoria-metrics-pure` binary and puts it into the `bin` folder. diff --git a/docs/Single-server-VictoriaMetrics.md b/docs/Single-server-VictoriaMetrics.md index 772adeafb..20ab1f3f9 100644 --- a/docs/Single-server-VictoriaMetrics.md +++ b/docs/Single-server-VictoriaMetrics.md @@ -733,7 +733,7 @@ to your needs or when testing bugfixes. ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make victoria-metrics` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `victoria-metrics` binary and puts it into the `bin` folder. @@ -749,7 +749,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b ### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make victoria-metrics-linux-arm` or `make victoria-metrics-linux-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `victoria-metrics-linux-arm` or `victoria-metrics-linux-arm64` binary respectively and puts it into the `bin` folder. @@ -763,7 +763,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b `Pure Go` mode builds only Go code without [cgo](https://golang.org/cmd/cgo/) dependencies. -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make victoria-metrics-pure` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `victoria-metrics-pure` binary and puts it into the `bin` folder. diff --git a/docs/vmagent.md b/docs/vmagent.md index 96f202c9e..15c0a8e51 100644 --- a/docs/vmagent.md +++ b/docs/vmagent.md @@ -793,7 +793,7 @@ We recommend using [binary releases](https://github.com/VictoriaMetrics/Victoria ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmagent` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds the `vmagent` binary and puts it into the `bin` folder. @@ -822,7 +822,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b ### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmagent-linux-arm` or `make vmagent-linux-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics) It builds `vmagent-linux-arm` or `vmagent-linux-arm64` binary respectively and puts it into the `bin` folder. diff --git a/docs/vmalert.md b/docs/vmalert.md index cf6a7bc5b..b20232708 100644 --- a/docs/vmalert.md +++ b/docs/vmalert.md @@ -1094,7 +1094,7 @@ spec: ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmalert` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmalert` binary and puts it into the `bin` folder. @@ -1110,7 +1110,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b ### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmalert-linux-arm` or `make vmalert-linux-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmalert-linux-arm` or `vmalert-linux-arm64` binary respectively and puts it into the `bin` folder. diff --git a/docs/vmauth.md b/docs/vmauth.md index 86bf68b69..1bc336a41 100644 --- a/docs/vmauth.md +++ b/docs/vmauth.md @@ -170,7 +170,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmauth` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmauth` binary and puts it into the `bin` folder. diff --git a/docs/vmbackup.md b/docs/vmbackup.md index a4573a807..293308e0f 100644 --- a/docs/vmbackup.md +++ b/docs/vmbackup.md @@ -272,7 +272,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmbackup` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmbackup` binary and puts it into the `bin` folder. diff --git a/docs/vmctl.md b/docs/vmctl.md index 82a7318b3..65552de87 100644 --- a/docs/vmctl.md +++ b/docs/vmctl.md @@ -635,7 +635,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmctl` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmctl` binary and puts it into the `bin` folder. @@ -664,7 +664,7 @@ ARM build may run on Raspberry Pi or on [energy-efficient ARM servers](https://b #### Development ARM build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmctl-linux-arm` or `make vmctl-linux-arm64` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmctl-linux-arm` or `vmctl-linux-arm64` binary respectively and puts it into the `bin` folder. diff --git a/docs/vmrestore.md b/docs/vmrestore.md index 009bc4be7..1bcac3265 100644 --- a/docs/vmrestore.md +++ b/docs/vmrestore.md @@ -172,7 +172,7 @@ It is recommended using [binary releases](https://github.com/VictoriaMetrics/Vic ### Development build -1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.17. +1. [Install Go](https://golang.org/doc/install). The minimum supported version is Go 1.19. 2. Run `make vmrestore` from the root folder of [the repository](https://github.com/VictoriaMetrics/VictoriaMetrics). It builds `vmrestore` binary and puts it into the `bin` folder.