From ad39838c34e52f7610b73d39b90debe0567be8b3 Mon Sep 17 00:00:00 2001 From: Nikolay Date: Tue, 29 Aug 2023 16:29:14 +0200 Subject: [PATCH] deployment/docker: disable provenance in buildx (#4911) * deployment/docker: disable provenance in buildx it must fix an issue with multi-platform manifest generation at buildx >= 0.10 backward compatibility was broken and generated image cannot be used with docker systems that doesn't support oci. disabling attestat temporary fixes it. https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4907 https://docs.docker.com/build/attestations/slsa-provenance/ * Update docs/CHANGELOG.md --------- Co-authored-by: Aliaksandr Valialkin --- deployment/docker/Makefile | 1 + docs/CHANGELOG.md | 1 + 2 files changed, 2 insertions(+) diff --git a/deployment/docker/Makefile b/deployment/docker/Makefile index 44e9cb4ec..8b2511ca0 100644 --- a/deployment/docker/Makefile +++ b/deployment/docker/Makefile @@ -79,6 +79,7 @@ publish-via-docker: \ --build-arg APP_NAME=$(APP_NAME) \ --tag $(DOCKER_NAMESPACE)/$(APP_NAME):$(PKG_TAG)$(RACE) \ -o type=image \ + --provenance=false \ -f app/$(APP_NAME)/multiarch/Dockerfile \ --push \ bin diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 9aa96e33c..770f1b3cb 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -24,6 +24,7 @@ The following `tip` changes can be tested by building VictoriaMetrics components ## v1.93.x long-time support release (LTS) +* BUGFIX: [build](https://docs.victoriametrics.com/): fix Docker builds for old Docker releases. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4907). * BUGFIX: [vmagent](https://docs.victoriametrics.com/vmagent.html): consistently set `User-Agent` header to `vm_promscrape` during scraping with enabled or disabled [stream parsing mode](https://docs.victoriametrics.com/vmagent.html#stream-parsing-mode). See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4884). * BUGFIX: [vmagent](https://docs.victoriametrics.com/vmagent.html): consistently set timeout for scraping with enabled or disabled [stream parsing mode](https://docs.victoriametrics.com/vmagent.html#stream-parsing-mode). See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4847). * BUGFIX: [vmalert](https://docs.victoriametrics.com/vmalert.html): correctly re-use HTTP request object on `EOF` retries when querying the configured datasource. Previously, there was a small chance that query retry wouldn't succeed.