github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/storage: do not create flock.lock files at partition directories, since it is created at the Storage level

Browse source
This commit is contained in:
Aliaksandr Valialkin 2023-06-19 22:48:37 -07:00
parent 0f01eea4e9
commit aeac39cfd1
No known key found for this signature in database
GPG key ID: A72BEC6CD3D0DED1
1 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/storage/table.go
View file

@ -2,7 +2,6 @@ package storage
import ( import (
"fmt" "fmt"
"os"
"path/filepath" "path/filepath"
"strings" "strings"
"sync" "sync"
@ -25,8 +24,6 @@ type table struct {
ptws []*partitionWrapper ptws []*partitionWrapper
ptwsLock sync.Mutex ptwsLock sync.Mutex
flockF *os.File
stop chan struct{} stop chan struct{}
retentionWatcherWG sync.WaitGroup retentionWatcherWG sync.WaitGroup
@ -85,9 +82,6 @@ func mustOpenTable(path string, s *Storage) *table {
// Create a directory for the table if it doesn't exist yet. // Create a directory for the table if it doesn't exist yet.
fs.MustMkdirIfNotExist(path) fs.MustMkdirIfNotExist(path)
// Protect from concurrent opens.
flockF := fs.MustCreateFlockFile(path)
// Create directories for small and big partitions if they don't exist yet. // Create directories for small and big partitions if they don't exist yet.
smallPartitionsPath := filepath.Join(path, smallDirname) smallPartitionsPath := filepath.Join(path, smallDirname)
fs.MustMkdirIfNotExist(smallPartitionsPath) fs.MustMkdirIfNotExist(smallPartitionsPath)
@ -114,8 +108,6 @@ func mustOpenTable(path string, s *Storage) *table {
bigPartitionsPath: bigPartitionsPath, bigPartitionsPath: bigPartitionsPath,
s: s, s: s,
flockF: flockF,
stop: make(chan struct{}), stop: make(chan struct{}),
} }
for _, pt := range pts { for _, pt := range pts {
@ -197,10 +189,6 @@ func (tb *table) MustClose() {
} }
ptw.decRef() ptw.decRef()
} }
// Release exclusive lock on the table.
fs.MustClose(tb.flockF)
tb.flockF = nil
} }
// flushPendingRows flushes all the pending raw rows, so they become visible to search. // flushPendingRows flushes all the pending raw rows, so they become visible to search.