From aefd744abb8fd0099d3d10a054fe5245257c66de Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Thu, 16 Nov 2023 19:26:03 +0100 Subject: [PATCH] dashboards: remove `path!="/favicon.ico"` filter from `requests rate` graphs The `path!="/favicon.ico"` filter has little sense, since there are many other special paths, which may be filtered out - /metrics, /flags, /health, /ping, /robots.txt, /-/healthy, /-/ready, /reload, etc. See /lib/httpserver/httpserver.go for more details. It will be hard or impossible to maintain filters for all these paths, so it is better to drop this filter in order to simplify queries and improve the consistency of these queries. --- dashboards/victoriametrics-cluster.json | 6 +++--- dashboards/victoriametrics.json | 2 +- dashboards/vm/victoriametrics-cluster.json | 6 +++--- dashboards/vm/victoriametrics.json | 2 +- dashboards/vm/vmagent.json | 6 +++--- dashboards/vmagent.json | 6 +++--- 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/dashboards/victoriametrics-cluster.json b/dashboards/victoriametrics-cluster.json index 72d65274b..6abd17a67 100644 --- a/dashboards/victoriametrics-cluster.json +++ b/dashboards/victoriametrics-cluster.json @@ -1127,7 +1127,7 @@ "uid": "$ds" }, "editorMode": "code", - "expr": "sum(rate(vm_http_requests_total{job=~\"$job\", instance=~\"$instance\", path!~\"/favicon.ico\"}[$__rate_interval])) by (path) > 0", + "expr": "sum(rate(vm_http_requests_total{job=~\"$job\", instance=~\"$instance\"}[$__rate_interval])) by (path) > 0", "format": "time_series", "intervalFactor": 1, "legendFormat": "{{path}}", @@ -6125,7 +6125,7 @@ "uid": "$ds" }, "editorMode": "code", - "expr": "sum(rate(vm_http_requests_total{job=~\"$job_select\", instance=~\"$instance\", path!~\"/favicon.ico|/metrics\"}[$__rate_interval])) by (path) > 0", + "expr": "sum(rate(vm_http_requests_total{job=~\"$job_select\", instance=~\"$instance\"}[$__rate_interval])) by (path) > 0", "format": "time_series", "intervalFactor": 1, "legendFormat": "__auto", @@ -7232,7 +7232,7 @@ "uid": "$ds" }, "editorMode": "code", - "expr": "sum(rate(vm_http_requests_total{job=~\"$job_insert\", instance=~\"$instance\", path!~\"/favicon.ico|/metrics\"}[$__rate_interval])) by (path) > 0", + "expr": "sum(rate(vm_http_requests_total{job=~\"$job_insert\", instance=~\"$instance\"}[$__rate_interval])) by (path) > 0", "format": "time_series", "intervalFactor": 1, "legendFormat": "__auto", diff --git a/dashboards/victoriametrics.json b/dashboards/victoriametrics.json index 4460ba961..65cbd553e 100644 --- a/dashboards/victoriametrics.json +++ b/dashboards/victoriametrics.json @@ -1035,7 +1035,7 @@ "uid": "$ds" }, "editorMode": "code", - "expr": "sum(rate(vm_http_requests_total{job=~\"$job\", instance=~\"$instance\", path!~\"/favicon.ico\"}[$__rate_interval])) by (path) > 0", + "expr": "sum(rate(vm_http_requests_total{job=~\"$job\", instance=~\"$instance\"}[$__rate_interval])) by (path) > 0", "format": "time_series", "interval": "", "intervalFactor": 1, diff --git a/dashboards/vm/victoriametrics-cluster.json b/dashboards/vm/victoriametrics-cluster.json index a6589aad5..6ff054d0f 100644 --- a/dashboards/vm/victoriametrics-cluster.json +++ b/dashboards/vm/victoriametrics-cluster.json @@ -1128,7 +1128,7 @@ "uid": "$ds" }, "editorMode": "code", - "expr": "sum(rate(vm_http_requests_total{job=~\"$job\", instance=~\"$instance\", path!~\"/favicon.ico\"}[$__rate_interval])) by (path) > 0", + "expr": "sum(rate(vm_http_requests_total{job=~\"$job\", instance=~\"$instance\"}[$__rate_interval])) by (path) > 0", "format": "time_series", "intervalFactor": 1, "legendFormat": "{{path}}", @@ -6126,7 +6126,7 @@ "uid": "$ds" }, "editorMode": "code", - "expr": "sum(rate(vm_http_requests_total{job=~\"$job_select\", instance=~\"$instance\", path!~\"/favicon.ico|/metrics\"}[$__rate_interval])) by (path) > 0", + "expr": "sum(rate(vm_http_requests_total{job=~\"$job_select\", instance=~\"$instance\"}[$__rate_interval])) by (path) > 0", "format": "time_series", "intervalFactor": 1, "legendFormat": "__auto", @@ -7233,7 +7233,7 @@ "uid": "$ds" }, "editorMode": "code", - "expr": "sum(rate(vm_http_requests_total{job=~\"$job_insert\", instance=~\"$instance\", path!~\"/favicon.ico|/metrics\"}[$__rate_interval])) by (path) > 0", + "expr": "sum(rate(vm_http_requests_total{job=~\"$job_insert\", instance=~\"$instance\"}[$__rate_interval])) by (path) > 0", "format": "time_series", "intervalFactor": 1, "legendFormat": "__auto", diff --git a/dashboards/vm/victoriametrics.json b/dashboards/vm/victoriametrics.json index 2b36b9c41..ff18d36bf 100644 --- a/dashboards/vm/victoriametrics.json +++ b/dashboards/vm/victoriametrics.json @@ -1036,7 +1036,7 @@ "uid": "$ds" }, "editorMode": "code", - "expr": "sum(rate(vm_http_requests_total{job=~\"$job\", instance=~\"$instance\", path!~\"/favicon.ico\"}[$__rate_interval])) by (path) > 0", + "expr": "sum(rate(vm_http_requests_total{job=~\"$job\", instance=~\"$instance\"}[$__rate_interval])) by (path) > 0", "format": "time_series", "interval": "", "intervalFactor": 1, diff --git a/dashboards/vm/vmagent.json b/dashboards/vm/vmagent.json index 5fbabac4e..bb8c6f63e 100644 --- a/dashboards/vm/vmagent.json +++ b/dashboards/vm/vmagent.json @@ -191,7 +191,7 @@ "uid": "$ds" }, "editorMode": "code", - "expr": "sum(rate(vm_promscrape_scraped_samples_sum{job=~\"$job\", instance=~\"$instance\", path!~\"/favicon.ico\"}[$__rate_interval]))", + "expr": "sum(rate(vm_promscrape_scraped_samples_sum{job=~\"$job\", instance=~\"$instance\"}[$__rate_interval]))", "interval": "", "legendFormat": "__auto", "range": true, @@ -4429,7 +4429,7 @@ "uid": "$ds" }, "exemplar": true, - "expr": "sum(rate(vm_ingestserver_request_errors_total{job=~\"$job\", instance=~\"$instance\", path!~\"/favicon.ico\"}[$__rate_interval])) by(type, net) > 0", + "expr": "sum(rate(vm_ingestserver_request_errors_total{job=~\"$job\", instance=~\"$instance\"}[$__rate_interval])) by(type, net) > 0", "interval": "", "legendFormat": "{{ type }} ({{net}})", "refId": "A" @@ -5946,4 +5946,4 @@ "uid": "G7Z9GzMGz_vm", "version": 1, "weekStart": "" -} \ No newline at end of file +} diff --git a/dashboards/vmagent.json b/dashboards/vmagent.json index 692bdfbd6..d66f35a03 100644 --- a/dashboards/vmagent.json +++ b/dashboards/vmagent.json @@ -190,7 +190,7 @@ "uid": "$ds" }, "editorMode": "code", - "expr": "sum(rate(vm_promscrape_scraped_samples_sum{job=~\"$job\", instance=~\"$instance\", path!~\"/favicon.ico\"}[$__rate_interval]))", + "expr": "sum(rate(vm_promscrape_scraped_samples_sum{job=~\"$job\", instance=~\"$instance\"}[$__rate_interval]))", "interval": "", "legendFormat": "__auto", "range": true, @@ -4428,7 +4428,7 @@ "uid": "$ds" }, "exemplar": true, - "expr": "sum(rate(vm_ingestserver_request_errors_total{job=~\"$job\", instance=~\"$instance\", path!~\"/favicon.ico\"}[$__rate_interval])) by(type, net) > 0", + "expr": "sum(rate(vm_ingestserver_request_errors_total{job=~\"$job\", instance=~\"$instance\"}[$__rate_interval])) by(type, net) > 0", "interval": "", "legendFormat": "{{ type }} ({{net}})", "refId": "A" @@ -5945,4 +5945,4 @@ "uid": "G7Z9GzMGz", "version": 1, "weekStart": "" -} \ No newline at end of file +}