From 9a355c3512867e34a38b1a3078e71eca00e41710 Mon Sep 17 00:00:00 2001 From: Fred Navruzov Date: Tue, 11 Jun 2024 15:29:11 +0200 Subject: [PATCH 1/3] docs/vmanomaly - fix 404 img links & remove outdated models (#6460) ### Describe Your Changes Fix 404 relative img links for v1.13.0 update of vmanomaly docs ### Checklist The following checks are **mandatory**: - [x] My change adheres [VictoriaMetrics contributing guidelines](https://docs.victoriametrics.com/contributing/). --- docs/anomaly-detection/Overview.md | 4 ---- docs/anomaly-detection/components/models.md | 22 ++++++++++----------- 2 files changed, 11 insertions(+), 15 deletions(-) diff --git a/docs/anomaly-detection/Overview.md b/docs/anomaly-detection/Overview.md index d089401206..d164fa4c8b 100644 --- a/docs/anomaly-detection/Overview.md +++ b/docs/anomaly-detection/Overview.md @@ -88,10 +88,6 @@ Currently, vmanomaly ships with a set of built-in models: See [statsmodels.org documentation](https://www.statsmodels.org/dev/examples/notebooks/generated/stl_decomposition.html) for LOESS STD. -1. [**ARIMA**](/anomaly-detection/components/models.html#arima) - - Commonly used forecasting model. See [statsmodels.org documentation](https://www.statsmodels.org/stable/generated/statsmodels.tsa.arima.model.ARIMA.html) for ARIMA. - 1. [**Rolling Quantile**](/anomaly-detection/components/models.html#rolling-quantile) A simple moving window of quantiles. Easy to use, easy to understand, but not as powerful as diff --git a/docs/anomaly-detection/components/models.md b/docs/anomaly-detection/components/models.md index e47d245e6b..47e11626c2 100644 --- a/docs/anomaly-detection/components/models.md +++ b/docs/anomaly-detection/components/models.md @@ -135,19 +135,19 @@ Introduced in [1.13.0](/anomaly-detection/CHANGELOG/#1130), `detection_direction Here's how default (backward-compatible) behavior looks like - anomalies will be tracked in `both` directions (`y > yhat` or `y < yhat`). This is useful when there is no domain expertise to filter the required direction. -schema_detection_direction=both +schema_detection_direction=both When set to `above_expected`, anomalies are tracked only when `y > yhat`. *Example metrics*: Error rate, response time, page load time, number of failed transactions - metrics where *lower values are better*, so **higher** values are typically tracked. -schema_detection_direction=above_expected +schema_detection_direction=above_expected When set to `below_expected`, anomalies are tracked only when `y < yhat`. *Example metrics*: Service Level Agreement (SLA) compliance, conversion rate, Customer Satisfaction Score (CSAT) - metrics where *higher values are better*, so **lower** values are typically tracked. -schema_detection_direction=below_expected +schema_detection_direction=below_expected Config with a split example: @@ -193,11 +193,11 @@ Introduced in [v1.13.0](/anomaly-detection/CHANGELOG/#1130), the `min_dev_from_e Visualizations below demonstrate this concept; the green zone defined as the `[yhat - min_dev_from_expected, yhat + min_dev_from_expected]` range excludes actual data points (`y`) from generating anomaly scores if they fall within that range. -min_dev_from_expected-default +min_dev_from_expected-default -min_dev_from_expected-small +min_dev_from_expected-small -min_dev_from_expected-big +min_dev_from_expected-big ## Model types @@ -224,7 +224,7 @@ If during an inference, you got a series having **new labelset** (not present in **Examples:** [Prophet](#prophet), [Holt-Winters](#holt-winters)

-vmanomaly-model-type-univariate +vmanomaly-model-type-univariate ### Multivariate Models @@ -239,7 +239,7 @@ If during an inference, you got a **different amount of series** or some series **Examples:** [IsolationForest](#isolation-forest-multivariate)

-vmanomaly-model-type-multivariate +vmanomaly-model-type-multivariate ### Rolling Models @@ -256,7 +256,7 @@ Such models put **more pressure** on your reader's source, i.e. if your model sh **Examples:** [RollingQuantile](#rolling-quantile)

-vmanomaly-model-type-rolling +vmanomaly-model-type-rolling ### Non-Rolling Models @@ -273,7 +273,7 @@ Produced model instances are **stored in-memory** between consecutive re-fit cal **Examples:** [Prophet](#prophet)

-vmanomaly-model-type-non-rolling +vmanomaly-model-type-non-rolling ## Built-in Models @@ -312,7 +312,7 @@ Tuning hyperparameters of a model can be tricky and often requires in-depth know - `n_trials` (int) - How many trials to sample from hyperparameter search space. The higher, the longer it takes but the better the results can be. Defaults to 128. - `timeout` (float) - How many seconds in total can be spent on each model to tune hyperparameters. The higher, the longer it takes, allowing to test more trials out of defined `n_trials`, but the better the results can be. -vmanomaly-autotune-schema +vmanomaly-autotune-schema ```yaml # ... From 239a7b6e6fec21dc8fdb54ace2f85d575f7dd385 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Tue, 11 Jun 2024 16:01:26 +0200 Subject: [PATCH 2/3] Makefile: update golangci-lint from v1.57.1 to v1.59.1 See https://github.com/golangci/golangci-lint/releases/tag/v1.59.1 Thanks to ccoVeille for the suggestion at https://www.reddit.com/r/golang/comments/1dcl4ne/log_viewer_in_go/l82vsfd/ --- .golangci.yml | 2 +- Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index c0df40161d..c3cbae0dce 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -16,4 +16,4 @@ issues: linters-settings: errcheck: - exclude: ./errcheck_excludes.txt + exclude-functions: ./errcheck_excludes.txt diff --git a/Makefile b/Makefile index 4dc679ce3f..e40dad5052 100644 --- a/Makefile +++ b/Makefile @@ -492,7 +492,7 @@ golangci-lint: install-golangci-lint golangci-lint run install-golangci-lint: - which golangci-lint || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin v1.57.1 + which golangci-lint || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin v1.59.1 govulncheck: install-govulncheck govulncheck ./... From 4ad1f8ee3a5f941f5d73435b7f1b8686e0f40c18 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Tue, 11 Jun 2024 16:41:01 +0200 Subject: [PATCH 3/3] .golangci.yml: properly specify functions to exclude for return values check after the upgrade to v1.59.1 at 239a7b6e6fec21dc8fdb54ace2f85d575f7dd385 --- .golangci.yml | 5 ++++- errcheck_excludes.txt | 3 --- 2 files changed, 4 insertions(+), 4 deletions(-) delete mode 100644 errcheck_excludes.txt diff --git a/.golangci.yml b/.golangci.yml index c3cbae0dce..a5cb830575 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -16,4 +16,7 @@ issues: linters-settings: errcheck: - exclude-functions: ./errcheck_excludes.txt + exclude-functions: + - "fmt.Fprintf" + - "fmt.Fprint" + - "(net/http.ResponseWriter).Write" diff --git a/errcheck_excludes.txt b/errcheck_excludes.txt deleted file mode 100644 index 1c1db27029..0000000000 --- a/errcheck_excludes.txt +++ /dev/null @@ -1,3 +0,0 @@ -fmt.Fprintf -fmt.Fprint -(net/http.ResponseWriter).Write