From b5645ccbdf8e2fb146859cb5bba020c1e630f027 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Fri, 3 Jan 2020 01:02:04 +0200 Subject: [PATCH] app/vmselect/promql: increase the estimated number of time series returned by `aggr() by (something)` from 100 to 1K, since 100 may result in OOM for high number of time series --- app/vmselect/promql/eval.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/vmselect/promql/eval.go b/app/vmselect/promql/eval.go index 07bd6d372b..d715e7fd27 100644 --- a/app/vmselect/promql/eval.go +++ b/app/vmselect/promql/eval.go @@ -617,8 +617,8 @@ func evalRollupFuncWithMetricExpr(ec *EvalConfig, name string, rf rollupFunc, me if iafc.ae.Modifier.Op != "" { // Increase the number of timeseries for non-empty group list: `aggr() by (something)`, // since each group can have own set of time series in memory. - // Estimate the number of such groups is lower than 100 :) - timeseriesLen *= 100 + // Estimate the number of such groups is lower than 1000 :) + timeseriesLen *= 1000 } } rollupPoints := mulNoOverflow(pointsPerTimeseries, int64(timeseriesLen*len(rcs)))