From b7cc1af3ebe4c4c93bfbab019efc857cc3deb502 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Tue, 23 Jan 2024 01:45:15 +0200 Subject: [PATCH] app/vmselect/promql/aggr_incremental.go: eliminate unnecessary memory allocation in incrementalAggrFuncContext.updateTimeseries --- app/vmselect/promql/aggr_incremental.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/vmselect/promql/aggr_incremental.go b/app/vmselect/promql/aggr_incremental.go index 4ae701b45..1392b270f 100644 --- a/app/vmselect/promql/aggr_incremental.go +++ b/app/vmselect/promql/aggr_incremental.go @@ -111,8 +111,8 @@ func (iafc *incrementalAggrFuncContext) updateTimeseries(tsOrig *timeseries, wor removeGroupTags(&ts.MetricName, &iafc.ae.Modifier) bb := bbPool.Get() bb.B = marshalMetricNameSorted(bb.B[:0], &ts.MetricName) - k := string(bb.B) - iac := m[k] + k := bb.B + iac := m[string(k)] if iac == nil { if iafc.ae.Limit > 0 && len(m) >= iafc.ae.Limit { // Skip this time series, since the limit on the number of output time series has been already reached. @@ -131,7 +131,7 @@ func (iafc *incrementalAggrFuncContext) updateTimeseries(tsOrig *timeseries, wor ts: tsAggr, values: make([]float64, len(ts.Values)), } - m[k] = iac + m[string(k)] = iac } bbPool.Put(bb) iafc.callbacks.updateAggrFunc(iac, ts.Values)