github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/protoparser/prometheus: follow-up for 8e338632a3

Browse source 
Do not spend CPU time on error message formatting if error logger is disabled
This commit is contained in:
Aliaksandr Valialkin 2021-11-30 00:50:07 +02:00
parent 8e338632a3
commit ba927d1c77
No known key found for this signature in database
GPG key ID: A72BEC6CD3D0DED1
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
lib/protoparser/prometheus/parser.go
View file

@ -47,8 +47,6 @@ func stdErrLogger(s string) {
logger.ErrorfSkipframes(1, "%s", s)
}
func noOpLogger(s string) {}
// UnmarshalWithErrLogger unmarshal Prometheus exposition text rows from s.
//
// It calls errLogger for logging parsing errors.
@ -228,8 +226,10 @@ func unmarshalRow(dst []Row, s string, tagsPool []Tag, noEscapes bool, errLogger
tagsPool, err = r.unmarshal(s, tagsPool, noEscapes)
if err != nil {
dst = dst[:len(dst)-1]
msg := fmt.Sprintf("cannot unmarshal Prometheus line %q: %s", s, err)
errLogger(msg)
if errLogger != nil {
msg := fmt.Sprintf("cannot unmarshal Prometheus line %q: %s", s, err)
errLogger(msg)
}
invalidLines.Inc()
}
return dst, tagsPool
@ -475,10 +475,8 @@ func (li *linesIterator) NextKey() bool {
if len(li.a) == 0 {
return false
}
// there is no need to log error here,
// it's already logged by GetRowsDiff caller.
// otherwise, there is no good way to suppress it.
li.rows, li.tagsPool = unmarshalRow(li.rows[:0], li.a[0], li.tagsPool[:0], false, noOpLogger)
// Do not log errors here, since they will be logged during the real data parsing later.
li.rows, li.tagsPool = unmarshalRow(li.rows[:0], li.a[0], li.tagsPool[:0], false, nil)
li.a = li.a[1:]
if len(li.rows) > 0 {
li.Key = marshalMetricNameWithTags(li.Key[:0], &li.rows[0])