From c04880909b389eb12a9f427a5fdf531231db08f8 Mon Sep 17 00:00:00 2001 From: hagen1778 Date: Mon, 3 Jun 2024 12:52:02 +0200 Subject: [PATCH] app/vmalert: rm extra response for unsupported path Unsupported path is already handled by `lib/httpserver`. This prevents from misleading errors in logs caused by double-writing response headers. Signed-off-by: hagen1778 (cherry picked from commit a5f81f67fdc3214865221714677033cf8127c67b) Signed-off-by: hagen1778 --- app/vmalert/web.go | 1 - docs/CHANGELOG.md | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/app/vmalert/web.go b/app/vmalert/web.go index 16855d0513..23346efe6d 100644 --- a/app/vmalert/web.go +++ b/app/vmalert/web.go @@ -138,7 +138,6 @@ func (rh *requestHandler) handler(w http.ResponseWriter, r *http.Request) bool { return true default: - httpserver.Errorf(w, r, "unsupported path requested: %q ", r.URL.Path) return false } } diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 80ea478b02..cb4db53706 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -18,6 +18,7 @@ The following `tip` changes can be tested by building VictoriaMetrics components * BUGFIX: [vmagent](https://docs.victoriametrics.com/vmagent/): skip empty data blocks before sending to the remote write destination. Thanks to @viperstars for [the pull request](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6241). * BUGFIX: properly estimate the needed memory for query execution if it has the format [`aggr_func`](https://docs.victoriametrics.com/metricsql/#aggregate-functions)([`rollup_func[d]`](https://docs.victoriametrics.com/metricsql/#rollup-functions) (for example, `sum(rate(request_duration_seconds_bucket[5m]))`). This should allow performing aggregations over bigger number of time series when VictoriaMetrics runs in environments with small amounts of available memory. The issue has been introduced in [this commit](https://github.com/VictoriaMetrics/VictoriaMetrics/commit/5138eaeea0791caa34bcfab410e0ca9cd253cd8f) in [v1.83.0](https://docs.victoriametrics.com/changelog_2022/#v1830). * BUGFIX: [Single-node VictoriaMetrics](https://docs.victoriametrics.com/) and `vmselect` in [VictoriaMetrics cluster](https://docs.victoriametrics.com/cluster-victoriametrics/): filter deleted label names and values from [`/api/v1/labels`](https://docs.victoriametrics.com/url-examples/#apiv1labels) and [`/api/v1/label/.../values`](https://docs.victoriametrics.com/url-examples/#apiv1labelvalues) responses when `match[]` filter matches small number of time series. The issue was introduced [v1.81.0](https://docs.victoriametrics.com/changelog_2022/#v1810). +* BUGFIX: [vmalert](https://docs.victoriametrics.com/vmalert/): fix misleading error logs in vmalert's stdout when unsupported HTTP path is requested. ## [v1.93.14](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.93.14)