From c2d252c04565386f8a0988325a2d26cb6cb85419 Mon Sep 17 00:00:00 2001 From: hagen1778 Date: Tue, 17 Oct 2023 09:40:39 +0200 Subject: [PATCH] dashboards/vmalert: respect job and instance filters in `No data errors` Signed-off-by: hagen1778 --- dashboards/vm/vmalert.json | 2 +- dashboards/vmalert.json | 2 +- docs/CHANGELOG.md | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/dashboards/vm/vmalert.json b/dashboards/vm/vmalert.json index 506bf202b..adc42c26c 100644 --- a/dashboards/vm/vmalert.json +++ b/dashboards/vm/vmalert.json @@ -462,7 +462,7 @@ }, "editorMode": "code", "exemplar": false, - "expr": "count(vmalert_recording_rules_last_evaluation_samples < 1) or 0", + "expr": "count(vmalert_recording_rules_last_evaluation_samples{job=~\"$job\", instance=~\"$instance\"} < 1) or 0", "interval": "", "legendFormat": "", "range": true, diff --git a/dashboards/vmalert.json b/dashboards/vmalert.json index 6d312f5fe..92974054a 100644 --- a/dashboards/vmalert.json +++ b/dashboards/vmalert.json @@ -461,7 +461,7 @@ }, "editorMode": "code", "exemplar": false, - "expr": "count(vmalert_recording_rules_last_evaluation_samples < 1) or 0", + "expr": "count(vmalert_recording_rules_last_evaluation_samples{job=~\"$job\", instance=~\"$instance\"} < 1) or 0", "interval": "", "legendFormat": "", "range": true, diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 94223eeb1..b6976d5bd 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -52,7 +52,8 @@ The sandbox cluster installation is running under the constant load generated by * BUGFIX: [vmalert](https://docs.victoriametrics.com/vmalert.html): fix vmalert web UI when running on 32-bit architectures machine. * BUGFIX: [vmselect](https://docs.victoriametrics.com/Cluster-VictoriaMetrics.html): improve performance and memory usage during query processing on machines with big number of CPU cores. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5087) for details. * BUGFIX: dashboards: fix vminsert/vmstorage/vmselect metrics filtering when dashboard is used to display data from many sub-clusters with unique job names. Before, only one specific job could have been accounted for component-specific panels, instead of all available jobs for the component. -* BUGFIX: dashboards: apply `desc` sorting in tooltips for vmalert dashboard in order to improve visibility of the outliers on graph. +* BUGFIX: dashboards/vmalert: apply `desc` sorting in tooltips for vmalert dashboard in order to improve visibility of the outliers on graph. +* BUGFIX: dashboards/vmalert: properly apply time series filter for panel `No data errors`. Before, the panel didn't respect `job` or `instance` filters. * BUGFIX: [VictoriaMetrics cluster](https://docs.victoriametrics.com/Cluster-VictoriaMetrics.html): bump hard-coded limit for search query size at `vmstorage` from 1MB to 5MB. The change should be more suitable for real-world scenarios and protect vmstorage from excessive memory usage. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5154) for details * BUGFIX: [vmbackup](https://docs.victoriametrics.com/vmbackup.html): fix error when creating an incremental backup with the `-origin` command-line flag. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5144) for details. * BUGFIX: [vmagent](https://docs.victoriametrics.com/vmagent.html): fix vmagent ignoring configuration reload for streaming aggregation if it was started with empty streaming aggregation config. Thanks to @aluode99 for the [pull request](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5178).