From c4ec9779345decffa87aa3cfc45ef7836288b23b Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Tue, 15 Dec 2020 20:56:16 +0200 Subject: [PATCH] lib/promscrape: properly remove deleted target from `/targets` page Previously `sw` variable wasn't captured correctly by the started goroutine. --- lib/promscrape/scraper.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/promscrape/scraper.go b/lib/promscrape/scraper.go index 0570f95e63..901b5a0fb2 100644 --- a/lib/promscrape/scraper.go +++ b/lib/promscrape/scraper.go @@ -318,14 +318,14 @@ func (sg *scraperGroup) update(sws []*ScrapeWork) { sg.activeScrapers.Inc() sg.scrapersStarted.Inc() sg.wg.Add(1) - go func() { + tsmGlobal.Register(sw) + go func(sw *ScrapeWork) { defer sg.wg.Done() sc.sw.run(sc.stopCh) tsmGlobal.Unregister(sw) sg.activeScrapers.Dec() sg.scrapersStopped.Inc() - }() - tsmGlobal.Register(sw) + }(sw) sg.m[key] = sc additionsCount++ }