From c56c2df1173cb1fe066f5d2de39e862514d0a985 Mon Sep 17 00:00:00 2001
From: luosjde <luosjde@163.com>
Date: Mon, 16 Oct 2023 21:57:24 +0800
Subject: [PATCH] vmagent: fix streamaggr config reload bug
https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5170
Authored-by: luoshaojun01 <luoshaojun01@baidu.com>
---
app/vmagent/remotewrite/remotewrite.go | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/vmagent/remotewrite/remotewrite.go b/app/vmagent/remotewrite/remotewrite.go
index 88eb0daa96..31f32267e8 100644
--- a/app/vmagent/remotewrite/remotewrite.go
+++ b/app/vmagent/remotewrite/remotewrite.go
@@ -743,12 +743,12 @@ func (rwctx *remoteWriteCtx) pushInternal(tss []prompbmarshal.TimeSeries) {
func (rwctx *remoteWriteCtx) reinitStreamAggr() {
sas := rwctx.sas.Load()
- if sas == nil {
+
+ sasFile := streamAggrConfig.GetOptionalArg(rwctx.idx)
+ if sasFile == "" {
// There is no stream aggregation for rwctx
return
}
-
- sasFile := streamAggrConfig.GetOptionalArg(rwctx.idx)
logger.Infof("reloading stream aggregation configs pointed by -remoteWrite.streamAggr.config=%q", sasFile)
metrics.GetOrCreateCounter(fmt.Sprintf(`vmagent_streamaggr_config_reloads_total{path=%q}`, sasFile)).Inc()
dedupInterval := streamAggrDedupInterval.GetOptionalArg(rwctx.idx)