github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-03-11 15:34:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/promscrape: remove possible data race when cleaning up internStringsMap

Browse source
This commit is contained in:
Aliaksandr Valialkin 2022-04-20 18:40:53 +03:00
parent 82e34984dd
commit c75d0095f5
No known key found for this signature in database
GPG key ID: A72BEC6CD3D0DED1
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lib/promscrape/config.go
View file

@ -1222,26 +1222,31 @@ func internLabelStrings(labels []prompbmarshal.Label) {
}
func internString(s string) string {
if v, ok := internStringsMap.Load(s); ok {
m := internStringsMap.Load().(*sync.Map)
if v, ok := m.Load(s); ok {
sp := v.(*string)
return *sp
}
// Make a new copy for s in order to remove references from possible bigger string s refers to.
sCopy := string(append([]byte{}, s...))
internStringsMap.Store(sCopy, &sCopy)
m.Store(sCopy, &sCopy)
n := atomic.AddUint64(&internStringsMapLen, 1)
if n > 100e3 {
atomic.StoreUint64(&internStringsMapLen, 0)
internStringsMap = &sync.Map{}
internStringsMap.Store(&sync.Map{})
}
return sCopy
}
var (
internStringsMap = &sync.Map{}
internStringsMap atomic.Value
internStringsMapLen uint64
)
func init() {
internStringsMap.Store(&sync.Map{})
}
func getParamsFromLabels(labels []prompbmarshal.Label, paramsOrig map[string][]string) map[string][]string {
// See https://www.robustperception.io/life-of-a-label
m := make(map[string][]string)