From c76084b529421df7821424c57773c0785db3d1e3 Mon Sep 17 00:00:00 2001 From: Dmytro Kozlov Date: Thu, 13 Jul 2023 17:14:43 +0200 Subject: [PATCH] app/vmctl: fix panic `--remote-read-filter-time-start` flag not defined (#4605) * app/vmctl: fix panic `--remote-read-filter-time-start` flag not defined * app/vmctl: update CHANGELOG.md --------- Co-authored-by: Nikolay --- app/vmctl/flags.go | 7 ++++--- docs/CHANGELOG.md | 1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/vmctl/flags.go b/app/vmctl/flags.go index 9e6e2d4c6..c41c2cef3 100644 --- a/app/vmctl/flags.go +++ b/app/vmctl/flags.go @@ -478,9 +478,10 @@ var ( Value: 1, }, &cli.TimestampFlag{ - Name: remoteReadFilterTimeStart, - Usage: "The time filter in RFC3339 format to select timeseries with timestamp equal or higher than provided value. E.g. '2020-01-01T20:07:00Z'", - Layout: time.RFC3339, + Name: remoteReadFilterTimeStart, + Usage: "The time filter in RFC3339 format to select timeseries with timestamp equal or higher than provided value. E.g. '2020-01-01T20:07:00Z'", + Layout: time.RFC3339, + Required: true, }, &cli.TimestampFlag{ Name: remoteReadFilterTimeEnd, diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index f9c53f2cf..b758b643a 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -51,6 +51,7 @@ The following tip changes can be tested by building VictoriaMetrics components f * BUGFIX: [vmui](https://docs.victoriametrics.com/#vmui): fix application routing issues and problems with manual URL changes. See [this pull request](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/4408). * BUGFIX: add validation for invalid [partial RFC3339 timestamp formats](https://docs.victoriametrics.com/Single-server-VictoriaMetrics.html#timestamp-formats) in query and export APIs. * BUGFIX: [vmctl](https://docs.victoriametrics.com/vmctl.html): interrupt explore procedure in influx mode if vmctl found no numeric fields. +* BUGFIX: [vmctl](https://docs.victoriametrics.com/vmctl.html): fix panic in case `--remote-read-filter-time-start` flag is not set for remote-read mode. This flag is now required to use remote-read mode. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4553). * BUGFIX: [vmctl](https://docs.victoriametrics.com/vmctl.html): fix issue with adding additional character if length of the if the length of the string has become less than the previous length. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4555). * BUGFIX: [vmalert](https://docs.victoriametrics.com/vmalert.html): use RFC3339 time format in query args instead of unix timestamp for all issued queries to Prometheus-like datasources. * BUGFIX: [vmalert](https://docs.victoriametrics.com/vmalert.html): correctly calculate evaluation time for rules. Before, there was a low probability for discrepancy between actual time and rules evaluation time if evaluation interval was lower than the execution time for rules within the group.