From c90adf566eebcdc19514bad2dc1121972634c162 Mon Sep 17 00:00:00 2001 From: Hui Wang Date: Thu, 17 Oct 2024 16:51:12 +0800 Subject: [PATCH] vmalert-tool: reduce victoriametrics health check interval (#7256) address https://github.com/VictoriaMetrics/VictoriaMetrics/issues/6970. This reduces the hard limit on duration for completing the test when users run vmalert-tool on slow hosts. --------- Signed-off-by: hagen1778 Co-authored-by: hagen1778 --- app/vmalert-tool/unittest/unittest.go | 2 +- docs/changelog/CHANGELOG.md | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/app/vmalert-tool/unittest/unittest.go b/app/vmalert-tool/unittest/unittest.go index c592ce19b..64fd0a9cc 100644 --- a/app/vmalert-tool/unittest/unittest.go +++ b/app/vmalert-tool/unittest/unittest.go @@ -250,7 +250,7 @@ checkCheck: if readyCheckFunc() { break checkCheck } - time.Sleep(3 * time.Second) + time.Sleep(100 * time.Millisecond) } } } diff --git a/docs/changelog/CHANGELOG.md b/docs/changelog/CHANGELOG.md index 1f615f532..800f093da 100644 --- a/docs/changelog/CHANGELOG.md +++ b/docs/changelog/CHANGELOG.md @@ -18,9 +18,6 @@ See also [LTS releases](https://docs.victoriametrics.com/lts-releases/). ## tip - - - * FEATURE: add Darwin binaries for [VictoriaMetrics cluster](https://docs.victoriametrics.com/cluster-victoriametrics/) to the release flow. The binaries will be available in the new release. * FEATURE: [vmagent](https://docs.victoriametrics.com/vmagent/): allow using HTTP/2 client for Kubernetes service discovery if `-promscrape.kubernetes.useHTTP2Client` cmd-line flag is set. This could help to reduce the amount of opened connections to the Kubernetes API server. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5971) for the details. * FEATURE: [vmalert](https://docs.victoriametrics.com/vmalert/): `-rule` cmd-line flag now supports multi-document YAML files. This could be useful when rules are retrieved via HTTP URL where multiple rule files were merged together in one response. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/6753). Thanks to @Irene-123 for [the pull request](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6995). @@ -32,7 +29,7 @@ See also [LTS releases](https://docs.victoriametrics.com/lts-releases/). * BUGFIX: [vmgateway](https://docs.victoriametrics.com/vmgateway/): fix possible panic during parsing of a token without `vm_access` claim. This issue was introduced in v1.104.0. * BUGFIX: [vmui](https://docs.victoriametrics.com/#vmui): fix error messages rendering from overflowing the screen with long messages. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/7207). * BUGFIX: [vmctl](https://docs.victoriametrics.com/vmctl/): properly add metrics tags for `opentsdb` migration source. Previously it could have empty values. See [this PR](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/7161). - +* BUGFIX: [vmalert-tool](https://docs.victoriametrics.com/vmalert-tool/): reduce the initial health check interval for datasource. This reduces the time spent on evaluating rules by vmalert-tool. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/6970). ## [v1.104.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.104.0)