From d0e7c0535ed97a4d1e2360abbdd9862f43751efc Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Thu, 28 Oct 2021 11:00:49 +0300 Subject: [PATCH] lib/logger: show only explicitly set command-line flags in logs This reduces initial verbosity in logs --- lib/logger/flag.go | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lib/logger/flag.go b/lib/logger/flag.go index 74a5963f9c..1383cad94d 100644 --- a/lib/logger/flag.go +++ b/lib/logger/flag.go @@ -11,20 +11,12 @@ import ( func logAllFlags() { Infof("build version: %s", buildinfo.Version) Infof("command line flags") - isSetMap := make(map[string]bool) flag.Visit(func(f *flag.Flag) { - isSetMap[f.Name] = true - }) - flag.VisitAll(func(f *flag.Flag) { lname := strings.ToLower(f.Name) value := f.Value.String() if flagutil.IsSecretFlag(lname) { value = "secret" } - isSet := "false" - if isSetMap[f.Name] { - isSet = "true" - } - Infof("flag %q=%q (is_set=%s)", f.Name, value, isSet) + Infof("flag %q=%q", f.Name, value) }) }