From d2be567482c82d66697a69431e0dc7f6488e1870 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Tue, 11 Jun 2019 00:39:17 +0300 Subject: [PATCH] app/vmselect/promql: remove superflouos timeseries copy in `histogram_quantile` func --- app/vmselect/promql/transform.go | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/app/vmselect/promql/transform.go b/app/vmselect/promql/transform.go index e8e4828f3..5621306e5 100644 --- a/app/vmselect/promql/transform.go +++ b/app/vmselect/promql/transform.go @@ -296,14 +296,12 @@ func transformHistogramQuantile(tfa *transformFuncArg) ([]*timeseries, error) { if err != nil { continue } - var dst timeseries - dst.CopyFrom(ts) - dst.MetricName.ResetMetricGroup() - dst.MetricName.RemoveTag("le") - bb.B = marshalMetricTagsSorted(bb.B[:0], &dst.MetricName) + ts.MetricName.ResetMetricGroup() + ts.MetricName.RemoveTag("le") + bb.B = marshalMetricTagsSorted(bb.B[:0], &ts.MetricName) m[string(bb.B)] = append(m[string(bb.B)], x{ le: le, - ts: &dst, + ts: ts, }) } bbPool.Put(bb)