From d68bb658cee87dac1db39e840357abe68e9f1077 Mon Sep 17 00:00:00 2001 From: Anton L Date: Thu, 22 Feb 2024 12:54:53 +0300 Subject: [PATCH] #5833 Fix Deadlock when using shardByURL of VMAgent (#5834) --- app/vmagent/remotewrite/remotewrite.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/vmagent/remotewrite/remotewrite.go b/app/vmagent/remotewrite/remotewrite.go index 678193cc53..65ee2d730b 100644 --- a/app/vmagent/remotewrite/remotewrite.go +++ b/app/vmagent/remotewrite/remotewrite.go @@ -536,13 +536,13 @@ func tryPushBlockToRemoteStorages(rwctxs []*remoteWriteCtx, tssBlock []prompbmar // Push sharded data to remote storages in parallel in order to reduce // the time needed for sending the data to multiple remote storage systems. var wg sync.WaitGroup - wg.Add(len(rwctxs)) var anyPushFailed uint64 for i, rwctx := range rwctxs { tssShard := tssByURL[i] if len(tssShard) == 0 { continue } + wg.Add(1) go func(rwctx *remoteWriteCtx, tss []prompbmarshal.TimeSeries) { defer wg.Done() if !rwctx.TryPush(tss) {