github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-03-11 15:34:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

app/vmselect/promql: remove memory allocations from sortMetricTags()

Browse source
This commit is contained in:
Aliaksandr Valialkin 2023-01-09 22:22:12 -08:00
parent 8050f5a18c
commit dd92e2050f
No known key found for this signature in database
GPG key ID: A72BEC6CD3D0DED1
1 changed files with 27 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
app/vmselect/promql/timeseries.go
View file

@ -321,26 +321,16 @@ func marshalMetricTagsFast(dst []byte, tags []storage.Tag) []byte {
func marshalMetricNameSorted(dst []byte, mn *storage.MetricName) []byte { func marshalMetricNameSorted(dst []byte, mn *storage.MetricName) []byte {
// Do not marshal AccountID and ProjectID, since they are unused. // Do not marshal AccountID and ProjectID, since they are unused.
dst = marshalBytesFast(dst, mn.MetricGroup) dst = marshalBytesFast(dst, mn.MetricGroup)
sortMetricTags(mn.Tags) sortMetricTags(mn)
dst = marshalMetricTagsFast(dst, mn.Tags) dst = marshalMetricTagsFast(dst, mn.Tags)
return dst return dst
} }
func marshalMetricTagsSorted(dst []byte, mn *storage.MetricName) []byte { func marshalMetricTagsSorted(dst []byte, mn *storage.MetricName) []byte {
sortMetricTags(mn.Tags) sortMetricTags(mn)
return marshalMetricTagsFast(dst, mn.Tags) return marshalMetricTagsFast(dst, mn.Tags)
} }
func sortMetricTags(tags []storage.Tag) {
less := func(i, j int) bool {
return string(tags[i].Key) < string(tags[j].Key)
}
if sort.SliceIsSorted(tags, less) {
return
}
sort.Slice(tags, less)
}
func marshalBytesFast(dst []byte, s []byte) []byte { func marshalBytesFast(dst []byte, s []byte) []byte {
dst = encoding.MarshalUint16(dst, uint16(len(s))) dst = encoding.MarshalUint16(dst, uint16(len(s)))
dst = append(dst, s...) dst = append(dst, s...)
@ -362,14 +352,14 @@ func unmarshalBytesFast(src []byte) ([]byte, []byte, error) {
func stringMetricName(mn *storage.MetricName) string { func stringMetricName(mn *storage.MetricName) string {
var dst []byte var dst []byte
dst = append(dst, mn.MetricGroup...) dst = append(dst, mn.MetricGroup...)
sortMetricTags(mn.Tags) sortMetricTags(mn)
dst = appendStringMetricTags(dst, mn.Tags) dst = appendStringMetricTags(dst, mn.Tags)
return string(dst) return string(dst)
} }
func stringMetricTags(mn *storage.MetricName) string { func stringMetricTags(mn *storage.MetricName) string {
var dst []byte var dst []byte
sortMetricTags(mn.Tags) sortMetricTags(mn)
dst = appendStringMetricTags(dst, mn.Tags) dst = appendStringMetricTags(dst, mn.Tags)
return string(dst) return string(dst)
} }
@ -429,3 +419,26 @@ func assertIdenticalTimestamps(tss []*timeseries, step int64) {
} }
} }
} }
func sortMetricTags(mn *storage.MetricName) {
mts := (*metricTagsSorter)(mn)
if !sort.IsSorted(mts) {
sort.Sort(mts)
}
}
type metricTagsSorter storage.MetricName
func (mts *metricTagsSorter) Len() int {
return len(mts.Tags)
}
func (mts *metricTagsSorter) Less(i, j int) bool {
a := mts.Tags
return string(a[i].Key) < string(a[j].Key)
}
func (mts *metricTagsSorter) Swap(i, j int) {
a := mts.Tags
a[i], a[j] = a[j], a[i]
}