github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-02-19 15:30:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/storage: do not modify filterLoopsCount stats with loopsCount stats

Browse source 
Such a modification can result in incorrect filter sorting later
This commit is contained in:
Aliaksandr Valialkin 2021-03-17 00:38:23 +02:00
parent b997f4a418
commit e2a0c8bd72
1 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/storage/index_db.go
View file

@ -2858,16 +2858,8 @@ func (is *indexSearch) getMetricIDsForDateAndFilters(date uint64, tfs *TagFilter
return int64Max return int64Max
} }
storeLoopsCount := func(tfw *tagFilterWithWeight, loopsCount int64) { storeLoopsCount := func(tfw *tagFilterWithWeight, loopsCount int64) {
needStore := false
if loopsCount != tfw.loopsCount { if loopsCount != tfw.loopsCount {
tfw.loopsCount = loopsCount tfw.loopsCount = loopsCount
needStore = true
}
if loopsCount > tfw.filterLoopsCount {
tfw.filterLoopsCount = loopsCount
needStore = true
}
if needStore {
is.storeLoopsCountForDateFilter(date, tfw.tf, tfw.loopsCount, tfw.filterLoopsCount) is.storeLoopsCountForDateFilter(date, tfw.tf, tfw.loopsCount, tfw.filterLoopsCount)
} }
} }