From e9639a49c2c609429c592448293a1a34ddfa9c4f Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin <valyala@victoriametrics.com> Date: Tue, 14 Nov 2023 21:52:20 +0100 Subject: [PATCH] lib/ingestserver: properly log the number of closed connections Previously there was off-by-one error, which resulted in logging len(conns-1) connections instead of len(conns) Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4922 --- lib/ingestserver/conns_map.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ingestserver/conns_map.go b/lib/ingestserver/conns_map.go index 997a1df1d7..19fafdde9c 100644 --- a/lib/ingestserver/conns_map.go +++ b/lib/ingestserver/conns_map.go @@ -82,8 +82,7 @@ func (cm *ConnsMap) CloseAll(shutdownDuration time.Duration) { remoteAddr := conns[0].RemoteAddr().String() _ = conns[0].Close() logger.Infof("closed %s connection %s", cm.clientName, remoteAddr) - conns = conns[1:] - for _, c := range conns { + for _, c := range conns[1:] { time.Sleep(shutdownInterval) remoteAddr := c.RemoteAddr().String() _ = c.Close()