From efb6ac27c24f367f6a9552ebd2de8458825839a9 Mon Sep 17 00:00:00 2001
From: Aliaksandr Valialkin <valyala@victoriametrics.com>
Date: Tue, 31 Oct 2023 18:33:40 +0100
Subject: [PATCH] lib/httpserver: call Request.Header() only once instead of
 calling it each time a new request header is set

This is a follow-up for ad839aa492704dda3a9f8e5fe9de58c4074bd39a
---
 lib/httpserver/httpserver.go | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/lib/httpserver/httpserver.go b/lib/httpserver/httpserver.go
index c8b40a5e11..5a82d393c5 100644
--- a/lib/httpserver/httpserver.go
+++ b/lib/httpserver/httpserver.go
@@ -242,20 +242,21 @@ func handlerWrapper(s *server, w http.ResponseWriter, r *http.Request, rh Reques
 		}
 	}()
 
+	h := w.Header()
 	if *headerHSTS != "" {
-		w.Header().Add("Strict-Transport-Security", *headerHSTS)
+		h.Add("Strict-Transport-Security", *headerHSTS)
 	}
 	if *headerFrameOptions != "" {
-		w.Header().Add("X-Frame-Options", *headerFrameOptions)
+		h.Add("X-Frame-Options", *headerFrameOptions)
 	}
 	if *headerCSP != "" {
-		w.Header().Add("Content-Security-Policy", *headerCSP)
+		h.Add("Content-Security-Policy", *headerCSP)
 	}
-	w.Header().Add("X-Server-Hostname", hostname)
+	h.Add("X-Server-Hostname", hostname)
 	requestsTotal.Inc()
 	if whetherToCloseConn(r) {
 		connTimeoutClosedConns.Inc()
-		w.Header().Set("Connection", "close")
+		h.Set("Connection", "close")
 	}
 	path := r.URL.Path
 	prefix := GetPathPrefix()
@@ -280,7 +281,7 @@ func handlerWrapper(s *server, w http.ResponseWriter, r *http.Request, rh Reques
 	}
 	switch r.URL.Path {
 	case "/health":
-		w.Header().Set("Content-Type", "text/plain; charset=utf-8")
+		h.Set("Content-Type", "text/plain; charset=utf-8")
 		deadline := atomic.LoadInt64(&s.shutdownDelayDeadline)
 		if deadline <= 0 {
 			w.Write([]byte("OK"))
@@ -315,7 +316,7 @@ func handlerWrapper(s *server, w http.ResponseWriter, r *http.Request, rh Reques
 			return
 		}
 		startTime := time.Now()
-		w.Header().Set("Content-Type", "text/plain; charset=utf-8")
+		h.Set("Content-Type", "text/plain; charset=utf-8")
 		appmetrics.WritePrometheusMetrics(w)
 		metricsHandlerDuration.UpdateDuration(startTime)
 		return
@@ -323,7 +324,7 @@ func handlerWrapper(s *server, w http.ResponseWriter, r *http.Request, rh Reques
 		if !CheckAuthFlag(w, r, *flagsAuthKey, "flagsAuthKey") {
 			return
 		}
-		w.Header().Set("Content-Type", "text/plain; charset=utf-8")
+		h.Set("Content-Type", "text/plain; charset=utf-8")
 		flagutil.WriteFlags(w)
 		return
 	case "/-/healthy":