github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib/storage: fix a bug, which prevents from reading pre-v1.90.0 parts

Browse source 
The bug has been introduced in c0b852d50d
This commit is contained in:
Aliaksandr Valialkin 2023-04-14 22:33:05 -07:00
parent cf4701db65
commit f26e480a77
No known key found for this signature in database
GPG key ID: A72BEC6CD3D0DED1
1 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/storage/part_header.go
View file

@ -135,20 +135,21 @@ func (ph *partHeader) MustReadMetadata(partPath string) {
ph.Reset() ph.Reset()
metadataPath := filepath.Join(partPath, metadataFilename) metadataPath := filepath.Join(partPath, metadataFilename)
metadata, err := os.ReadFile(metadataPath) if !fs.IsPathExist(metadataPath) {
if err != nil {
if os.IsNotExist(err) {
// This is a part created before v1.90.0. // This is a part created before v1.90.0.
// Fall back to reading the metadata from the partPath itsel // Fall back to reading the metadata from the partPath itsel
if err := ph.ParseFromPath(partPath); err != nil { if err := ph.ParseFromPath(partPath); err != nil {
logger.Panicf("FATAL: cannot parse metadata from %q: %s", partPath, err) logger.Panicf("FATAL: cannot parse metadata from %q: %s", partPath, err)
} }
} } else {
metadata, err := os.ReadFile(metadataPath)
if err != nil {
logger.Panicf("FATAL: cannot read %q: %s", metadataPath, err) logger.Panicf("FATAL: cannot read %q: %s", metadataPath, err)
} }
if err := json.Unmarshal(metadata, ph); err != nil { if err := json.Unmarshal(metadata, ph); err != nil {
logger.Panicf("FATAL: cannot parse %q: %s", metadataPath, err) logger.Panicf("FATAL: cannot parse %q: %s", metadataPath, err)
} }
}
// Perform various checks // Perform various checks
if ph.MinTimestamp > ph.MaxTimestamp { if ph.MinTimestamp > ph.MaxTimestamp {