From fb356c434b57bde56391c4adc7466906ed6af6fc Mon Sep 17 00:00:00 2001 From: Nikolay Khramchikhin Date: Mon, 7 Sep 2020 21:53:24 +0300 Subject: [PATCH] Changed s3 configProfile flag default, (#749) aws sdk has complicated logic for chosing profile name and we shouldn't set it to `default` value. It leads to bugs and improper configuration. Set it to empty value by default is safe. It will be automatically set to `default` by sdk. --- lib/backup/actions/util.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/backup/actions/util.go b/lib/backup/actions/util.go index c28974f93..5eebe5b1a 100644 --- a/lib/backup/actions/util.go +++ b/lib/backup/actions/util.go @@ -18,7 +18,8 @@ var ( "See https://cloud.google.com/iam/docs/creating-managing-service-account-keys and https://docs.aws.amazon.com/general/latest/gr/aws-security-credentials.html") configFilePath = flag.String("configFilePath", "", "Path to file with S3 configs. Configs are loaded from default location if not set.\n"+ "See https://docs.aws.amazon.com/general/latest/gr/aws-security-credentials.html") - configProfile = flag.String("configProfile", "default", "Profile name for S3 configs") + configProfile = flag.String("configProfile", "", "Profile name for S3 configs. If no set, the value of the environment variable will be loaded (AWS_PROFILE or AWS_DEFAULT_PROFILE), "+ + "or if both not set, DefaultSharedConfigProfile is used") customS3Endpoint = flag.String("customS3Endpoint", "", "Custom S3 endpoint for use with S3-compatible storages (e.g. MinIO). S3 is used if not set") )