From fb7454a14d1f5c014914ce3a192b99e62490d768 Mon Sep 17 00:00:00 2001 From: Hui Wang <haley@victoriametrics.com> Date: Thu, 20 Jun 2024 17:47:00 +0800 Subject: [PATCH] vmalert-tool: exit immediately when rule group execute failed (#6509) g.ExecOnce() shouldn't be failed at all. If it fails, it might be bug or something wrong with tmp vm datasource, exit immediately. --- app/vmalert-tool/unittest/unittest.go | 1 + 1 file changed, 1 insertion(+) diff --git a/app/vmalert-tool/unittest/unittest.go b/app/vmalert-tool/unittest/unittest.go index 5341535249..e20b0e36c7 100644 --- a/app/vmalert-tool/unittest/unittest.go +++ b/app/vmalert-tool/unittest/unittest.go @@ -304,6 +304,7 @@ func (tg *testGroup) test(evalInterval time.Duration, groupOrderMap map[string]i if err != nil { checkErrs = append(checkErrs, fmt.Errorf("\nfailed to exec group: %q, time: %s, err: %w", g.Name, ts, err)) + return } } // flush series after each group evaluation