From fbd7044b2b9097e1885a11a8bfa7804f744f96da Mon Sep 17 00:00:00 2001
From: Roman Khavronenko <hagen1778@gmail.com>
Date: Thu, 6 Jun 2019 23:31:45 +0100
Subject: [PATCH] Dashboard update (#57)

* split "pending datapoints" by storage and index pending entities

* update provisioned dVM dashboard
---
 dashboards/victoriametrics.json               | 95 ++++++++++++-------
 .../dashboards/victoriametrics.json           | 66 +++++++------
 2 files changed, 98 insertions(+), 63 deletions(-)

diff --git a/dashboards/victoriametrics.json b/dashboards/victoriametrics.json
index 746588a4cd..dbf4874393 100644
--- a/dashboards/victoriametrics.json
+++ b/dashboards/victoriametrics.json
@@ -14,37 +14,37 @@
       "type": "grafana",
       "id": "grafana",
       "name": "Grafana",
-      "version": "5.0.0"
+      "version": "6.2.1"
     },
     {
       "type": "panel",
       "id": "graph",
       "name": "Graph",
-      "version": "5.0.0"
+      "version": ""
     },
     {
       "type": "datasource",
       "id": "prometheus",
       "name": "Prometheus",
-      "version": "5.0.0"
+      "version": "1.0.0"
     },
     {
       "type": "panel",
       "id": "singlestat",
       "name": "Singlestat",
-      "version": "5.0.0"
+      "version": ""
     },
     {
       "type": "panel",
       "id": "table",
       "name": "Table",
-      "version": "5.0.0"
+      "version": ""
     },
     {
       "type": "panel",
       "id": "text",
       "name": "Text",
-      "version": "5.0.0"
+      "version": ""
     }
   ],
   "annotations": {
@@ -65,7 +65,7 @@
   "gnetId": 10229,
   "graphTooltip": 0,
   "id": null,
-  "iteration": 1558335960106,
+  "iteration": 1559857416920,
   "links": [
     {
       "icon": "doc",
@@ -111,7 +111,7 @@
       "content": "<div style=\"text-align: center; font-size: 2em\">$version</div>",
       "description": "",
       "gridPos": {
-        "h": 2,
+        "h": 3,
         "w": 8,
         "x": 0,
         "y": 1
@@ -126,6 +126,7 @@
         }
       ],
       "mode": "html",
+      "options": {},
       "timeFrom": null,
       "timeShift": null,
       "title": "Version",
@@ -137,13 +138,14 @@
       "description": "Run VM with `-help` flag to see all the available flags with description and default values",
       "fontSize": "100%",
       "gridPos": {
-        "h": 8,
+        "h": 9,
         "w": 16,
         "x": 8,
         "y": 1
       },
       "id": 4,
       "links": [],
+      "options": {},
       "pageSize": null,
       "scroll": true,
       "showHeader": true,
@@ -237,7 +239,7 @@
         "h": 2,
         "w": 8,
         "x": 0,
-        "y": 3
+        "y": 4
       },
       "id": 26,
       "interval": null,
@@ -256,6 +258,7 @@
       "maxDataPoints": 100,
       "nullPointMode": "connected",
       "nullText": null,
+      "options": {},
       "postfix": "",
       "postfixFontSize": "50%",
       "prefix": "",
@@ -321,7 +324,7 @@
         "h": 2,
         "w": 8,
         "x": 0,
-        "y": 5
+        "y": 6
       },
       "id": 38,
       "interval": null,
@@ -340,6 +343,7 @@
       "maxDataPoints": 100,
       "nullPointMode": "connected",
       "nullText": null,
+      "options": {},
       "postfix": "",
       "postfixFontSize": "50%",
       "prefix": "",
@@ -404,7 +408,7 @@
         "h": 2,
         "w": 8,
         "x": 0,
-        "y": 7
+        "y": 8
       },
       "id": 8,
       "interval": null,
@@ -423,6 +427,7 @@
       "maxDataPoints": 100,
       "nullPointMode": "connected",
       "nullText": null,
+      "options": {},
       "postfix": "",
       "postfixFontSize": "50%",
       "prefix": "",
@@ -470,7 +475,7 @@
         "h": 1,
         "w": 24,
         "x": 0,
-        "y": 9
+        "y": 10
       },
       "id": 24,
       "panels": [],
@@ -489,7 +494,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 10
+        "y": 11
       },
       "id": 12,
       "legend": {
@@ -508,6 +513,7 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null as zero",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
@@ -578,7 +584,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 10
+        "y": 11
       },
       "id": 22,
       "legend": {
@@ -597,6 +603,7 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null as zero",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
@@ -667,7 +674,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 18
+        "y": 19
       },
       "id": 35,
       "legend": {
@@ -686,6 +693,7 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null as zero",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
@@ -756,7 +764,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 18
+        "y": 19
       },
       "id": 33,
       "legend": {
@@ -772,6 +780,7 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
@@ -856,7 +865,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 26
+        "y": 27
       },
       "id": 37,
       "legend": {
@@ -872,6 +881,7 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
@@ -944,7 +954,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 26
+        "y": 27
       },
       "id": 49,
       "legend": {
@@ -960,6 +970,7 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
@@ -1026,7 +1037,7 @@
         "h": 1,
         "w": 24,
         "x": 0,
-        "y": 34
+        "y": 35
       },
       "id": 14,
       "panels": [],
@@ -1045,7 +1056,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 35
+        "y": 36
       },
       "id": 10,
       "legend": {
@@ -1063,6 +1074,7 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null as zero",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
@@ -1140,7 +1152,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 35
+        "y": 36
       },
       "id": 34,
       "legend": {
@@ -1156,13 +1168,14 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
       "renderer": "flot",
       "seriesOverrides": [
         {
-          "alias": "merges",
+          "alias": "pending index entries",
           "yaxis": 2
         }
       ],
@@ -1171,12 +1184,20 @@
       "steppedLine": false,
       "targets": [
         {
-          "expr": "sum(vm_pending_rows{job=\"$job\"})",
+          "expr": "vm_pending_rows{job=\"$job\", type=\"storage\"}",
           "format": "time_series",
           "hide": false,
           "intervalFactor": 1,
-          "legendFormat": "rows",
+          "legendFormat": "pending datapoints",
           "refId": "A"
+        },
+        {
+          "expr": "vm_pending_rows{job=\"$job\", type=\"indexdb\"}",
+          "format": "time_series",
+          "hide": false,
+          "intervalFactor": 1,
+          "legendFormat": "pending index entries",
+          "refId": "B"
         }
       ],
       "thresholds": [],
@@ -1233,7 +1254,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 43
+        "y": 44
       },
       "id": 30,
       "legend": {
@@ -1249,6 +1270,7 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
@@ -1319,7 +1341,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 43
+        "y": 44
       },
       "id": 36,
       "legend": {
@@ -1335,6 +1357,7 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
@@ -1399,7 +1422,7 @@
         "h": 1,
         "w": 24,
         "x": 0,
-        "y": 51
+        "y": 52
       },
       "id": 46,
       "panels": [],
@@ -1418,7 +1441,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 52
+        "y": 53
       },
       "id": 44,
       "legend": {
@@ -1434,6 +1457,7 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
@@ -1520,7 +1544,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 52
+        "y": 53
       },
       "id": 42,
       "legend": {
@@ -1536,6 +1560,7 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
@@ -1605,7 +1630,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 60
+        "y": 61
       },
       "id": 47,
       "legend": {
@@ -1621,6 +1646,7 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
@@ -1691,7 +1717,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 60
+        "y": 61
       },
       "id": 48,
       "legend": {
@@ -1707,6 +1733,7 @@
       "linewidth": 1,
       "links": [],
       "nullPointMode": "null",
+      "options": {},
       "percentage": false,
       "pointradius": 2,
       "points": false,
@@ -1768,7 +1795,7 @@
     }
   ],
   "refresh": "30s",
-  "schemaVersion": 16,
+  "schemaVersion": 18,
   "style": "dark",
   "tags": [],
   "templating": {
@@ -1851,5 +1878,5 @@
   "timezone": "",
   "title": "VictoriaMetrics",
   "uid": "wNf0q_kZk",
-  "version": 15
+  "version": 1
 }
\ No newline at end of file
diff --git a/deployment/docker/provisioning/dashboards/victoriametrics.json b/deployment/docker/provisioning/dashboards/victoriametrics.json
index a37d5bba85..21923a9143 100644
--- a/deployment/docker/provisioning/dashboards/victoriametrics.json
+++ b/deployment/docker/provisioning/dashboards/victoriametrics.json
@@ -16,8 +16,8 @@
   "editable": true,
   "gnetId": 10229,
   "graphTooltip": 0,
-  "id": 1,
-  "iteration": 1559629886268,
+  "id": 2,
+  "iteration": 1559859052453,
   "links": [
     {
       "icon": "doc",
@@ -63,7 +63,7 @@
       "content": "<div style=\"text-align: center; font-size: 2em\">$version</div>",
       "description": "",
       "gridPos": {
-        "h": 2,
+        "h": 3,
         "w": 8,
         "x": 0,
         "y": 1
@@ -90,7 +90,7 @@
       "description": "Run VM with `-help` flag to see all the available flags with description and default values",
       "fontSize": "100%",
       "gridPos": {
-        "h": 8,
+        "h": 9,
         "w": 16,
         "x": 8,
         "y": 1
@@ -191,7 +191,7 @@
         "h": 2,
         "w": 8,
         "x": 0,
-        "y": 3
+        "y": 4
       },
       "id": 26,
       "interval": null,
@@ -276,7 +276,7 @@
         "h": 2,
         "w": 8,
         "x": 0,
-        "y": 5
+        "y": 6
       },
       "id": 38,
       "interval": null,
@@ -360,7 +360,7 @@
         "h": 2,
         "w": 8,
         "x": 0,
-        "y": 7
+        "y": 8
       },
       "id": 8,
       "interval": null,
@@ -427,7 +427,7 @@
         "h": 1,
         "w": 24,
         "x": 0,
-        "y": 9
+        "y": 10
       },
       "id": 24,
       "panels": [],
@@ -446,7 +446,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 10
+        "y": 11
       },
       "id": 12,
       "legend": {
@@ -536,7 +536,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 10
+        "y": 11
       },
       "id": 22,
       "legend": {
@@ -626,7 +626,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 18
+        "y": 19
       },
       "id": 35,
       "legend": {
@@ -716,7 +716,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 18
+        "y": 19
       },
       "id": 33,
       "legend": {
@@ -817,7 +817,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 26
+        "y": 27
       },
       "id": 37,
       "legend": {
@@ -906,7 +906,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 26
+        "y": 27
       },
       "id": 49,
       "legend": {
@@ -989,7 +989,7 @@
         "h": 1,
         "w": 24,
         "x": 0,
-        "y": 34
+        "y": 35
       },
       "id": 14,
       "panels": [],
@@ -1008,7 +1008,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 35
+        "y": 36
       },
       "id": 10,
       "legend": {
@@ -1104,7 +1104,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 35
+        "y": 36
       },
       "id": 34,
       "legend": {
@@ -1127,7 +1127,7 @@
       "renderer": "flot",
       "seriesOverrides": [
         {
-          "alias": "merges",
+          "alias": "pending index entries",
           "yaxis": 2
         }
       ],
@@ -1136,12 +1136,20 @@
       "steppedLine": false,
       "targets": [
         {
-          "expr": "sum(vm_pending_rows{job=\"$job\"})",
+          "expr": "vm_pending_rows{job=\"$job\", type=\"storage\"}",
           "format": "time_series",
           "hide": false,
           "intervalFactor": 1,
-          "legendFormat": "rows",
+          "legendFormat": "pending datapoints",
           "refId": "A"
+        },
+        {
+          "expr": "vm_pending_rows{job=\"$job\", type=\"indexdb\"}",
+          "format": "time_series",
+          "hide": false,
+          "intervalFactor": 1,
+          "legendFormat": "pending index entries",
+          "refId": "B"
         }
       ],
       "thresholds": [],
@@ -1198,7 +1206,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 43
+        "y": 44
       },
       "id": 30,
       "legend": {
@@ -1285,7 +1293,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 43
+        "y": 44
       },
       "id": 36,
       "legend": {
@@ -1366,7 +1374,7 @@
         "h": 1,
         "w": 24,
         "x": 0,
-        "y": 51
+        "y": 52
       },
       "id": 46,
       "panels": [],
@@ -1385,7 +1393,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 52
+        "y": 53
       },
       "id": 44,
       "legend": {
@@ -1488,7 +1496,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 52
+        "y": 53
       },
       "id": 42,
       "legend": {
@@ -1574,7 +1582,7 @@
         "h": 8,
         "w": 12,
         "x": 0,
-        "y": 60
+        "y": 61
       },
       "id": 47,
       "legend": {
@@ -1661,7 +1669,7 @@
         "h": 8,
         "w": 12,
         "x": 12,
-        "y": 60
+        "y": 61
       },
       "id": 48,
       "legend": {
@@ -1772,8 +1780,8 @@
       {
         "allValue": null,
         "current": {
-          "text": "v1.18.0",
-          "value": "v1.18.0"
+          "text": "v1.18.9",
+          "value": "v1.18.9"
         },
         "datasource": "Prometheus",
         "definition": "label_values(vm_app_version{job=\"$job\"},  version)",