From fdf0a936f0f296db8d2a6a4d1801349ec3f0c336 Mon Sep 17 00:00:00 2001 From: hagen1778 Date: Mon, 10 Jun 2024 14:02:46 +0200 Subject: [PATCH] vmctl: rm `--vm-disable-progress-bar` flag It is better to remove deprecated flag completely, so vmctl will fail if this flag is used and user can immediately fix the issue. Before, flag was ignored and it is worse then fail fast. follow-up after https://github.com/VictoriaMetrics/VictoriaMetrics/commit/8b46bb0c4172d9d2f9fbd20a437324b263fe9ded#diff-2bfab3db5cc1baf4c6d3ff6b19901926e3bdf4411ec685dac973e5fcff1c723b Signed-off-by: hagen1778 (cherry picked from commit 8d955225292f89ee2334ac7ab82c22d9c5e4a898) --- app/vmctl/flags.go | 5 ----- docs/CHANGELOG.md | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/app/vmctl/flags.go b/app/vmctl/flags.go index a9987fcb16..e5ae52e542 100644 --- a/app/vmctl/flags.go +++ b/app/vmctl/flags.go @@ -45,7 +45,6 @@ const ( vmBatchSize = "vm-batch-size" vmSignificantFigures = "vm-significant-figures" vmRoundDigits = "vm-round-digits" - vmDisableProgressBar = "vm-disable-progress-bar" vmCertFile = "vm-cert-file" vmKeyFile = "vm-key-file" vmCAFile = "vm-CA-file" @@ -126,10 +125,6 @@ var ( Usage: "Optional data transfer rate limit in bytes per second.\n" + "By default, the rate limit is disabled. It can be useful for limiting load on configured via '--vmAddr' destination.", }, - &cli.BoolFlag{ - Name: vmDisableProgressBar, - Usage: "Whether to disable progress bar per each worker during the import. This flag is deprecated. Use global flag instead.", - }, &cli.StringFlag{ Name: vmCertFile, Usage: "Optional path to client-side TLS certificate file to use when connecting to '--vmAddr'", diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 3d3765656e..0f617fc915 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -30,7 +30,7 @@ See also [LTS releases](https://docs.victoriametrics.com/lts-releases/). ## tip -**Update note 1: the `--vm-disable-progress-bar` command-line flag at `vmctl` is deprecated and will be removed in the future releases. Use `--disable-progress-bar` instead.** +**Update note 1: the `--vm-disable-progress-bar` command-line flag at `vmctl` was deprecated. Use `--disable-progress-bar` instead.** * FEATURE: [alerts-vmagent](https://github.com/VictoriaMetrics/VictoriaMetrics/blob/master/deployment/docker/alerts-vmagent.yml): add new alerting rules `StreamAggrFlushTimeout` and `StreamAggrDedupFlushTimeout` to notify about issues during stream aggregation. * FEATURE: [dashboards/vmagent](https://grafana.com/grafana/dashboards/12683): add row `Streaming aggregation` with panels related to [streaming aggregation](https://docs.victoriametrics.com/stream-aggregation/) process.