From ffe355058ae33723d93718b7808172dfd89a5039 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Thu, 7 Sep 2023 11:16:19 +0200 Subject: [PATCH] deployment/docker: properly build armv5 production builds for GOARCH=arm Pass GOARM=5 when building GOARCH=arm production builds, since the default value for this env var has been changed to GOARM=6 since Go1.21.0. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4965 and https://github.com/golang/go/issues/62475 --- deployment/docker/Makefile | 4 +++- docs/CHANGELOG.md | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/deployment/docker/Makefile b/deployment/docker/Makefile index 8b2511ca0c..d98eb458de 100644 --- a/deployment/docker/Makefile +++ b/deployment/docker/Makefile @@ -103,7 +103,9 @@ app-via-docker-linux-amd64: CGO_ENABLED=1 GOOS=linux GOARCH=amd64 $(MAKE) app-via-docker-goos-goarch app-via-docker-linux-arm: - CGO_ENABLED=0 GOOS=linux GOARCH=arm $(MAKE) app-via-docker-goos-goarch + APP_SUFFIX='-linux-arm' \ + DOCKER_OPTS='--env CGO_ENABLED=0 --env GOOS=linux --env GOARCH=arm --env GOARM=5' \ + $(MAKE) app-via-docker app-via-docker-linux-arm64: APP_SUFFIX='-linux-arm64' \ diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 928976d71b..c7a30b72f8 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -25,6 +25,7 @@ The following `tip` changes can be tested by building VictoriaMetrics components ## v1.93.x long-time support release (LTS) * BUGFIX: [vminsert](https://docs.victoriametrics.com/Cluster-VictoriaMetrics.html): properly parse `/insert/multitenant/*` urls, which have been broken since [v1.93.2](#v1932). See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4947). +* BUGFIX: properly build armv5 binaries for `GOARCH=arm`. This has been broken after the upgrading of Go builder to Go1.21.0. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4965). ## [v1.93.3](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.93.3)