github-mirrors/VictoriaMetrics

mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00

Author	SHA1	Message	Date
Aliaksandr Valialkin	a9fd130980	app/vmselect/graphite: properly handle -N index for the array of N items This is a follow-up for `70cd09e736` Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5581	2024-01-16 21:05:01 +02:00
Aliaksandr Valialkin	4e4d7f4cbe	app/vmctl: disallow insecure https connections to vm-native-dst-addr and vm-native-src-addr by default It is better from security PoV to disallow insecure https connections to vm-native-dst-addr and vm-native-src-addr . This also maintains backwards compatibility with vmctl before the commit `828aca82e9` Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5595 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5606	2024-01-16 20:20:33 +02:00
Yury Molodov	d365157381	vmui/vmanomaly: add support models that produce only `anomaly_score` (#5594 ) * vmui/vmanomaly: add support models that produce only `anomaly_score` * vmui/vmanomaly: fix display legend * vmui/vmanomaly: update comment on anomaly threshold	2024-01-16 18:50:19 +02:00
Aliaksandr Valialkin	a74f6d63e0	deployment/docker: update Go builder from Go1.21.5 to Go1.21.6	2024-01-16 17:00:16 +02:00
Aliaksandr Valialkin	b49b8fed3c	app/vmselect/promql: simplify the code after `388d020b7c` Add a test, which verifies the correct sorting of float64 slices with NaNs. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5506 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5509	2024-01-16 15:06:33 +02:00
Aliaksandr Valialkin	388d020b7c	app/vmselect/promql: follow-up for `ce4f26db02` - Document the bugfix at docs/CHANGELOG.md - Filter out NaN values before sorting as suggested at https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5509#discussion_r1447369218 - Revert unrelated changes in lib/filestream and lib/fs - Use simpler test at app/vmselect/promql/exec_test.go Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5509 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5506	2024-01-16 02:55:08 +02:00
Zongyang	ce4f26db02	FIX bottomk doesn't return any data when there are no time range overlap between timeseries (#5509 ) * FIX sort order in bottomk * Add lessWithNaNsReversed for bottomk * Add ut for TopK * Move lt from loop * FIX lint * FIX lint * FIX lint * Mod log format --------- Co-authored-by: xiaozongyang <xiaozngyang@kanyun.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2024-01-16 02:19:36 +02:00
Aliaksandr Valialkin	190a6565ae	app/vmselect/promql: consistently sort results of `a or b` query Previously the order of results returned from `a or b` query could change with each request because the sorting for such query has been disabled in order to satisfy https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4763 . This commit executes `a or b` query as `sortByMetricName(a) or sortByMetricName(b)`. This makes the order of returned time series consistent across requests, while maintaining the requirement from https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4763 , e.g. `b` results are consistently put after `a` results. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5393	2024-01-16 01:30:10 +02:00
Aliaksandr Valialkin	7fc2bd0412	app/vmstorage: expose proper types for storage metrics when -metrics.exposeMetadata command-line flag is set This is a follow-up for `326a77c697`	2024-01-16 00:20:37 +02:00
Aliaksandr Valialkin	5106045048	app/vmstorage: deregister storage metrics before stopping the storage This prevents from possible nil pointer dereference issues when the storage metrics are read after the storage is stopped. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5548	2024-01-15 16:11:45 +02:00
Aliaksandr Valialkin	be509b3995	lib/pushmetrics: wait until the background goroutines, which push metrics, are stopped at pushmetrics.Stop() Previously the was a race condition when the background goroutine still could try collecting metrics from already stopped resources after returning from pushmetrics.Stop(). Now the pushmetrics.Stop() waits until the background goroutine is stopped before returning. This is a follow-up for https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5549 and the commit `fe2d9f6646` . Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5548	2024-01-15 13:50:36 +02:00
rbizos	70cd09e736	Handling negative index in Graphite groupByNode/aliasByNode (#5581 ) Handeling the error case with -1 Signed-off-by: Raphael Bizos <r.bizos@criteo.com> Co-authored-by: Nikolay <nik@victoriametrics.com>	2024-01-15 09:57:15 +01:00
Aliaksandr Valialkin	d2c94a0663	lib/prompbmarshal: switch to github.com/VictoriaMetrics/easyproto	2024-01-14 23:04:45 +02:00
Aliaksandr Valialkin	a47127c1a6	app/vmalert/remotewrite: properly calculate vmalert_remotewrite_dropped_rows_total It was calculating the number of dropped time series instead of the number of dropped samples. While at it, drop vmalert_remotewrite_dropped_bytes_total metric, since it was inconsistently calculated - at one place it was calculating raw protobuf-encoded sample sizes, while at another place it was calculating the size of snappy-compressed prompbmarshal.WriteRequest protobuf message. Additionally, this metric has zero practical sense, so just drop it in order to reduce the level of confusion.	2024-01-14 22:55:11 +02:00
Aliaksandr Valialkin	c005245741	lib/prompb: switch to github.com/VictoriaMetrics/easyproto	2024-01-14 22:46:06 +02:00
Aliaksandr Valialkin	f2229c2e42	lib/prompb: change type of Label.Name and Label.Value from []byte to string This makes it more consistent with lib/prompbmarshal.Label	2024-01-14 22:33:21 +02:00
Dmytro Kozlov	828aca82e9	app/vmctl: add insecure skip verify flags for source and destination addresses for native protocol (#5606 ) https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5595	2024-01-11 14:04:32 +01:00
hagen1778	91ccea236f	app/all: follow-up after `84d710beab` https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5548 Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-09 13:34:54 +01:00
Dmytro Kozlov	105c6b2eb7	app/vmui: fix broken link for the statistic inaccuracy explanation (#5568 )	2024-01-08 20:13:45 +01:00
Hui Wang	1f477aba41	vmalert: automatically add `exported_` prefix for original evaluation… (#5398 ) automatically add `exported_` prefix for original evaluation result label if it's conflicted with external or reserved one, previously it was overridden. https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5161 Signed-off-by: hagen1778 <roman@victoriametrics.com> Co-authored-by: hagen1778 <roman@victoriametrics.com>	2023-12-22 16:07:47 +01:00
Aliaksandr Valialkin	7575f5c501	lib/protoparser/datadogv2: take into account source_type_name field, since it contains useful value such as kubernetes, docker, system, etc.	2023-12-21 23:05:41 +02:00
Aliaksandr Valialkin	fb90a56de2	app/{vminsert,vmagent}: preliminary support for /api/v2/series ingestion from new versions of DataDog Agent This commit adds only JSON support - https://docs.datadoghq.com/api/latest/metrics/#submit-metrics , while recent versions of DataDog Agent send data to /api/v2/series in undocumented Protobuf format. The support for this format will be added later. Thanks to @AndrewChubatiuk for the initial implementation at https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5094 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4451	2023-12-21 20:50:55 +02:00
Roman Khavronenko	8c1dcf4743	app/vmselect: drop `rollupDefault` function as duplicate (#5502 ) * app/vmselect: drop `rollupDefault` function as duplicate It is unclear why there are two identical fns `rollupDefault` and `rollupDistinct`. Dropping one of them. Signed-off-by: hagen1778 <roman@victoriametrics.com> * Update app/vmselect/promql/rollup.go * Update app/vmselect/promql/rollup.go --------- Signed-off-by: hagen1778 <roman@victoriametrics.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2023-12-21 11:22:19 +02:00
Aliaksandr Valialkin	160cc9debd	app/{vmagent,vmalert}: add the ability to set OAuth2 endpoint params via the corresponding *.oauth2.endpointParams command-line flags This is a follow-up for `5ebd5a0d7b` Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5427	2023-12-20 21:35:28 +02:00
Morgan	5ebd5a0d7b	Expose OAuth2 Endpoint Parameters to cli (#5427 ) The user may which to control the endpoint parameters for instance to set the audience when requesting an access token. Exposing the parameters as a map allows for additional use cases without requiring modification.	2023-12-20 20:16:43 +02:00
Aliaksandr Valialkin	5a88bc973f	all: use Gauge instead of Counter for `*_config_last_reload_successful` metrics This allows exposing the correct TYPE metadata for these labels when the app runs with -metrics.exposeMetadata command-line flag. See https://github.com/VictoriaMetrics/metrics/pull/61#issuecomment-1860085508 for more details. This is follow-up for `326a77c697`	2023-12-20 14:23:42 +02:00
Yury Molodov	a35e52114b	vmui: add vmanomaly explorer (#5401 )	2023-12-19 17:20:54 +01:00
Roman Khavronenko	779bbc2e91	vmctl: rename `vm-native-disable-retries` to `vm-native-disable-per-metric-migration` (#5476 ) The change supposed to better reflect the meaning of this flag. Signed-off-by: hagen1778 <roman@victoriametrics.com>	2023-12-15 12:36:28 +01:00
Roman Khavronenko	664fa5cb78	vmctl: retry requests that failed in the very end for `vm-native` (#5475 ) Before, retries happened only on writes into a network connection between source and destination. But errors returned by server after all the data was transmitted were logged, but not retried. Signed-off-by: hagen1778 <roman@victoriametrics.com>	2023-12-15 11:43:41 +01:00
Hui Wang	9253c24dd6	vmalert: validate schema for `-external.url` (#5450 ) Requests with wrong or no schema in `-external.url` could be rejected by alertmanager. So we validate schema on start up.	2023-12-15 11:13:56 +01:00
Dima Lazerka	cd277e3f84	VMUI: Handle unknown query error response type (#5451 ) * VMUI: Handle unknown query error response type * vmui: add error text for unknown error type * Simplify nested `if`s for unknown error Accepting @Loori-R's suggestion Co-authored-by: Yury Molodov <yurymolodov@gmail.com> --------- Co-authored-by: Yury Moladau <yurymolodov@gmail.com>	2023-12-14 21:19:54 -08:00
Anton Tykhyy	66c76a4d4d	Fix sum(aggr_over_time) 'got 1 args' error (#3028 ) (#5414 ) app/vmselect/promql/eval.go:evalAggrFunc shunts evaluation of AggrFuncExpr over rollupFunc over MetricsExpr to an optimized path. tryGetArgRollupFuncWithMetricExpr() checks whether expression can be shunted, but it mangles the AggrFuncExpr when the aggregation function has more than one argument. This results in queries like `sum(aggr_over_time("avg_over_time",m))` failing with error message 'expecting at least 2 args to "aggr_over_time"; got 1 args' while the analogous query `sum(avg_over_time(m))` executes successfully. This fix removes the unnecessary mangling. Signed-off-by: Anton Tykhyy <atykhyy@gmail.com>	2023-12-14 12:38:54 +02:00
Aliaksandr Valialkin	2afb068f0f	app/vmauth: allow specifying an empty retry_status_codes and and zero drop_src_path_prefix_parts in order to override user-level setting Previously `retry_status_codes: []` and `drop_src_path_prefix_parts: 0` at `url_map` were equivalent to missing values. This was resulting in using the user-level values instead.	2023-12-14 01:04:56 +02:00
Aliaksandr Valialkin	68be182075	app/vmauth: add ability to route requests to different backends depending on the request host	2023-12-14 00:46:36 +02:00
Yury Molodov	1a5cdb4790	vmui: autocomplete usability improvements (#5422 ) * vmui: add show quick tip for autocomplete * vmui: auto-completion usability improvements #5348 * vmui: add const for min symbols in autocomplete * Use proper queries to VictoriaMetrics * vmui: fix comments for autocomplete * app/vmselect: run `make vmui-update` --------- Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2023-12-13 00:32:41 +02:00
hagen1778	242472086b	app/vmctl: follow-up after `6af732b6f7` Make docs more clear about new feature. Signed-off-by: hagen1778 <roman@victoriametrics.com>	2023-12-12 13:44:21 +01:00
Dmytro Kozlov	6af732b6f7	app/vmctl: enable range steps in reverse order (#5444 ) See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5376	2023-12-12 13:05:44 +01:00
hagen1778	39c405ed4d	app/vmctl: follow-up after `27668c9d01` * remove duplications in error messages * mention the change in CHANGELOG.md `27668c9d01` Signed-off-by: hagen1778 <roman@victoriametrics.com>	2023-12-11 15:30:47 +01:00
wozz	27668c9d01	vmctl: check error in response from influxdb (#5446 )	2023-12-11 15:24:08 +01:00
Aliaksandr Valialkin	6d03779870	deployment/docker: update base Docker image from alpine:3.18.5 to alpine:3.19.0 See https://www.alpinelinux.org/posts/Alpine-3.19.0-released.html	2023-12-10 02:28:19 +02:00
Aliaksandr Valialkin	3d3b0e31e0	app/vmselect: add -search.maxResponseSeries command-line flag for limiting the number of time series a single response can return This limit can be used for preventing from high memory usage at Grafana when the response returns too many series. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5372	2023-12-10 00:54:42 +02:00
Aliaksandr Valialkin	b1fed78e0b	app: make more clear that -tls enables https at -httpListenAddr	2023-12-10 00:25:01 +02:00
Aliaksandr Valialkin	042267541f	app/vmauth: add support for `hot standby` mode via `first_available` load balancing policy vmauth in `hot standby` mode sends requests to the first url_prefix while it is available. If the first url_prefix becomes unavailable, then vmauth falls back to the next url_prefix. This allows building highly available setup as described at https://docs.victoriametrics.com/vmauth.html#high-availability Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4893 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4792	2023-12-08 23:31:07 +02:00
Roman Khavronenko	74b09ab4de	app/vmalert: sanitize label names before sending to Alertmanager (#5442 ) Before, vmalert would send notifications with labels containing characters not supported by Alertmanager validator, resulting into validation errors like `msg="Failed to validate alerts" err="invalid label set: invalid name "foo.bar"` Signed-off-by: hagen1778 <roman@victoriametrics.com>	2023-12-08 16:53:35 +03:00
Alexander Marshalov	02a0a7f428	added field `version` to the response for `/api/v1/status/buildinfo` API for using more efficient API in Grafana for receiving label values, added additional info about setup Grafana datasource (#5370 ) (#5437 )	2023-12-07 16:37:36 +02:00
Aliaksandr Valialkin	802adf3b65	app/vmselect/prometheus: go fmt after `b39e9257eb`	2023-12-07 16:01:18 +02:00
Aliaksandr Valialkin	b39e9257eb	app/vmselect/prometheus: properly encode Prometheus label values at /federate endpoint Prometheus spec says that only \, \n and " must be escaped inside label values. See `995743836e/content/docs/instrumenting/exposition_formats.md (L90)` See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5431	2023-12-07 15:36:01 +02:00
Aliaksandr Valialkin	efbe25a678	deployment/docker: update Go builder from Go1.21.4 to Go1.21.5 See https://github.com/golang/go/issues?q=milestone%3AGo1.21.5+label%3ACherryPickApproved	2023-12-06 22:33:40 +02:00
Dmytro Kozlov	935bec447b	app/vmalert: replace error metrics for gauges with counter metrics (#5217 ) See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5160 Signed-off-by: hagen1778 <roman@victoriametrics.com> Co-authored-by: hagen1778 <roman@victoriametrics.com>	2023-12-06 19:39:35 +01:00
Aliaksandr Valialkin	e4f5039509	app/vmselect: properly adjust the lower bound for the time range where raw samples must be selected for default_rollup() function Previously the lower bound could be too small, which could result in missing values at the beginning of the graph for default_rollup() function. This function is automatically applied to all the series selectors if they aren't explicitly wrapped into a rollup function - see https://docs.victoriametrics.com/MetricsQL.html#implicit-query-conversions While at it, properly take into account `-search.minStalenessInterval` command-line flag when adjusting the lower bound for the selected time range. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5388	2023-12-06 14:20:14 +02:00

1 2 3 4 5 ...

2862 commits