Aliaksandr Valialkin
|
fc42900eca
|
lib/pushmetrics: wait until the background goroutines, which push metrics, are stopped at pushmetrics.Stop()
Previously the was a race condition when the background goroutine still could try collecting metrics
from already stopped resources after returning from pushmetrics.Stop().
Now the pushmetrics.Stop() waits until the background goroutine is stopped before returning.
This is a follow-up for https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5549
and the commit fe2d9f6646 .
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5548
|
2024-01-16 23:18:29 +02:00 |
|
hagen1778
|
07fe834f54
|
app/all: follow-up after 84d710beab
https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5548
Signed-off-by: hagen1778 <roman@victoriametrics.com>
|
2024-01-16 23:08:21 +02:00 |
|
zhdd99
|
66bafee651
|
lib/pushmetrics: fix a panic caused by pushing metrics during the graceful shutdown process of vmstorage nodes. (#5549)
Co-authored-by: zhangdongdong <zhangdongdong@kuaishou.com>
Co-authored-by: Roman Khavronenko <roman@victoriametrics.com>
Signed-off-by: hagen1778 <roman@victoriametrics.com>
|
2024-01-16 23:06:51 +02:00 |
|
Alexander Marshalov
|
2e494e2375
|
fixed typos in documentation and commandline flags descriptions (#4275)
|
2023-05-10 09:50:41 +02:00 |
|
Aliaksandr Valialkin
|
c1fa9828b3
|
lib/flagutil: rename Array to ArrayString
This makes the ArrayString more consistent with other Array* types.
While at it, add ArrayBytes type, which will be used for https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3071
|
2022-10-01 18:26:36 +03:00 |
|
Aliaksandr Valialkin
|
f5676123cc
|
lib/pushmetrics: make fmt
|
2022-07-26 20:40:19 +03:00 |
|
Aliaksandr Valialkin
|
da11056d85
|
all: rename -pushmetrics.extraLabels to -pushmetrics.extraLabel for the sake of consistency
|
2022-07-26 19:24:24 +03:00 |
|
Aliaksandr Valialkin
|
ad6b3cd47d
|
lib/pushmetrics: properly handle errors when initializing pushmetrics
|
2022-07-22 13:36:06 +03:00 |
|
Roman Khavronenko
|
2914ce5ca5
|
vmalert: remove dependency on datasource pkg from config (#2905)
* vmalert: remove dependency on datasource pkg from config
Signed-off-by: hagen1778 <roman@victoriametrics.com>
|
2022-07-22 10:44:55 +02:00 |
|
Aliaksandr Valialkin
|
4ce5875fa8
|
all: add ability to push internal metrics to remote storage system specified via -pushmetrics.url
|
2022-07-21 20:36:27 +03:00 |
|