139 commits

Author	SHA1	Message	Date
Aliaksandr Valialkin	54fe207cc0	all: follow-up for 7a3e16e774 ... - Sync the description for -httpListenAddr.useProxyProtocol command-line flag at vmagent and vmauth, so it is consistent with the description at vmauth and victoria-metrics - Add a sample of panic text to docs/CHANGELOG.md, so it could be googled - Mention the -httpListenAddr.useProxyProtocol command-line flag in the description for the bugfix Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3335	2023-03-08 01:42:58 -08:00
Aliaksandr Valialkin	6369c88a68	app/vmselect: add -search.logQueryMemoryUsage command-line flag for logging queries, which take big amounts of memory ... Thanks to @michal-kralik for initial attempts for this feature: - https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3651 - https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3715 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3553	2023-02-23 18:52:44 -08:00
Aliaksandr Valialkin	0c60e4a30a	all: consistently use http.Method{Get,Post,Put} across the codebase ... This is a follow-up after 9dec3c8f80	2023-02-22 19:01:09 -08:00
Nikolay	ebebaecd94	lib/netutil: init implimentation of proxy protocol (#3687) ... * lib/netutil: init implimentation of proxy protocol https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3335 * wip Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2023-01-26 23:25:22 -08:00
Aliaksandr Valialkin	820357f434	app/vmselect: follow-up after 820312a2b1 ... - Move the feature description at the correct place at docs/CHANGELOG.md - Run `make vmui-update` - Various cosmetic fixes Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3322	2023-01-11 23:37:51 -08:00
Dmytro Kozlov	f2862f088b	app/vmui: define custom path for dashboards json file (#3545) ... * app/vmui: define custom path for dashboards json file * app/vmui: remove unneeded code * app/vmui: move handler to own file, fix show dashboards, * app/vmui: move flag to handler, add flag description * app/vmauth: fix part of the comments * feat: add store for dashboards * fix: prevent fetch dashboards for app mode * app/vmauth: use simple cache for predefined dashboards * app/vmauth: update dashboards doc * app/vmauth: fix ci * app/vmui: decrease timeout * app/vmselect: removed cache, fix comments * app/vmselect: remove unused const * app/vmselect: fix error log, use slice byte instead of struct Co-authored-by: Yury Moladau <yurymolodov@gmail.com>	2023-01-11 23:33:30 -08:00
Aliaksandr Valialkin	f7130d571d	app/vmselect: improve logging when the incoming query cannot be executed because of timeout in the wait queue	2023-01-11 01:12:25 -08:00
Aliaksandr Valialkin	aa027529eb	lib/httpserver: directly pass flag value to CheckAuthFlag() ... There is no sense in passing a pointer to flag value there. This is a follow-up for 4225a0bd75	2023-01-10 15:59:55 -08:00
Zakhar Bessarab	10f314cdbd	Use httpAuth.* flags as a fallback for endpoints protected by *AuthKey flags (#3582) ... * {lib/server, app/}: use `httpAuth.*` flag as fallback for `*AuthKey` if it is not set * lib/ingestserver/opentsdbhttp: fix opentdb HTTP handler not respecting `httpAuth.*` flags * Apply suggestions from code review Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2023-01-10 15:57:55 -08:00
Aliaksandr Valialkin	5876821a16	all: small improvements in error messages and command-line flag descriptions related to concurrency limiters	2023-01-07 00:12:24 -08:00
Aliaksandr Valialkin	b275983403	lib/writeconcurrencylimiter: improve the logic behind -maxConcurrentInserts limit ... Previously the -maxConcurrentInserts was limiting the number of established client connections, which write data to VictoriaMetrics. Some of these connections could be idle. Such connections do not consume big amounts of CPU and RAM, so there is a little sense in limiting the number of such connections. So now the -maxConcurrentInserts command-line option limits the number of concurrently executed insert requests, not including idle connections. It is recommended removing -maxConcurrentInserts command-line option, since the default value for this option should work good for most cases.	2023-01-06 22:07:16 -08:00
Aliaksandr Valialkin	cd705b0f69	app/vmselect: improve error message when the request cannot be started because too many concurrent requests are already executed	2023-01-06 18:19:05 -08:00
Aliaksandr Valialkin	1d16cc9349	lib/promscrape: pre-fetch metric_relabel_configs rules when debugging metric relabeling for a particular target ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3407	2023-01-05 03:28:14 -08:00
Aliaksandr Valialkin	ac890b3081	docs: update -help outputs for vm* tools	2023-01-03 23:27:31 -08:00
Aliaksandr Valialkin	f8e008f5ad	app/vmselect: show the link to /expand-with-exprs at /select/0/ page	2022-12-14 16:23:19 -08:00
Aliaksandr Valialkin	6d13ca2b88	app/vmselect: add /select/0/prometheus/expand-with-exprs page	2022-12-14 16:23:17 -08:00
Aliaksandr Valialkin	a521135b7b	lib/promscrape: allow editing relabeling configs and labels at /target-relabel-debug page ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3407	2022-12-10 12:47:47 -08:00
Aliaksandr Valialkin	72ea387c86	app/vmselect: properly serve static css for /select/.../metric-relabel-debug page	2022-12-10 03:04:43 -08:00
Aliaksandr Valialkin	97b41e727c	lib/promscrape: implement target-level and metric-level relabel debugging ... Target-level debugging is performed by clicking the 'debug' link at the corresponding target on either http://vmagent:8429/targets page or on http://vmagent:8428/service-discovery page. Metric-level debugging is perfromed at http://vmagent:8429/metric-relabel-debug page. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3407 See https://docs.victoriametrics.com/vmagent.html#relabel-debug	2022-12-10 02:25:56 -08:00
Aliaksandr Valialkin	a257c5fe53	app/vmselect: typo fixes in code comments	2022-12-06 20:59:17 -08:00
Zakhar Bessarab	e407e7243a	{app/vmstorage,app/vmselect}: add API to get list of existing tenants (#3348) ... * {app/vmstorage,app/vmselect}: add API to get list of existing tenants * {app/vmstorage,app/vmselect}: add API to get list of existing tenants * app/vmselect: fix error message * {app/vmstorage,app/vmselect}: fix error messages * app/vmselect: change log level for error handling * wip Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-11-25 10:32:45 -08:00
Zakhar Bessarab	fd36c9b3b1	docs/{vminsert,vmselect}: clarify flag description for clusternativeListenAddr (#3314) ... docs/{vminsert,vmselect}: clarify flag description for `clusternativeListenAddr`	2022-11-04 09:49:53 +01:00
Zakhar Bessarab	7afa67dba0	{app/vmselect,app/vminsert}: ensure -storageNodes flag has no empty values (#3291)	2022-11-01 14:54:55 +02:00
Aliaksandr Valialkin	09cf136154	app/{vminsert,vmselect}: add support for automatic discovery and update of vmstorage nodes ... Thanks to @dmitryk-dk for the initial implemenation at https://github.com/VictoriaMetrics/VictoriaMetrics-enterprise/pull/446	2022-10-28 13:13:03 +03:00
Aliaksandr Valialkin	4f53147ed4	app/{vminsert,vmselect}/netstorage: allow calling Init()+MustStop() in a loop ... Previously netstorage.MustStop() call didn't free up all the resources, so the subsequent call to nestorage.Init() would panic. This allows writing tests, which call nestorage.Init() + nestorage.MustStop() in a loop.	2022-10-25 14:43:05 +03:00
Aliaksandr Valialkin	098c9bda27	app/vmselect: return back the logic for limits the amounts of memory occupied by concurrently executed queries if -search.maxMemoryPerQuery isn't set ... This is needed for preserving backwards compatibility with the previous releases of VictoriaMetrics. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3203	2022-10-10 21:54:18 +03:00
Aliaksandr Valialkin	d8057fca0b	docs: mention -search.maxMemoryPerQuery in the description to -search.maxConcurrentQueries command-line flag ... This is a follow-up for 5138eaeea0 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3203	2022-10-09 13:58:18 +03:00
Aliaksandr Valialkin	938ff7bba6	app/vmselect: allow limiting per-query memory usage via -search.maxMemoryPerQuery command-line flag ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3203	2022-10-08 01:14:01 +03:00
Aliaksandr Valialkin	6f9ce3f6d6	lib/flagutil: rename Array to ArrayString ... This makes the ArrayString more consistent with other Array* types. While at it, add ArrayBytes type, which will be used for https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3071	2022-10-01 18:28:19 +03:00
Aliaksandr Valialkin	93e84a1c57	lib/httpserver: use 302 redirects instead of 301 redirects ... Incorrect 301 redirects can be cached by user agents such as web browsers. This can complicate recovery procedure after the incorrect redirect is fixed, e.g. web browser cache must be reset. The related issue - https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1752	2022-10-01 16:56:43 +03:00
Dmytro Kozlov	ec273eafef	app/{vmselect, vminsert}: fails with error when user defines equal addresses in the -storageNodes flag (#3082)	2022-09-08 21:17:58 +03:00
Aliaksandr Valialkin	7d7cf2b6fd	app/vmselect: follow-up after 63e0f16062 ... * Explicitly store a pointer to UserReadableError in the error interface. Previously Go automatically converted the value to a pointer before storing in the error interface. * Add Unwrap() method to UserReadableError, so it can be used transparently with the other code, which calls errors.Is() and errors.As(). * Document the change in docs/CHANGELOG.md	2022-08-15 13:53:19 +03:00
Roman Khavronenko	8a26ec435d	vmselect: introduce UserReadableError type of error (#2894) ... When read query fails, VM returns rich error message with all the details. While these details might be useful for debugging specific cases, they're usually too verbose for users. Introducing a new error type `UserReadableError` is supposed to allow to return to user only the most important parts of the error trace. This supposed to improve error readability in web interfaces such as VMUI or Grafana. The full error trace is still logged with the full context and can be found in vmselect logs. Signed-off-by: hagen1778 <roman@victoriametrics.com> Signed-off-by: hagen1778 <roman@victoriametrics.com>	2022-08-15 13:53:18 +03:00
Aliaksandr Valialkin	a1e49606ed	app/{vmselect,vmalert}: properly generate http redirects if -http.pathPrefix command-line flag is set ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2918	2022-08-02 13:01:13 +03:00
Aliaksandr Valialkin	764fc04756	app/vmalert: fix after da10962d4c	2022-07-25 09:48:41 +03:00
Roman Khavronenko	da10962d4c	vmselect: cover special cases for vmalert's routing in single-node version (#2845) ... * vmselect: cover special cases for vmalert's routing in single-node version * remove trailing `/` from requests * redirect to vmalert's home page when `/vmalert` is requested. Signed-off-by: hagen1778 <roman@victoriametrics.com> * vmalert: fix review comments Signed-off-by: hagen1778 <roman@victoriametrics.com> * Update app/vmselect/main.go Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-07-25 09:43:44 +03:00
Aliaksandr Valialkin	c0c9f30870	lib/pushmetrics: properly handle errors when initializing pushmetrics	2022-07-22 13:38:25 +03:00
Aliaksandr Valialkin	fe68bb3ba7	all: follow-up after 46f803fa7a ... Add -pushmetrics.* command-line flags to all the VictoriaMetrics apps	2022-07-21 20:18:25 +03:00
Aliaksandr Valialkin	ed2126aec3	app/vmselect: follow-up after 6dda254e01	2022-07-11 19:48:18 +03:00
Roman Khavronenko	6dda254e01	vmselect: cover special cases for vmalert's routing in cluster version (#2844) ... * vmselect: cover special cases for vmalert's routing * remove trailing `/` from requests * redirect to vmalert's home page when `/vmalert` is requested. Signed-off-by: hagen1778 <roman@victoriametrics.com> * vmselect: fix review comments Signed-off-by: hagen1778 <roman@victoriametrics.com> * Update app/vmselect/main.go Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-07-11 19:33:33 +03:00
Aliaksandr Valialkin	eee384c9c9	app/vmselect: add -clusternative.tls* options for mTLS setup in multi-level clusters	2022-07-06 13:48:21 +03:00
Aliaksandr Valialkin	195dccf678	app/vmselect: add ability to query vmselect from another vmselect	2022-07-06 13:19:45 +03:00
Aliaksandr Valialkin	714958deab	all: follow-up after ed89106274	2022-07-06 12:48:52 +03:00
Roman Khavronenko	f51bc07d97	vmselect: allow proxying requests to vmalert (#2833) ... The change allows to proxy requests with prefix `/vmalert` to the vmalert component if `-vmalert.proxyURL` is set. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2825 and https://github.com/VictoriaMetrics/VictoriaMetrics/pull/2831 Signed-off-by: hagen1778 <roman@victoriametrics.com>	2022-07-06 10:47:51 +02:00
Aliaksandr Valialkin	4f64da874d	app/vmselect: typo fix in the exported metric name: vm_http_request_total -> vm_http_requests_total	2022-06-22 13:18:03 +03:00
Aliaksandr Valialkin	61e03f172b	app/vmselect: optimize /api/v1/labels and /api/v1/label/.../values handlers when match[] query arg is passed to them	2022-06-12 14:06:24 +03:00
Aliaksandr Valialkin	cb39eada77	all: improve query tracing coverage for indexdb search ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1403	2022-06-09 20:04:02 +03:00
Aliaksandr Valialkin	a9ea3fee38	lib/querytracer: make it easier to use by passing trace context message to New and NewChild ... The context message can be extended by calling Donef. If there is no need to extend the message, then just call Done.	2022-06-08 21:16:12 +03:00
Dmytro Kozlov	f2754c3e90	Cardinality explorer (#2625) ... * Cardinality explorer * vmui, vmselect: updated field name, added description to spinner * make vmui-update * updated const name, make vmui-update * lib/storage: changes calculation for totalSeries values * added static files * wip * wip * wip * wip * docs/CHANGELOG.md: document cardinality explorer feature See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2233 Co-authored-by: f41gh7 <nik@victoriametrics.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-06-08 18:54:27 +03:00
Aliaksandr Valialkin	afced37c0b	all: add initial support for query tracing ... See https://docs.victoriametrics.com/Single-server-VictoriaMetrics.html#query-tracing Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1403	2022-06-01 02:31:44 +03:00