Roman Khavronenko
83a4865a45
vmalert: always re-evaluate Annotations ( #3119 )
...
* vmalert: always re-evaluate Annotations
Previously, Annotations were evaluated only:
1. On alert creating.
2. On alert's value change.
This is premature optimization. It was assumed that since annotations
could contain only text with alert's labels or value - there is no need
in spending resources to re-compile Annotations.
Later, template function `query` was added, which can execute
arbitrary queries and return different results on every evaluation.
So if it was used in annotations, it would be executed only on init
or value change.
Another case when optimization caused an issue - annotations hot reload.
In this case, annotations of the active alert won't change even if Rule's
annotations were changed.
This fix enables Annotations re-evaluation on each iteration to resolve
issues above. It would have some impact on performance, but it is unlikely
it will be noticeable.
Signed-off-by: hagen1778 <roman@victoriametrics.com>
* vmalert: add tp Changelog
Signed-off-by: hagen1778 <roman@victoriametrics.com>
Signed-off-by: hagen1778 <roman@victoriametrics.com>
2022-10-06 16:03:06 +03:00
Yury Molodov
8499a78639
vmui: fix data processing ( #3092 )
...
* fix: change data processing
* app/vmselect/vmui: `make vmui-update`
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
2022-10-06 15:57:22 +03:00
Aliaksandr Valialkin
d385e1c60c
app/vmselect/promql: remove empty series before applying aggregate function
...
Previously empty series (e.g. series with all NaN samples) were passed to aggregate functions.
Such series must be ingored by all the aggregate functions.
So it is better from consistency PoV filtering out empty series before applying aggregate functions.
2022-10-06 15:49:55 +03:00
Aliaksandr Valialkin
00a40cdbc5
docs/CHANGELOG.md: document 166d444159
2022-10-06 15:46:30 +03:00
Aliaksandr Valialkin
727255085b
app/vmselect/promql: consistently calculate rate_over_sum(m[d])
as sum_over_time(m[d])/d
...
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3045
2022-10-06 15:44:19 +03:00
Nikolay
b7748841f5
lib/awsapi: fixes sign encoding ( #3183 )
...
* lib/awsapi: fixes sign encoding
previously white spaces at filter were incorrectly encoded
encoding tip was copied from aws signing lib
For example, the space character must be encoded as %20 (not using '+', as some encoding schemes do)
https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html
https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3171
* Update lib/awsapi/sign.go
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
2022-10-06 15:31:29 +03:00
Aliaksandr Valialkin
3a06f14cbe
app/vmauth: do not remove trailing slash from the proxied path
...
This should fix the issue with opening VMUI at /vmui/ page.
See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1752
2022-10-06 15:28:58 +03:00
Aliaksandr Valialkin
5bf3189ab4
app/vmselect: do not export NaN values for stale metrics at /federate endpoint
...
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3185
2022-10-06 15:19:08 +03:00
Aliaksandr Valialkin
07518be94e
docs/Release-Guide.md: sync with the master branch after the commit b9231c715a
2022-09-08 21:04:24 +03:00
Aliaksandr Valialkin
a9abc08139
docs/CHANGELOG.md: document e7119de7f7
2022-09-08 21:04:20 +03:00
Max Golionko
4483b76f79
simplify release process ( #3012 )
...
* simplify release process
* address comments
* address comments
* wip
* wip
* wip
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
2022-08-31 02:31:45 +03:00
Aliaksandr Valialkin
7916d91e6e
docs/CHANGELOG.md: cut v1.79.3
2022-08-30 13:23:11 +03:00
Aliaksandr Valialkin
2090aa56a4
docs/CHANGELOG.md: clarify the change at 28441711e6
2022-08-30 12:04:51 +03:00
Roman Khavronenko
57ed9c47a9
vmalert: follow-up after 28441711e6
( #2972 )
...
Signed-off-by: hagen1778 <roman@victoriametrics.com>
Signed-off-by: hagen1778 <roman@victoriametrics.com>
2022-08-30 12:04:51 +03:00
Aliaksandr Valialkin
00c3afa853
docs/CHANGELOG.md: document the 044d51b668
2022-08-30 11:28:20 +03:00
Aliaksandr Valialkin
00af0141d5
app/vmselect/promql: follow-up after 2d71b4859c
...
- Use getScalar() function for obtaining the expected scalar from phi arg
- Reduce the error message returned to the user when incorrect phi is passed to histogram_quantiles
- Improve the description of this bugfix in the docs/CHANGELOG.md
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3026
2022-08-30 11:21:33 +03:00
Dmytro Kozlov
968ca13d2e
vmselect/promql: fix panic in histogram_quantiles function ( #3029 )
...
* vmselect/promql: fix panic in histogram_quantiles function
* Update docs/MetricsQL.md
Co-authored-by: Roman Khavronenko <roman@victoriametrics.com>
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
Co-authored-by: Roman Khavronenko <roman@victoriametrics.com>
2022-08-30 11:21:33 +03:00
Aliaksandr Valialkin
c23c92f8d3
docs/CHANGELOG.md: document d59d829cdb
...
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/2673
2022-08-30 11:11:17 +03:00
Aliaksandr Valialkin
20b9a30c27
lib/storage: improve performance for /api/v1/labels and /api/v1/label/.../values endpoints when match[]
filter matches small number of time series
...
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2978
2022-08-30 11:01:12 +03:00
Roman Khavronenko
7fda3b7b62
lib/storage: prevent excessive loops when storage is in RO ( #2962 )
...
* lib/storage: prevent excessive loops when storage is in RO
Returning nil error when storage is in RO mode results
into excessive loops and function calls which could
result into CPU exhaustion. Returning an err instead
will trigger delays in the for loop and save some resources.
Signed-off-by: hagen1778 <roman@victoriametrics.com>
* document the change
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
2022-08-30 10:57:56 +03:00
Aliaksandr Valialkin
32ba5ec996
docs/CHANGELOG.md: cut v1.79.2
2022-08-08 16:46:45 +03:00
Aliaksandr Valialkin
d5ef510657
docs/CHANGELOG.md: document bugfix for https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2874
...
This is a follow-up for edecd2493c
2022-08-08 15:53:17 +03:00
Aliaksandr Valialkin
4d8aa13ec1
lib/promscrape/discovery/kubernetes: add missing __meta_kubernetes_ingress_class_name
label for role: ingress
...
See 7e65ad3e43
and 7e1111ff14
2022-08-08 15:51:31 +03:00
Aliaksandr Valialkin
8506d533b1
docs/CHANGELOG.md: link to the issue regarding the increased load on Consul
...
This is a follow-up for 68de1f4e4a
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2940
2022-08-08 15:50:06 +03:00
Aliaksandr Valialkin
ef3fab515d
lib/promscrape/discovery/consul: allow stale responses from Consul service discovery by default
...
This aligns with Prometheus behaviour.
See `allow_stale` option description at https://prometheus.io/docs/prometheus/latest/configuration/configuration/#consul_sd_config
2022-08-08 15:50:05 +03:00
Aliaksandr Valialkin
3764ba98a5
lib/promscrape/discovery/dockerswarm: properly set __meta_dockerswarm_container_label_* labels instead of __meta_dockerswarm_task_label_* labels
...
See https://github.com/prometheus/prometheus/issues/9187
2022-08-08 15:46:59 +03:00
Aliaksandr Valialkin
708f1e8048
app/vmselect/promql: properly return q1
series from q1 ifnot q2
when q2
returns nothing
2022-08-08 15:44:51 +03:00
Aliaksandr Valialkin
f192666fec
app/{vmselect,vmalert}: properly generate http redirects if -http.pathPrefix
command-line flag is set
...
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2918
2022-08-08 15:43:02 +03:00
Aliaksandr Valialkin
0639c955e0
lib/promrelabel: do not split regex into multiple lines if it contains groups
...
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2928
2022-08-08 15:39:24 +03:00
Aliaksandr Valialkin
2dffe566b5
docs/CHANGELOG.md: document 2f9668eba5
2022-08-08 15:35:58 +03:00
Aliaksandr Valialkin
ce00b3862f
lib/promscrape: reload all the scrape configs when the global
section is changed inside -promscrape.config
...
See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2884
2022-08-08 15:33:47 +03:00
Aliaksandr Valialkin
d5bb9ca25a
lib/promscrape: set up=0
for partially failed scrape in stream parsing mode
...
This behaviour aligns with Prometheus behavior
2022-08-08 15:30:52 +03:00
Aliaksandr Valialkin
1005d5a186
lib/promscrape/discovery/ec2: properly handle custom endpoint
option in ec2_sd_configs
...
This option was ignored since d289ecded1
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1287
2022-08-08 15:26:50 +03:00
Aliaksandr Valialkin
bc254cb497
app/vmselect/netstorage: prevent from calling processBlocks callback after the exit from ProcessBlocks function
...
This should prevent from panic at multi-level vmselect
when the top-level vmselect is configured with -replicationFactor > 1
2022-08-08 15:20:39 +03:00
Aliaksandr Valialkin
82ba26ebd9
docs/CHANGELOG.md: document v1.79.1 security fix
2022-08-02 13:37:40 +03:00
Aliaksandr Valialkin
a87f143e92
docs/CHANGELOG.md: cut v1.79.0
2022-07-14 16:15:35 +03:00
Roman Khavronenko
80de6face8
vmalert: drop support of deprecated extra_filter_labels
param ( #2870 )
...
Signed-off-by: hagen1778 <roman@victoriametrics.com>
2022-07-14 16:10:46 +03:00
Aliaksandr Valialkin
36062d27c5
docs/CHANGELOG.md: formatting fixes for update notes
2022-07-14 12:48:17 +03:00
Aliaksandr Valialkin
e6ee940daf
docs: update descriptions for command-line flags according to the latest changes
2022-07-14 00:57:44 +03:00
Yury Molodov
1ca20caa4b
vmui: optimize table view ( #2867 )
...
* feat: optimize table view
* fix: add column display setting
* app/vmselect: `make vmui-update`
Also document the change at docs/CHANGELOG.md
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
2022-07-14 00:16:57 +03:00
Dmytro Kozlov
99402541fb
vmui: update time picker behavior ( #2847 )
...
* vmui: update time picker behavior
* docs/CHANGELOG.md: document the change
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
2022-07-14 00:06:22 +03:00
Yury Molodov
23c3b5f8c7
vmui: change selection from autocomplete ( #2862 )
...
* fix: change selection from autocomplete
* update docs/CHANELOG.md
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
2022-07-13 23:56:04 +03:00
Nikolay
c007b129cb
lib/promscrape: adds azure service discovery ( #2743 )
...
* lib/promscrape: adds azure service discovery
Adds azure service discovery mechanism
implements authorization with oauth and msi
lists virtual machines and virtual machines managed by scaleSet
https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1364
* makes linter happy
* Apply suggestions from code review
Co-authored-by: Roman Khavronenko <roman@victoriametrics.com>
* wip
Co-authored-by: Roman Khavronenko <roman@victoriametrics.com>
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
2022-07-13 23:45:43 +03:00
Aliaksandr Valialkin
da6c85a2f6
all: follow-up for d99ba3481b
2022-07-13 17:17:08 +03:00
Dmytro Kozlov
4e4def9df8
Rename release packages ( #2810 )
...
* makefile: add os to each release file
* makefile: update vmutils arm64
* makefile: update victoria-metrics release process
* makefile: update publish with os
* makefile: update publish with os
* makefile: change tar library
* update release logic
* copy all releases
* sort command by GOOS
* rollback commands
* rollback OSARCH
* fix commands
* cleanup
* fix windows build
* sort build by GOOS, update README.md
2022-07-13 17:11:01 +03:00
Aliaksandr Valialkin
be5fb139d6
docs/CHANGELOG.md: document 91faa152a5
2022-07-13 12:41:25 +03:00
Aliaksandr Valialkin
205c2a468a
docs/CHANGELOG.md: mention that the communication protocol between vmselect
and vmstorage
nodes is updated in the new release
2022-07-13 12:16:59 +03:00
Aliaksandr Valialkin
03680b9334
docs: add links to https://docs.victoriametrics.com/CHANGELOG.html in relevant docs
2022-07-11 21:23:51 +03:00
Aliaksandr Valialkin
b95db7045d
docs/Articles.md: add a link to https://habr.com/ru/company/sravni/blog/672908/
2022-07-11 21:10:59 +03:00
Aliaksandr Valialkin
dd2b1f9ec4
app/vmselect/prometheus: follow-up after 3efe33b917
2022-07-11 20:37:21 +03:00