1991 commits

Author	SHA1	Message	Date
Aliaksandr Valialkin	1a28f0e5b3	lib/promrelabel: pass query args via query string at /metric-relabel-debug and /target-relabel-debug pages if their length doesnt exceed 1000 ... This allows copy-n-pasting the url to another browser window and seeing the same result. The limit in 1000 chars is selected in order to prevent from potential issues with systems which limit the url length such as Internet Explorer - see https://stackoverflow.com/questions/812925/what-is-the-maximum-possible-length-of-a-query-string If the limit is exceeded, then query args are sent via POST method and aren't visible in the url. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3580	2023-01-05 16:48:04 -08:00
Karan Sharma	48f371a46c	lib/promscrape: add Prometheus-compatible service discovery for Nomad (#3549) ... Add nomad_sd_config support for service discovery	2023-01-05 23:03:58 +01:00
Zakhar Bessarab	185cdcd813	lib/promscrape/discovery/dockerswarm: fix query encoding of filters (#3586) ... Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2023-01-05 03:34:25 -08:00
Aliaksandr Valialkin	0dea3b71da	lib/promscrape: pre-fetch metric_relabel_configs rules when debugging metric relabeling for a particular target ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3407	2023-01-05 03:26:49 -08:00
Aliaksandr Valialkin	a1076abcbf	lib/promscrape: follow-up for a7e29c38bc ... - Document the bugfix at docs/CHANGELOG.md - Make the fix more durable against future changes when droppedTargetsMap.Register may be called from other places. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3580	2023-01-05 02:52:08 -08:00
Zakhar Bessarab	a7e29c38bc	lib/promscrape/targetstatus: fix crash during droppedTarget registration (#3595) ... * lib/promscrape/targetstatus: fix crash during droppedTarget registration in case original labels are not present Signed-off-by: Zakhar Bessarab <z.bessarab@victoriametrics.com> * lib/promscrape/targetstatus: address review comment Signed-off-by: Zakhar Bessarab <z.bessarab@victoriametrics.com> Signed-off-by: Zakhar Bessarab <z.bessarab@victoriametrics.com>	2023-01-05 02:39:31 -08:00
Aliaksandr Valialkin	0e1f0ade31	lib/streamaggr: sort by and without labels in the aggregate output metric name ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3460	2023-01-05 02:08:44 -08:00
Aliaksandr Valialkin	66947ee5a2	lib/streamaggr: remove unused fields	2023-01-04 13:33:46 -08:00
Aliaksandr Valialkin	5bca3a5be2	app/vmselect: remove dependency on lib/promscrape from app/vmselect	2023-01-03 23:28:27 -08:00
Aliaksandr Valialkin	fa13bbc48a	app/{vmagent,vminsert}: add support for streaming aggregation ... See https://docs.victoriametrics.com/stream-aggregation.html Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3460	2023-01-03 22:19:21 -08:00
Aliaksandr Valialkin	add2c4bf07	lib/bytesutil: add InternBytes() function as a shortcut to InternString(ToUnsafeString(..))	2023-01-03 22:16:22 -08:00
Aliaksandr Valialkin	7b264b0c23	lib/promrelabel: allow calling Match on nil IfExpression ... This simplifies the caller side of IfExpression	2023-01-03 21:44:03 -08:00
Roman Khavronenko	2cedb3e883	csvimport: support empty values (#3565) ... Before, if the imported line contained multiple metrics and one or more of them had an empty values - the whole line was ignored. Now, only metrics with empty values are ignored, and the rest of the metrics are accepted successfully. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3540 Signed-off-by: hagen1778 <roman@victoriametrics.com> Signed-off-by: hagen1778 <roman@victoriametrics.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-12-29 11:52:10 -08:00
Aliaksandr Valialkin	c4229a1bba	lib/promscrape: log the actual response size in the error message when the response size exceeds -promscrape.maxScrapeSize ... This is a follow-up for 7ad9fff7e5	2022-12-28 14:42:11 -08:00
Aliaksandr Valialkin	1b16118e17	lib/{storage,mergeset}: tune the threshold for assisted merge ... The https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3425#issuecomment-1359117221 reveals that CPU usage for incoming queries may significantly increase when the number of in-memory parts becomes too big. This commit reduces the maximum number of in-memory parts before starting the assisted merge during data ingestion. This should reduce CPU usage for incoming queries, since they need to inspect lower number of in-memory parts. This should help https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3425	2022-12-28 14:39:24 -08:00
Clément Nussbaumer	7ad9fff7e5	fix(promscrape): check MaxScrapeSize after gzip decompression (#3550)	2022-12-28 12:19:41 -08:00
Aliaksandr Valialkin	293dda7169	lib/snapshot: improve log message on unexpected status code during attempts to create or delete snapshots ... Use "unexpected status code returned from %q: %d; expecting %d" log message format instead of less clear format "unexpected status code returned from %q; expecting %d; got %d" This is a follow-up for c612bb165e	2022-12-28 11:41:50 -08:00
Zakhar Bessarab	c612bb165e	lib/snapshot: fix error message format for failed HTTP request (#3559)	2022-12-28 18:04:11 +01:00
Aliaksandr Valialkin	0076422350	lib/promscrape/discovery/azure: typo fix	2022-12-21 21:25:16 -08:00
Aliaksandr Valialkin	fa236c5a84	lib/promrelabel: make fmt after d3de110070	2022-12-21 20:24:57 -08:00
Aliaksandr Valialkin	31886aef3d	lib/promrelabel: add support for keepequal and dropequal relabeling actions ... These actions are supported by Prometheus starting from v2.41.0 See https://github.com/prometheus/prometheus/pull/11564 , https://github.com/prometheus/prometheus/issues/11556 and https://github.com/prometheus/prometheus/issues/3756 Side note: It's a pity that Prometheus developers decided inventing `keepequal` and `dropequal` relabeling actions instead of adding support for `keep_if_equal` and `drop_if_equal` relabeling actions supported by VictoriaMetrics since June 2020 - see 2a39ba639d .	2022-12-21 20:04:55 -08:00
Aliaksandr Valialkin	3300546eab	lib/bytesutil: make sure that the cleanup code is performed only by a single goroutine out of many concurrently running goroutines ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3466	2022-12-21 13:07:24 -08:00
Zakhar Bessarab	4be4645142	app/vmbackupmanager: add metrics for better observability (#488) ... * app/vmbackupmanager: add metrics for better observability, include more information to `/api/v1/backups` API call response * app/vmbackupmanager: drop old metrics before creating new ones * app/vmbackupmanager: use `_total` postfix for counter metrics * app/vmbackupmanager: remove `_total` postfix for gauge-like metrics * app/vmbackupmanager: add `_last_run_failed` metrics for backups and retention * app/vmbackupmanager: address review feedback * app/vmbackupmanager: fix metric name * app/vmbackupmanager: address review feedback, remove background updates of metrics, add restoring state of `_last_run_failed` metric from remote storage * app/vmbackupmanager: improve performance for backup size calculation * app/vmbackupmanager: refactor backup and retention runs to deduplicate each run logic * {app/vmbackupmanager,lib/formatutil}: move HumanizeBytes into lib package * app/vmbackupmanager: fix creating new metrics instead of reusing existing ones * lit/formatutil: add comment to make linter happy * app/vmbackupmanager: address review feedback	2022-12-20 14:18:06 -08:00
Aliaksandr Valialkin	4e55b67a44	lib/storage: clear the err if it is set to io.EOF when searching for the TSID by metricID ... This is expected error after when recently added indexdb data isn't available for search yet or wasn't flushed to disk after unclean shutdown of VictoriaMetrics. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3515	2022-12-20 14:05:29 -08:00
Aliaksandr Valialkin	944effca54	lib/storage: do not check for the result returned by db.doExtDB() where this isn't necessary ... This simplifies the code a bit	2022-12-19 13:23:13 -08:00
Aliaksandr Valialkin	0bf3ae9559	lib/promscrape/discovery/consul: expose service tags in individual labels __meta_consul_tag_<tagname> ... This simplifies copying service tags to target labels with the following relabeling rule: - action: labelmap regex: __meta_consul_tag_(.+) See https://stackoverflow.com/questions/44339461/relabeling-in-prometheus	2022-12-19 13:08:11 -08:00
Aliaksandr Valialkin	6c98b56935	lib/storage: search for TSIDs for the given metricIDs in the previous indexdb if they aren't found in the current indexdb ... The issue triggers after the indexdb rotation for time series, which stop receiving new samples. This results in missing data for such time series in query responses. This commit should address the https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3502 The issue has been introduced in 2dd93449d8	2022-12-19 12:03:09 -08:00
Aliaksandr Valialkin	dc0b08efb0	lib/storage: optimize partSearch.searchBHS() for common case when the TSID for the current block header is bigger or equal to the current tsid ... This should help improving performance at https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3425	2022-12-19 10:28:03 -08:00
Aliaksandr Valialkin	057fb2120b	lib/storage: properly set buf capacity inside marshalMetricID ... Previously it was always set to 0. In theory this could result into incorrect marshaling of metricIDs. The issue has been introduced in 5e4dfe50c6	2022-12-19 10:14:38 -08:00
Aliaksandr Valialkin	4cb83f0f4a	lib/logger: follow-up for 72f8fce107 ... - Document the change at docs/CHANELOG.md - Log fatal errors if the -loggerJSONFields contains unexpected values - Rename -loggerJsonFields to -loggerJSONFields for the sake of consistency naming commonly used in Go Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2348	2022-12-16 17:42:07 -08:00
Michal Kralik	72f8fce107	lib/logger: support for renaming json fields (#3488)	2022-12-16 17:26:32 -08:00
Aliaksandr Valialkin	65f8fc527f	lib/promscrape: stop dropping metric name if relabeling rules do not instruct to do this on the /metric-relabel-debug page	2022-12-16 17:02:41 -08:00
Aliaksandr Valialkin	ad8852759d	lib/storage: skip missing tsids in the current block header by using binary search ... This improves performance by up to 10x when big number of the requested TSIDs are missing in the searched parts. This should help https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3425	2022-12-14 22:06:51 -08:00
Aliaksandr Valialkin	4de9d35458	lib/flagutil/bytes.go: properly handle values bigger than 2GiB on 32-bit architectures ... This fixes handling of values bigger than 2GiB for the following command-line flags: - -storage.minFreeDiskSpaceBytes - -remoteWrite.maxDiskUsagePerURL	2022-12-14 19:26:31 -08:00
Aliaksandr Valialkin	5d30080555	lib/flagutil: support for TB and TiB suffixes for command-line flags, which accept byte sizes	2022-12-14 17:52:32 -08:00
Zakhar Bessarab	a50120a212	lib/backup/azremote: fix copying for parts larger than 256M by using async copy (#3479) ... * lib/backup/azremote: fix copying for parts larger than 256M by using async copy * lib/backup/azremote: add description of an error for log message	2022-12-13 09:32:57 -08:00
Aliaksandr Valialkin	0d41d933e9	lib/mergeset: reduce the parts threshold before starting assisted merges ... This should improve query speed in general case. This is a follow-up for d1af6046c7	2022-12-13 09:13:49 -08:00
Aliaksandr Valialkin	d1af6046c7	lib/{mergeset,storage}: do not block small merges by pending big merges - assist with small merges instead ... Blocked small merges may result into big number of small parts, which, in turn, may result in increased CPU and memory usage during queries, since queries need to inspect all the existing small parts. The issue has been introduced in 8189770c50 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3337	2022-12-12 17:00:50 -08:00
Aliaksandr Valialkin	3b18931050	lib/bytesutil: cache results for all the input strings, which were passed during the last 5 minutes from FastStringMatcher.Match(), FastStringTransformer.Transform() and InternString() ... Previously only up to 100K results were cached. This could result in sub-optimal performance when more than 100K unique strings were actually used. For example, when the relabeling rule was applied to a million of unique Graphite metric names like in the https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3466 This commit should reduce the long-term CPU usage for https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3466 after all the unique Graphite metrics are registered in the FastStringMatcher.Transform() cache. It is expected that the number of unique strings, which are passed to FastStringMatcher.Match(), FastStringTransformer.Transform() and to InternString() during the last 5 minutes, is limited, so the function results fit memory. Otherwise OOM crash can occur. This should be the case for typical production workloads.	2022-12-12 14:41:13 -08:00
Aliaksandr Valialkin	7ae744fce6	lib/protoparser/datadog: do not re-use previously parsed field values if they are missing in the currently parsed message ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3432	2022-12-11 13:09:25 -08:00
Aliaksandr Valialkin	a30ae502ef	lib/promscrape: allow editing relabeling configs and labels at /target-relabel-debug page ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3407	2022-12-10 12:44:45 -08:00
Aliaksandr Valialkin	a8b8e23d68	lib/promscrape: implement target-level and metric-level relabel debugging ... Target-level debugging is performed by clicking the 'debug' link at the corresponding target on either http://vmagent:8429/targets page or on http://vmagent:8428/service-discovery page. Metric-level debugging is perfromed at http://vmagent:8429/metric-relabel-debug page. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3407 See https://docs.victoriametrics.com/vmagent.html#relabel-debug	2022-12-10 02:09:44 -08:00
Aliaksandr Valialkin	2406c0dcfd	docs/CHANGELOG.md: document the bugfix at 05b42601c3 ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3247	2022-12-08 18:35:28 -08:00
Zakhar Bessarab	05b42601c3	lib/promscrape/discovery/azure: remove API server from URL returned by azure (#3403) ... * lib/promscrape/discovery/azure: remove API server from URL returned by azure * lib/promscrape/discovery/azure: validate nextLink contains same URL as apiServer	2022-12-08 18:29:10 -08:00
Aliaksandr Valialkin	8434aa142d	lib/querytracer: fix remaining tests after 49ebc48809	2022-12-08 18:18:06 -08:00
Aliaksandr Valialkin	5b9e6b9d24	lib/storage: follow-up after 7c0ae3a86a ... - Update docs at https://docs.victoriametrics.com/#deduplication - Optimize the deduplication loop a bit Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3333	2022-12-08 18:16:57 -08:00
Roman Khavronenko	7c0ae3a86a	lib/storage: keep sample with the biggest value on timestamp conflict (#3421) ... The change leaves raw sample with the biggest value for identical timestamps per each `-dedup.minScrapeInterval` discrete interval when the deduplication is enabled. ``` benchstat old.txt new.txt name old time/op new time/op delta DeduplicateSamples/minScrapeInterval=1s-10 817ns ± 2% 832ns ± 3% ~ (p=0.052 n=10+10) DeduplicateSamples/minScrapeInterval=2s-10 1.56µs ± 1% 2.12µs ± 0% +35.19% (p=0.000 n=9+7) DeduplicateSamples/minScrapeInterval=5s-10 1.32µs ± 3% 1.65µs ± 2% +25.57% (p=0.000 n=10+10) DeduplicateSamples/minScrapeInterval=10s-10 1.13µs ± 2% 1.50µs ± 1% +32.85% (p=0.000 n=10+10) name old speed new speed delta DeduplicateSamples/minScrapeInterval=1s-10 10.0GB/s ± 2% 9.9GB/s ± 3% ~ (p=0.052 n=10+10) DeduplicateSamples/minScrapeInterval=2s-10 5.24GB/s ± 1% 3.87GB/s ± 0% -26.03% (p=0.000 n=9+7) DeduplicateSamples/minScrapeInterval=5s-10 6.22GB/s ± 3% 4.96GB/s ± 2% -20.37% (p=0.000 n=10+10) DeduplicateSamples/minScrapeInterval=10s-10 7.28GB/s ± 2% 5.48GB/s ± 1% -24.74% (p=0.000 n=10+10) ``` https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3333 Signed-off-by: hagen1778 <roman@victoriametrics.com> Signed-off-by: hagen1778 <roman@victoriametrics.com>	2022-12-08 18:06:11 -08:00
Aliaksandr Valialkin	3019ec3da6	lib/querytracer: fix tests after 49ebc48809	2022-12-08 17:21:38 -08:00
Aliaksandr Valialkin	56b8980915	lib/promscrape: allow using sample_limit and series_limit options in stream parsing mode ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3458	2022-12-08 16:33:38 -08:00
Aliaksandr Valialkin	49ebc48809	lib/querytracer: put the version of VictoriaMetrics in the first message of query trace ... This should simplify further debugging, since the first thing to start the debugging by query trace is to know the version of VictoriaMetrics, which produced this trace.	2022-12-07 09:46:39 -08:00
Pedro Gonçalves	1e0666abb4	Datadog - Add device as a tag if it's present as a field in the series object (#3431) ... * Datadog - Add device as a tag if it's present as a field in the series object * address PR comments	2022-12-05 23:06:03 -08:00
Aliaksandr Valialkin	d99d222f0a	lib/{storage,mergeset}: log the duration for flushing in-memory parts on graceful shutdown	2022-12-05 21:30:48 -08:00
Aliaksandr Valialkin	8189770c50	all: add -inmemoryDataFlushInterval command-line flag for controlling the frequency of saving in-memory data to disk ... The main purpose of this command-line flag is to increase the lifetime of low-end flash storage with the limited number of write operations it can perform. Such flash storage is usually installed on Raspberry PI or similar appliances. For example, `-inmemoryDataFlushInterval=1h` reduces the frequency of disk write operations to up to once per hour if the ingested one-hour worth of data fits the limit for in-memory data. The in-memory data is searchable in the same way as the data stored on disk. VictoriaMetrics automatically flushes the in-memory data to disk on graceful shutdown via SIGINT signal. The in-memory data is lost on unclean shutdown (hardware power loss, OOM crash, SIGKILL). Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3337	2022-12-05 15:16:14 -08:00
Aliaksandr Valialkin	544ea89f91	lib/{mergeset,storage}: add start background workers via startBackgroundWorkers() function	2022-12-04 00:01:04 -08:00
Aliaksandr Valialkin	33dda2809b	lib/mergeset: panic when too long item is passed to Table.AddItems()	2022-12-03 23:32:16 -08:00
Aliaksandr Valialkin	932c1f90ae	lib/storage: remove duplicate logging for filepath on errors	2022-12-03 23:15:22 -08:00
Aliaksandr Valialkin	044a304adb	lib/storage: pass a single arg - rowsPerBlock - to getCompressLevel() function instead of two args	2022-12-03 23:10:16 -08:00
Aliaksandr Valialkin	cb44976716	lib/{storage,mergeset}: use a single sync.WaitGroup for all background workers ... This simplifies the code	2022-12-03 23:03:08 -08:00
Aliaksandr Valialkin	28e6d9e1ff	lib/storage: properly pass retentionMsecs to OpenStorage() at TestIndexDBRepopulateAfterRotation	2022-12-03 23:02:10 -08:00
Aliaksandr Valialkin	343c69fc15	lib/{mergeset,storage}: pass compressLevel to blockStreamWriter.InitFromInmemoryPart ... This allows packing in-memory blocks with different compression levels depending on its contents. This may save memory usage.	2022-12-03 22:46:48 -08:00
Aliaksandr Valialkin	6d87462f4b	lib/mergeset: use the given compressLevel for index and metaindex compression in in-memory part ... Previously only data was compressed with the given compressLevel	2022-12-03 22:34:54 -08:00
Aliaksandr Valialkin	f3e3a3daeb	lib/{mergeset,storage}: take into account byte slice capacity when returning the size of in-memory part ... This results in more correct reporting of memory usage for in-memory parts	2022-12-03 22:30:36 -08:00
Aliaksandr Valialkin	c4150995ad	lib/mergeset: reduce the time needed for the slowest tests	2022-12-03 22:26:33 -08:00
Aliaksandr Valialkin	45299efe22	lib/{storage,mergeset}: consistency rename: `flushRaw{Rows,Items} -> flushPending{Rows,Items}	2022-12-03 22:17:46 -08:00
Aliaksandr Valialkin	5ca58cc4fb	lib/storage: optimization: do not scan block for rows outside retention if it is covered by the retention	2022-12-03 22:14:12 -08:00
Aliaksandr Valialkin	152ac564ab	lib/storage: remove logging redundant path values in a single error message	2022-12-03 22:13:13 -08:00
Aliaksandr Valialkin	93764746c2	lib/filestream: remove logging redundant path values in a single error message	2022-12-03 22:01:51 -08:00
Aliaksandr Valialkin	4f28513b1a	lib/fs: remove logging redundant path values in a single error message	2022-12-03 22:00:20 -08:00
Aliaksandr Valialkin	7c3c08d102	lib/backup: remove logging duplicate path values in a single error message	2022-12-03 21:55:06 -08:00
Aliaksandr Valialkin	14660d4df5	all: typo fix: the the -> the	2022-12-03 21:53:01 -08:00
Aliaksandr Valialkin	ddc3d6b5c3	lib/mergeset: drop the crufty code responsible for direct upgrade from releases prior v1.28.0 ... Upgrade to v1.84.0, wait until the "finished round 2 of background conversion" message appears in the log and then upgrade to newer release.	2022-12-03 21:17:31 -08:00
Aliaksandr Valialkin	05c65bd83f	lib/storage: speed up search for data block for the given tsids ... Use binary search instead of linear scan for looking up the needed data block inside index block. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3425	2022-12-03 20:58:32 -08:00
Aliaksandr Valialkin	299285b147	lib/storage: fix TestUpdateCurrHourMetricIDs test when it runs on the first hour of the day by UTC	2022-12-02 18:52:37 -08:00
Aliaksandr Valialkin	e9636b4c69	lib/{mergeset,storage}: re-use the code for removing isInMerge flag at parts ... Move the common code into releasePartsToMerge() method and consistently use it throughout the code.	2022-12-02 18:52:37 -08:00
Aliaksandr Valialkin	f325410c26	lib/promscrape: optimize service discovery speed ... - Return meta-labels for the discovered targets via promutils.Labels instead of map[string]string. This improves the speed of generating meta-labels for discovered targets by up to 5x. - Remove memory allocations in hot paths during ScrapeWork generation. The ScrapeWork contains scrape settings for a single discovered target. This improves the service discovery speed by up to 2x.	2022-11-29 21:26:00 -08:00
Aliaksandr Valialkin	295c84df66	lib/promscrape/discovery: add a benchmark for measuring the performance of creating pod meta-labels	2022-11-29 20:27:48 -08:00
Aliaksandr Valialkin	654e94f420	lib/promscrape: add exported_ prefix to metric names exported by scrape targets if they clash with automatically generated metrics ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3406	2022-11-28 18:37:09 -08:00
匠心零度	fa0ce10275	lib/storage: remove extra error check (#3396)	2022-11-28 16:43:31 -08:00
Aliaksandr Valialkin	58d459e8a8	app/{vminsert,vmagent}: follow-up after 53a63c6c4c ... Extend /api/v1/import/prometheus with the support for Pushgateway way of specifying additional labels. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1415	2022-11-25 16:48:14 -08:00
Roman Khavronenko	03d88bc066	vmagent: expose metrics for tracking config state (#3375) ... Expose `vm_relabel_config_*` and `vm_promscrape_config_*` metrics for tracking relabel and scrape configuration hot-reloads. https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3345 Signed-off-by: hagen1778 <roman@victoriametrics.com> Signed-off-by: hagen1778 <roman@victoriametrics.com>	2022-11-22 00:38:43 +02:00
Aliaksandr Valialkin	95f0266558	lib/promscrape/discovery/gce: do not pass filter arg when discovering zones ... The filter arg isn't supported by zones API in GCE. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3202	2022-11-21 22:32:05 +02:00
Aliaksandr Valialkin	353396aa23	lib/workingsetcache: expose -cacheExpireDuration command-line flag for fine-tuning of the cache expiration ... While at it, decrease -prevCacheRemovalPercent from 0.2 to 0.1 and increase -cacheExpireDuration from 20 minutes to 30 minutes. This is needed for https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3343	2022-11-17 19:59:13 +02:00
Aliaksandr Valialkin	5955d23232	lib/promscrape: add a benchmark for internLabelStrings()	2022-11-16 23:02:49 +02:00
Aliaksandr Valialkin	a75137c1c2	lib/mergeset: properly reset bsr.bhIdx after the call to blockStreamReader.readNextBHS() ... The issue has been introduced in 58b40f514c Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3343	2022-11-16 21:23:35 +02:00
Aliaksandr Valialkin	c3362e3db4	lib/workingsetcache: add -prevCacheRemovalPercent command-line flag for tuning memory usage vs CPU usage ratio ... Reduce the default value of this flag from 1% to 0.2% after 71335e6024 This flag should help determining the best ratio for https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3343	2022-11-16 12:39:39 +02:00
Aliaksandr Valialkin	4106f197f2	lib/mergeset: retain the buffer with the data used by indexBlock.bhs, inside indexBlock.buf ... Previously indexBlock.bhs pointed to the buffer, which could be changed over time. This could result in incorrect time series search over time. This is a follow-up for 58b40f514c Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3343	2022-11-16 12:09:23 +02:00
Aliaksandr Valialkin	58b40f514c	lib/mergeset: remove string allocation and copying when unmarshaling blockHeader ... This should reduce CPU usage for the case from https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3343	2022-11-15 16:30:54 +02:00
Aliaksandr Valialkin	71335e6024	lib/workingsetcache: tune cache miss threshold for resetting the previous cache from 5% to 1% ... It has been appeared that some production workloads could suffer for some time after every reset of the previous cache when it gets less than 5% of requests after the needed item isn't found in the current cache. This could result in reduced cache hit rates, which, in turn, could increase CPU, disk IO and RAM usage needed for reading, unpacking and caching the missed data from disk. This commit reduces the cache miss threshold for resetting the previous cache from 5% to 1%. This should reduce the possible negative impact after each cache reset by at least 5x, while reducing the total memory used by caches. This is a follow-up for d906d8573e	2022-11-10 13:31:54 +02:00
Aliaksandr Valialkin	86bce7f5f9	lib/promscrape: add more cases to TestAddRowToTimeseries ... This is a follow-up for 16fdd2af8a	2022-11-09 16:13:56 +02:00
Jeremy PLANCKEEL	16fdd2af8a	test(golang): add test to function addRowToTimeseries (#3282) ... Co-authored-by: jplanckeel-externe <jplanckeel.externe@bedrockstreaming.com>	2022-11-09 15:41:26 +02:00
Aliaksandr Valialkin	b8839df32c	lib/protoparser/opentsdb: follow-up after 04b0e4e7bf ... - Simplify the parser code to be less error prone - Document the change - Add a test for OpenTSDB put line with trailing whitespace without tags Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3290	2022-11-09 15:35:05 +02:00
Roman Khavronenko	04b0e4e7bf	protoparser/opentsdb: allow lines without tags (#3303) ... According to http://opentsdb.net/docs/build/html/api_telnet/put.html "At least one tag pair must be present". However, in VictoriaMetrics datamodel tags aren't required. This could be confusing for users. Allowing accept lines without tags seems to do no harm. https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3290 Signed-off-by: hagen1778 <roman@victoriametrics.com> Signed-off-by: hagen1778 <roman@victoriametrics.com>	2022-11-09 15:32:47 +02:00
Aliaksandr Valialkin	7fa5d043f5	lib/promscrape/discovery/consul: add __meta_consul_partition label in the same way as Prometheus does ... See https://github.com/prometheus/prometheus/pull/11482	2022-11-07 15:25:53 +02:00
Aliaksandr Valialkin	daa70e6560	lib/storage: follow-up for 790768f20b ... - Document the bugfix at docs/CHANGELOG.md - Simplify the bugfix a bit	2022-11-07 14:04:08 +02:00
Aliaksandr Valialkin	f9dc3da9e2	lib/storage: typo fix after 32d48f8dfbb03174858c00bdfe6d9d22431dc8d8	2022-11-07 13:58:27 +02:00
Aliaksandr Valialkin	116811d761	lib/envtemplate: allow non-env var names inside "%{ ... }"	2022-11-07 13:58:27 +02:00
Aliaksandr Valialkin	dd88c628aa	lib/storage: remove unused isFull field from hourMetricIDs struct	2022-11-07 13:58:26 +02:00
Łukasz Marszał	790768f20b	Fix issue-3309 - currHourMetricIDs shouldn't contain metrics from prev hour (#3320) ... * fix issue-3309 currHourMetricIDs shouldn't contain metrics from prev hour * Update storage.go	2022-11-07 13:55:37 +02:00
Aliaksandr Valialkin	869e0f9f85	lib/promrelabel: go fmt after 5cec9706dc	2022-10-29 05:17:10 +03:00
Aliaksandr Valialkin	5cec9706dc	lib/promrelabel: add a test from https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3251 ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3251	2022-10-29 04:33:38 +03:00
Aliaksandr Valialkin	320ae1c60a	lib/envflag: small refactoring after 518c340ae3 and 02096e06d0	2022-10-29 02:28:58 +03:00
Aliaksandr Valialkin	76e8888272	lib/promscrape: properly add exported_ prefix to labels, which clash with target labels if honor_labels: true option isn't set. ... The issue was in the `labels := dst[offset:]` line in the beginning of appendExtraLabels() function. The `dst` may be re-allocated when adding extra labels to it. In this case the addition of `exported_` prefix to labels inside `labels` slice become invisible in the returned `dst` labels. While at it, properly handle some corner cases: - Add additional `exported_` prefix to clashing metric labels with already existing `exported_` prefix. - Store scraped metric names in `exported___name__` label if scrape target contains `__name__` label. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3278 Thanks to @jplanckeel for the initial attempt to fix this issue at https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3281	2022-10-28 22:14:26 +03:00
Aliaksandr Valialkin	454baf84d6	lib/promscrape/discovery/kubernetes: do not print an empty kubeconfig_file option in yaml at /config page	2022-10-28 22:14:25 +03:00
Aliaksandr Valialkin	518c340ae3	lib/envtemplate: allow referring env vars from other env vars via %{ENV_VAR} syntax ... This is a follow-up for 02096e06d0	2022-10-26 14:49:33 +03:00
Aliaksandr Valialkin	02096e06d0	lib/envflag: allow referring environment variables in command-line flags	2022-10-26 01:52:05 +03:00
Aliaksandr Valialkin	c4265322f4	lib/fs: add canOverwrite arg to WriteFileAtomically when it is allowed to overwrite the file atomically if it already exists	2022-10-26 01:07:34 +03:00
Aliaksandr Valialkin	d9bbf24183	app/{vminsert,vmselect}/netstorage: allow calling Init()+MustStop() in a loop ... Previously netstorage.MustStop() call didn't free up all the resources, so the subsequent call to nestorage.Init() would panic. This allows writing tests, which call nestorage.Init() + nestorage.MustStop() in a loop.	2022-10-25 17:47:17 +03:00
Aliaksandr Valialkin	8e998aa1a1	lib/storage: add support for retention filters (aka multiple retentions for distinct sets of time series) ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/143 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/289	2022-10-24 16:40:20 +03:00
Aliaksandr Valialkin	dba218a8ce	lib/storage: skip blocks outside the configured retention during search ... Blocks outside the configured retention are eventually deleted during background merge. But such blocks may reside in the storage for long time until background merge. Previously VictoriaMetrics could spend additional CPU time on processing such blocks during search queries. Now these blocks are skipped.	2022-10-24 02:52:44 +03:00
Aliaksandr Valialkin	e2f0b76ebf	lib/storage: do not pass retentionMsecs and isReadOnly args explicitly - access them via Storage arg ... This makes code easier to read. This is a follow-up after d2d30581a0	2022-10-24 01:31:04 +03:00
Aliaksandr Valialkin	89a1108b1a	lib/storage: small code cleanups	2022-10-24 01:17:47 +03:00
Aliaksandr Valialkin	05512fdd74	lib/storage: re-use newTestStorage() instead of manually initializing Storage mock ... This is a follow-up for d2d30581a0	2022-10-23 16:24:00 +03:00
Aliaksandr Valialkin	d2d30581a0	lib/storage: pass Storage to table and partition instead of getDeletedMetricIDs callback ... This improves code readability a bit.	2022-10-23 16:10:04 +03:00
Aliaksandr Valialkin	54f35c175c	lib/storage: small refactoring: move retentionDeadline to blockStreamMerger ... This allows defining per-block retention in the future by updating the getRetentionDeadline function	2022-10-23 16:10:02 +03:00
Aliaksandr Valialkin	187e294a53	lib/storage: use a single reference to the currently merged block - bsm.Block during the block merge loop	2022-10-23 14:08:57 +03:00
Aliaksandr Valialkin	d0a9ca1bc2	lib/storage: properly pass uint64 constant to fmt.Errorf on 32-bit platforms	2022-10-23 12:48:00 +03:00
Aliaksandr Valialkin	5e4dfe50c6	lib/storage: subsitute searchTSIDs functions with more lightweight searchMetricIDs function ... The searchTSIDs function was searching for metricIDs matching the the given tag filters and then was locating the corresponding TSID entries for the found metricIDs. The TSID entries aren't needed when searching for time series names (aka MetricName), so this commit removes the uneeded TSID search from the implementation of /api/v1/series API. This improves perfromance of /api/v1/series calls. This commit also improves performance a bit for /api/v1/query and /api/v1/query_range calls, since now these calls cache small metricIDs instead of big TSID entries in the indexdb/tagFilters cache (now this cache is named indexdb/tagFiltersToMetricIDs) without the need to compress the saved entries in order to save cache space. This commit also removes concurrency limiter during searching for matching time series, which was introduced in 8f16388428, since the concurrency for all the read queries is already limited with -search.maxConcurrentRequests command-line flag. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/648	2022-10-23 12:23:47 +03:00
Aliaksandr Valialkin	4128ad71e2	lib/storage: move common code to newRawRowsBlock() function	2022-10-21 14:46:55 +03:00
Aliaksandr Valialkin	b5674164c6	lib/storage: simplify code a bit after 3f5959c053	2022-10-21 14:39:27 +03:00
Aliaksandr Valialkin	fd7c86ae25	lib/{mergeset,storage}: simplify the code a bit after ae55ad8749	2022-10-21 14:33:03 +03:00
Aliaksandr Valialkin	99d67ac8ad	lib/storage: validate timestamps in the block only if they use encoding, which needs validation ... This reduces CPU usage when there is no sense in validating timestamps. This is a follow-up for 5fa9525498 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2998 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3011	2022-10-21 00:52:32 +03:00
Aliaksandr Valialkin	3f5959c053	lib/storage: try generating initial parts from inmemory rows with identical sizes under high ingestion rate ... This should improve background merge rate under high load a bit	2022-10-20 23:28:24 +03:00
Aliaksandr Valialkin	891ff6af2a	lib/workingsetcache: increase default cache expiration from 10 minutes to 20 minutes ... This increases the maximum time for cache population with new entries from 20 minutes to 40 minutes. This This change shouldn't increase memory usage for caches, since the prev cache cleaner should free up memory by deleting unused prev cache as soon as possible. See 08ca45d238 for details on prev cache cleaner.	2022-10-20 21:48:25 +03:00
Aliaksandr Valialkin	08ca45d238	lib/workingsetcache: move the cleaner for the prev cache into a separate goroutine ... This makes the code more clear after d906d8573e	2022-10-20 21:45:29 +03:00
Aliaksandr Valialkin	4cd173bbaa	lib/procutil: stop immediately after receiving the second SIGINT or SIGTERM signal ... Previously VictoriaMetrics apps could stop responding to SIGINT and SIGTERM signals if they hang for some reason in graceful shutdown procedure.	2022-10-20 21:40:20 +03:00
Aliaksandr Valialkin	150e99d403	lib/{mergeset,storage}: avoid unaligned 64-bit atomic operation panic on 32-bit platforms ... The panic has been introduced in 68f3a02589 While at it, add padding to shard structs in order to avoid false sharing on mordern CPUs This should improve scalability on systems with many CPU cores	2022-10-20 16:25:43 +03:00
Aliaksandr Valialkin	d906d8573e	lib/workingsetcache: drop the previous cache whenever it recieves less than 5% of requests comparing to the current cache ... This means that the majority of requests are successfully served from the current cache, so the previous cache can be reset in order to free up memory.	2022-10-20 10:47:58 +03:00
Aliaksandr Valialkin	817aeafd69	lib/workingsetcache: use per-bucket stats counters instead of global stats counters for cache hits/misses ... This should improve cache scalability on systems with many CPU cores.	2022-10-20 09:12:17 +03:00
Aliaksandr Valialkin	9c02c39487	lib/workingsetcache: randomize interval for swapping curr and prev caches ... This should make CPU usage smoother over time, since different caches will be swapped at different times.	2022-10-20 08:42:43 +03:00
Nikolay	1059c4d84a	lib/promscrape/discovery/kubernetes: correctly wrap error (#3250) ... * lib/promscrape/discovery/kubernetes: correctly wrap error follow-up after 1304824201 * Update docs/CHANGELOG.md Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-10-18 20:37:42 +03:00
Aliaksandr Valialkin	069401a304	all: log error when environment variables referred from -promscrape.config are missing ... This should prevent from using incorrect config files	2022-10-18 10:47:16 +03:00
Aliaksandr Valialkin	fb50730ba7	lib/storage: double the number of rawRows shards on multi-core systems ... This should increase data ingestion scalability on multi-core systems at the cost of slightly higher memory usage	2022-10-17 18:19:51 +03:00
Aliaksandr Valialkin	ae55ad8749	lib/{storage,mergeset}: do not hold per-shard lock in fast path when adding per-shard items to the flush list	2022-10-17 18:01:26 +03:00
Aliaksandr Valialkin	b6e8c1403a	lib/promrelabel: add relabeling tests when the source label is missing	2022-10-17 14:47:52 +03:00
Aliaksandr Valialkin	2e3be68617	lib/bytesutil: make sure that the string passed to FastStringMather.Match() is copied before using it as a key in the internal cache map ... This prevents from possible corruption of the internal cache map when the underlying byte slice used by the string key is modified. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3227	2022-10-14 09:51:19 +03:00
Nikolay	b856581ad3	lib/backup: set s3 default region to us-west-2 (#3224) ... * lib/backup: set s3 default region to us-west-2 it should fix an error with region detection for bucket, if AWS_REGION env var is not set * Update lib/backup/s3remote/s3.go Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-10-13 10:30:07 +03:00
Aliaksandr Valialkin	185cff307b	lib/mergeset: mention in the error message the path to the part, which triggered the error ... This should improve debuggability	2022-10-12 09:54:21 +03:00
Aliaksandr Valialkin	50f5eae0e0	lib/promrelabel: remove unconditional sorting of the labels in ParsedConfigs.Apply(), since the sorting isnt needed in many places ... Sort labels explicitly after calling the ParsedConfigs.Apply() when needed. This reduces CPU usage when performing metric-level relabeling, where labels' sorting isn't needed.	2022-10-09 14:51:16 +03:00
Aliaksandr Valialkin	5269b1ad77	lib/promscrape: allow controlling staleness tracking on a per-scrape_config basis ... Add support for no_stale_markers option at scrape_config section. See https://docs.victoriametrics.com/sd_configs.html#scrape_configs and https://docs.victoriametrics.com/vmagent.html#prometheus-staleness-markers	2022-10-07 23:36:14 +03:00
Aliaksandr Valialkin	f9df0cae16	lib/promscrape: allow specifying full target url in __address__ label ... Previously the `__address__` label could contain only `host:port` part of the target url, while the scheme and metrics path were obtained from `__scheme__` and `__metrics_path__` labels. Now it is possible to set the full url in `__address__` label. This makes valid the following scrape config, which is frequently used by novice users: scrape_configs: - job_name: foo static_configs: - targets: - http://host1/metrics1 - https://host2/metrics2	2022-10-07 22:43:04 +03:00
Aliaksandr Valialkin	711698b858	lib/backup/azremote: typo fixes after 03872025b747fcc4ee98710ad10fc98764328511	2022-10-07 01:02:06 +03:00
Zakhar Bessarab	176f10f5b2	app/vmbackup: fix compatibility with latest azure sdk (#461)	2022-10-07 01:02:03 +03:00
Aliaksandr Valialkin	d9282027e6	app: follow-up after ec04fcac93 ... * Optimize fast path for /api/v1/import when importing numeric values * Move the docs about the change from features to bugfixes at docs/CHANGELOG.md * Update tests at lib/protoparser/vmimport Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3161	2022-10-06 14:52:02 +03:00
Dmytro Kozlov	ec04fcac93	Properly parse json when export import metric (#3180) ... * app/vmselect: properly work when export import json from `api/v1/{export, import}` API * app/vmselect: update convert function * app/vmselect: export null if `math.IsNaN(v)` * app/vmselect: get float from json * lib/protoparser: add test * docs: add change log * lib/protoparser: make export import api compatible	2022-10-06 13:54:20 +03:00
Zakhar Bessarab	97239e05ce	lib/backup/s3remote: fix error checking for alternative S3 providers (#3191)	2022-10-06 13:36:40 +03:00
Aliaksandr Valialkin	1e93ad84e3	lib/backup/azremote: remove unused methods after the 262ce77e2d	2022-10-06 13:08:58 +03:00
Zakhar Bessarab	262ce77e2d	lib/backup: add support of Azure Blob Storage (#460) ... * lib/backup: add support of Azure Blob Storage * lib/backup: add enterprise support of Azure Blob Storage	2022-10-06 00:32:46 +03:00
Aliaksandr Valialkin	0dc93cca7f	app/vmagent/remotewrite: allow specifying per--remoteWrite.url disk limits for persistent queue with pending data ... This commit is based on https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3071 Related issue: https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2970	2022-10-01 18:40:59 +03:00
Aliaksandr Valialkin	c1fa9828b3	lib/flagutil: rename Array to ArrayString ... This makes the ArrayString more consistent with other Array* types. While at it, add ArrayBytes type, which will be used for https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3071	2022-10-01 18:26:36 +03:00
Zakhar Bessarab	87c77727e4	vmbackup: update AWS SDK to v2 (#3174) ... * lib/backup/s3remote: update AWS SDK to v2 * Update lib/backup/s3remote/s3.go Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com> * lib/backup/s3remote: refactor error handling Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-10-01 17:12:07 +03:00
Aliaksandr Valialkin	725dfb0ed6	lib/httpserver: use 302 redirects instead of 301 redirects ... Incorrect 301 redirects can be cached by user agents such as web browsers. This can complicate recovery procedure after the incorrect redirect is fixed, e.g. web browser cache must be reset. The related issue - https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1752	2022-10-01 16:53:35 +03:00
Aliaksandr Valialkin	4998402004	lib/promscrape: add external_labels from global section of -promscrape.config after the relabeling is applied to the scraped metrics ... This aligns with Prometheus behaviour. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3137	2022-10-01 16:13:19 +03:00
Aliaksandr Valialkin	3a98ef2f5f	lib/promrelabel: export MustParseMetricWithLabels function, which can be used for simplifying tests	2022-10-01 16:05:51 +03:00
Aliaksandr Valialkin	f86070169d	lib/promscrape/discovery/azure: remove unneeded conversion to string	2022-10-01 16:04:37 +03:00
Aliaksandr Valialkin	db16759c68	lib/storage: optimize matching speed for non-trivial regexp filters ... Wrap re.Match into bytesutil.FastStringMatcher. This increases performance for `{foo=~"complex_regex_here"}` filters by up to 4x.	2022-10-01 12:06:06 +03:00
Aliaksandr Valialkin	e8a64f6e7a	lib/promrelabel: remove redundant memory allocations by using interned strings	2022-10-01 11:50:21 +03:00
Aliaksandr Valialkin	73dc17ef64	lib/promrelabel: add a benchmark for realistic Kubernetes relabeling ... The benchmark name is BenchmarkApplyRelabelConfigs/kubernetes This benchmark has been copied from d521933053/model/relabel/relabel_test.go (L505) See also https://github.com/prometheus/prometheus/pull/11147	2022-10-01 10:38:22 +03:00
Aliaksandr Valialkin	c54e14cdec	lib/promscrape/discovery/ec2: expose __meta_ec2_region label in the same way as Prometheus 2.39 does ... See https://github.com/prometheus/prometheus/pull/11326	2022-09-30 20:48:32 +03:00
Nikolay	33f40f4a5f	app/vminsert: allows parsing tenant id from labels (#3009) ... * app/vminsert: allows parsing tenant id from labels it should help mitigate issues with vmagent's multiTenant mode, which works incorrectly at heavy load and it cannot handle more then 100 different tenants. This functional hidden with flag and do not change vminsert default behaviour https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2970 * Update docs/Cluster-VictoriaMetrics.md Co-authored-by: Roman Khavronenko <roman@victoriametrics.com> * wip * app/vminsert/netstorage: clean remaining labels in order to free up GC * docs/Cluster-VictoriaMetrics.md: typo fix * wip * wip Co-authored-by: Roman Khavronenko <roman@victoriametrics.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-09-30 18:35:53 +03:00
Aliaksandr Valialkin	171dd14aa3	lib/promrelabel: go fmt	2022-09-30 12:28:55 +03:00
Aliaksandr Valialkin	a18d6d5ccc	lib/promrelabel: optimize action: replace for non-trivial regex values ... Cache `action: replace` results for non-trivial regexs and return them next time instead of performing CPU-intensive regex replacement. Optimize also `action: labelmap_all` and `action: replace_all` in the same way.	2022-09-30 12:25:05 +03:00
Aliaksandr Valialkin	146021a076	lib/promrelabel: there is no need in calling regex.HasPrefix() after the optimization at 17289ff481	2022-09-30 10:49:18 +03:00
Aliaksandr Valialkin	899d2c40fb	lib/promrelabel: optimize action: labelmap for non-trivial regexs	2022-09-30 10:43:31 +03:00
Aliaksandr Valialkin	17289ff481	lib/regexutil: cache MatchString results for unoptimized regexps ... This increases relabeling performance by 3x for unoptimized regexs	2022-09-30 10:41:29 +03:00
Aliaksandr Valialkin	fda60b3d4d	lib/promrelabel: properly parse regex with escaped $ at the end ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3131 Thanks to @dmitryk-dk for the initial fix at https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3179	2022-09-30 08:15:43 +03:00
Aliaksandr Valialkin	593da3603e	lib/bytesutil: move InternString() from lib/promscrape/discoverytutils to lib/bytesutil ... lib/bytesutil is more appropriate place for InternString() function	2022-09-30 07:44:35 +03:00
Nikolay	f61b8cec69	lib/awsapi: fixes sign encoding (#3183) ... * lib/awsapi: fixes sign encoding previously white spaces at filter were incorrectly encoded encoding tip was copied from aws signing lib For example, the space character must be encoded as %20 (not using '+', as some encoding schemes do) https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3171 * Update lib/awsapi/sign.go Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-09-30 07:43:44 +03:00
Aliaksandr Valialkin	6a32a64073	lib/bytesutil: add FastStringTransformer and use it in the rest of the code where needed	2022-09-28 10:41:00 +03:00
Aliaksandr Valialkin	92b3622253	lib/protoparser/datadog: optimize sanitizeName() function by using result cache for input strings ... This is a follow-up for 7c2474dac7 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3105	2022-09-28 10:40:59 +03:00
Aliaksandr Valialkin	ef435f8cc4	lib/promrelabel: add SanitizeName() function for sanitizing Prometheus metric names and label names ... Optimize this function by using results cache for input strings. Use this function all over the code. This is a follow-up for fcffdba9dc Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3113	2022-09-28 10:40:59 +03:00
Aliaksandr Valialkin	6411bbcce7	lib/netutil/tls.go: consistently use tlsMinVersion name across source code ... This should simplify further code maintenance and refactoring This is a follow-up after 6ab1cede62	2022-09-26 17:58:01 +03:00
Dmytro Kozlov	6ab1cede62	lib/{httpserver,netutil}: allow to define min and max TLS version of the http server (#3109) ... * lib/{httpserver,netutil}: allow to define min and max TLS version of the http server * lib/httpserver: added descriptions about tls supported versions * lib/netutil: check minimal tls version, added supported tls versions to error * wip Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-09-26 17:35:45 +03:00
Roman Khavronenko	e96ccf3f71	lib/mergeset: follow-up after a0e7432e42 (#3145) ... * lib/mergeset: follow-up after a0e7432e42 Signed-off-by: hagen1778 <roman@victoriametrics.com> * Apply suggestions from code review Signed-off-by: hagen1778 <roman@victoriametrics.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-09-26 16:39:56 +03:00
Zakhar Bessarab	f022296d96	vmbackup: configure retries for GCS remote FS (#3156)	2022-09-26 16:28:20 +03:00
Aliaksandr Valialkin	41f8c2987d	lib/protoparser/graphite: accept whitespace in metric names and tags according to the specification ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/99 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3102 See the specification https://graphite.readthedocs.io/en/latest/tags.html	2022-09-26 15:17:25 +03:00
Aliaksandr Valialkin	7c2474dac7	lib/protoparser/datadog: sanitize metric names by default in the same way as DataDog does ... This commit is based on the pull request https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3105 Thanks to @PerGon for the idea and initial implementation.	2022-09-26 13:57:23 +03:00
匠心零度	3d5509a720	lib/querytracer: fix comment (#3135)	2022-09-22 19:19:48 +03:00
Aliaksandr Valialkin	56ce7ce85b	lib/promscrape: typo fix after 74c00a8762	2022-09-14 15:06:50 +03:00
Aliaksandr Valialkin	74c00a8762	lib/promscrape: read response body into memory in stream parsing mode before parsing it ... This reduces scrape duration for targets returning big responses. The response body was already read into memory in stream parsing mode before this change, so this commit shouldn't increase memory usage.	2022-09-14 13:15:29 +03:00
Aliaksandr Valialkin	ccad651a61	lib/promscrape/discovery/kubernetes: add more context on WatchEvent parse error ... This should improve debugging issues with Kubernetes API server	2022-09-13 19:36:55 +03:00
Aliaksandr Valialkin	ce2c07c5a7	lib/mergeset: atomically remove part dirs ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3038	2022-09-13 16:17:38 +03:00
Aliaksandr Valialkin	042a532f70	lib/storage: substitute remaining calls to fs.MustRemoveAll with fs.MustRemoveDirAtomic ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3038	2022-09-13 16:17:38 +03:00
Aliaksandr Valialkin	68e32b0764	lib/storage: atomically remove parts inside partitions ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3038	2022-09-13 16:17:38 +03:00
Aliaksandr Valialkin	340ada871d	lib/storage: atomically remove partitions, which went outside the configured retention ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3038	2022-09-13 16:17:37 +03:00
Aliaksandr Valialkin	978dcb4574	lib/storage: properly remove cache directory contents if reset_cache_on_startup file is located there ... Previously the cache directory was removed. This could result in error when the cache directory is mounted to a separate filesystem.	2022-09-13 16:17:36 +03:00
Aliaksandr Valialkin	5f28ca1f42	lib/storage: atomically remove snapshot directories ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3038	2022-09-13 16:17:36 +03:00
Aliaksandr Valialkin	5fa9525498	lib/storage: verify that timestamps in block are in the range specified by blockHeader.{Min,Max}Timestamp when upacking the block ... This should reduce chances of unnoticed on-disk data corruption. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2998 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3011 This change modifies the format for data exported via /api/v1/export/native - now this data contains MaxTimestamp and PrecisionBits fields from blockHeader. This is OK, since the native export format is undocumented.	2022-09-06 13:08:09 +03:00
Bryce Lampe	74f8e12e87	Support "HTTP" and "HTTPS" schemes (#3019) ... * Support "HTTP" and "HTTPS" schemes * Update lib/promscrape/config.go Co-authored-by: Aliaksandr Valialkin <valyala@gmail.com>	2022-08-27 02:22:37 +03:00
Aliaksandr Valialkin	30b8d91727	lib/promscrape/discoveryutils: always store just allocated string to sanitized label names cache ... This is a follow-up for c06e7a142c	2022-08-27 00:28:39 +03:00
Aliaksandr Valialkin	c06e7a142c	lib/promscrape: optimize discoveryutils.SanitizeLabelName() ... Cache sanitized label names and return them next time. This reduces the number of allocations and speeds up the SanitizeLabelName() function for common case when the number of unique label names is smaller than 100k	2022-08-27 00:17:45 +03:00
Aliaksandr Valialkin	a2cd79576f	lib/promrelabel: call PromRegex.MatchString() on a slow path only if it contains non-empty literal prefix ... This should improve slow path speed for regexps without literal prefixes	2022-08-26 21:48:30 +03:00
Aliaksandr Valialkin	f49c9bb700	lib/promrelabel: optimize common regex mismatch cases for action: replace and action: labelmap	2022-08-26 15:45:31 +03:00
Aliaksandr Valialkin	4c6916f32a	lib/promrelabel: use regexutil.PromRegex for regex matching in actions labeldrop,labelkeep,drop and keep ... This makes possible optimizing additional cases inside regexutil.PromRegex	2022-08-26 15:23:45 +03:00
Aliaksandr Valialkin	7afe8450fc	lib/promrelabel: optimize matching for commonly used regex patterns in if option ... The following regex patterns are optimized: - literal string match, e.g. "foo" - prefix match, e.g. "foo.*" and "foo.+" - substring match, e.g. ".*foo.*" and ".+foo.+" - alternate values match, e.g. "foo|bar|baz"	2022-08-26 14:53:06 +03:00
Aliaksandr Valialkin	0ad3bbadd3	lib/regexutil: add Simplify() function for simplifying the regular expression	2022-08-26 11:57:12 +03:00
Aliaksandr Valialkin	b373661988	lib/promrelabel: optimize action: {drop,keep,labeldrop,labelkeep} with anchored regex prefix ... The following commonly used relabeling rules must work faster now: - action: labeldrop regex: "^foo.+$" - action: labeldrop regex: "^bar.*"	2022-08-25 23:23:55 +03:00
Aliaksandr Valialkin	0d4ea03a73	lib/promrelabel: optimize action: {labeldrop,labelkeep,keep,drop} with regex containing alternate values ... For example, the following relabeling rule must work much faster now: - action: labeldrop regex: "foo|bar|baz"	2022-08-24 17:54:29 +03:00
Aliaksandr Valialkin	0d46e24af5	lib/storage: increase the maximum possible or values extracted from regexp from 20 to 100 ... This should improve time series search speed for regexp filters with big number of `or` values.	2022-08-24 17:15:25 +03:00
Aliaksandr Valialkin	fdbf5b5795	lib/storage: ignore start text and end text anchors in getOrValues(regexp) function ... This is OK, since the anchors are implicitly applied to the whole regexp. This optimization should improve the speed for regexp series filters with explicit $ and ^ anchors. For example, `{label="^(foo|bar)$"}`	2022-08-24 17:12:52 +03:00
Aliaksandr Valialkin	796aa310c2	app/vmstorage: expose vm_{hourly,daily}_series_limit_{max,current}_series metrics if -storage.max{Hourly,Daily}Series limits are set ... These metrics allow alerting when the number of unique series approach the limit. For example, the following query alerts when the number of series reaches 90% of the configured limit: vm_hourly_series_limit_current_series / vm_hourly_series_limit_max_series > 0.9	2022-08-24 13:44:04 +03:00
Aliaksandr Valialkin	1f89278d88	all: subsitute ioutil.ReadAll with io.ReadAll ... ioutil.ReadAll is deprecated since Go1.16 - see https://tip.golang.org/doc/go1.16#ioutil VictoriaMetrics requires at least Go1.18, so it is OK to switch from ioutil.ReadAll to io.ReadAll. This is a follow-up for 02ca2342ab	2022-08-22 00:16:37 +03:00
Aliaksandr Valialkin	2c3a89339d	all: use os.ReadDir instead of ioutil.ReadDir ... The ioutil.ReadDir is deprecated since Go1.16 - see https://tip.golang.org/doc/go1.16#ioutil VictoriaMetrics requires at least Go1.18, so it is time to switch from io.ReadDir to os.ReadDir This is a follow-up for 02ca2342ab	2022-08-22 00:02:25 +03:00
Aliaksandr Valialkin	9f94c295ab	all: use os.{Read|Write}File instead of ioutil.{Read|Write}File ... The ioutil.{Read|Write}File is deprecated since Go1.16 - see https://tip.golang.org/doc/go1.16#ioutil VictoriaMetrics needs at least Go1.18, so it is safe to remove ioutil usage from source code. This is a follow-up for 02ca2342ab	2022-08-21 23:52:35 +03:00
Roman Khavronenko	d59d829cdb	lib/storage: bump max merge concurrency for small parts to 15 (#2997) ... * lib/storage: bump max merge concurrency for small parts to 15 The change is based on the feedback from users on github. Thier examples show, that limit of 8 sometimes become a bottleneck. Users report that without limit concurrency can climb up to 15-20 merges at once. Signed-off-by: hagen1778 <roman@victoriametrics.com> * Update lib/storage/partition.go Signed-off-by: hagen1778 <roman@victoriametrics.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-08-21 23:32:08 +03:00
Aliaksandr Valialkin	8550c44e31	app/vmagent: add ability to construct a label from multiple existing labels by referring them in the replacement field during relabeling ... For example: - target_label: composite-label replacement: "{{source_label1}}-{{source_label2}}"	2022-08-21 22:50:01 +03:00
Roman Khavronenko	31f922944e	lib/storage: fix the search for empty label name (#2991) ... * lib/storage: fix the search for empty label name Signed-off-by: hagen1778 <roman@victoriametrics.com> * Apply suggestions from code review Signed-off-by: hagen1778 <roman@victoriametrics.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-08-17 21:32:25 +03:00
Aliaksandr Valialkin	7d26414b2e	lib/promscrape: automatically generate additional per-target labels for targets with non-zero series limit ... The following metrics are generated: - scrape_series_limit - scrape_series_current - scrape_series_limit_samples_dropped These metrics simplify alerting on targets, which expose too many time series See https://docs.victoriametrics.com/vmagent.html#automatically-generated-metrics and https://docs.victoriametrics.com/vmagent.html#cardinality-limiter for more details	2022-08-17 13:19:33 +03:00
Aliaksandr Valialkin	bb68ab99fa	lib/promscrape: retry http requests if the server returns 429 status code ... The 429 status code means that the server is overwhelmed with requests. The client can retry the request after some wait time. Implement this strategy for service discovery and scrape requests. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2940	2022-08-16 15:01:08 +03:00
Aliaksandr Valialkin	b0e1bb517e	lib/storage: typo fix in comments after f830edc0bc	2022-08-16 13:44:45 +03:00
Aliaksandr Valialkin	f830edc0bc	lib/storage: improve performance for /api/v1/labels and /api/v1/label/.../values endpoints when match[] filter matches small number of time series ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2978	2022-08-16 13:32:40 +03:00
Aliaksandr Valialkin	c3f8481011	lib/promscrape: update links to sd_configs from Prometheus site to https://docs.victoriametrics.com/sd_configs.html	2022-08-15 01:40:20 +03:00
Aliaksandr Valialkin	95d36da358	lib/promscrape/discovery/kubernetes: add __meta_kubernetes_pod_container_image label in the same way as Prometheus 2.38 does ... See https://github.com/prometheus/prometheus/pull/11034	2022-08-15 01:18:23 +03:00
Aliaksandr Valialkin	c4fcd9f1c5	lib/promscrape/discovery/kubernetes: add __meta_kubernetes_service_port_number label to role: service in the same way as Prometheus 2.38 does ... See https://github.com/prometheus/prometheus/pull/11002	2022-08-15 01:06:34 +03:00
Aliaksandr Valialkin	511805d88d	lib/promscrape/discovery/dns: add support for resolving MX records ... See https://github.com/prometheus/prometheus/pull/10099	2022-08-15 00:32:34 +03:00
Roman Khavronenko	a0e7432e42	lib/storage: prevent excessive loops when storage is in RO (#2962) ... * lib/storage: prevent excessive loops when storage is in RO Returning nil error when storage is in RO mode results into excessive loops and function calls which could result into CPU exhaustion. Returning an err instead will trigger delays in the for loop and save some resources. Signed-off-by: hagen1778 <roman@victoriametrics.com> * document the change Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-08-09 12:17:00 +03:00
Aliaksandr Valialkin	46d7792b72	lib/promscrape: follow-up after 2c553d5a2f ... - fix broken tests - cosmetic code cleanup - document the change at https://docs.victoriametrics.com/vmagent.html#multitenancy - document the change at https://docs.victoriametrics.com/CHANGELOG.html	2022-08-08 14:46:26 +03:00
Fury	2c553d5a2f	add support to scrape multi tenant metrics (#2950) ... * add support to scrape multi tenant metrics * add support to scrape multi tenant metrics Co-authored-by: 赵福玉 <zhaofuyu@zhaofuyudeMac-mini.local>	2022-08-08 14:10:18 +03:00
Roman Khavronenko	d3f13ab85b	lib/promrelabel: fix expected test result (#2957) ... follow-up after 68c4ec9472 Signed-off-by: hagen1778 <roman@victoriametrics.com>	2022-08-08 13:47:29 +03:00
Aliaksandr Valialkin	68c4ec9472	lib/promrelabel: do not split regex into multiple lines if it contains groups ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2928	2022-08-08 03:15:26 +03:00
Aliaksandr Valialkin	892c97e350	lib/auth: follow-up after b6a6a659f4	2022-08-07 23:14:39 +03:00
Dmytro Kozlov	b6a6a659f4	lib/auth: add tests for NewToken function (#2921) ... * lib/auth: add tests from NewToken function * lib/auth: update test, fix problem with type conversion * lib/auth: update test description * lib/auth: simplify failure tests	2022-08-07 23:07:57 +03:00
Aliaksandr Valialkin	9fa6b25fb2	lib/logger: prettify logging the defined command-line flags	2022-08-07 22:58:29 +03:00
Aliaksandr Valialkin	0ef29ceb14	lib/promscrape/discovery/kubernetes: add missing __meta_kubernetes_ingress_class_name label for role: ingress ... See 7e65ad3e43 and 7e1111ff14	2022-08-05 20:55:00 +03:00
Aliaksandr Valialkin	f2816ef031	lib/promscrape/discovery/ec2: properly handle custom endpoint option in ec2_sd_configs ... This option was ignored since d289ecded1 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1287	2022-08-05 18:50:02 +03:00
Aliaksandr Valialkin	3e8890e71b	lib/promscrape/discovery/dockerswarm: properly set __meta_dockerswarm_container_label_* labels instead of __meta_dockerswarm_task_label_* labels ... See https://github.com/prometheus/prometheus/issues/9187	2022-08-05 16:11:28 +03:00
Aliaksandr Valialkin	68de1f4e4a	lib/promscrape/discovery/consul: allow stale responses from Consul service discovery by default ... This aligns with Prometheus behaviour. See `allow_stale` option description at https://prometheus.io/docs/prometheus/latest/configuration/configuration/#consul_sd_config	2022-08-05 14:41:40 +03:00
Aliaksandr Valialkin	02de848c88	lib/promscrape/discovery/yandexcloud: further code cleanup after 83a4abda3f	2022-08-05 10:30:47 +03:00
Aliaksandr Valialkin	83a4abda3f	lib/promscrape/discovery/yandexcloud: follow-up after 6e5ac32fba ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1386	2022-08-04 22:26:43 +03:00
Igor Tiunov	6e5ac32fba	YC service discovery (#2923) ... * YC service discovery https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1386 * Fixed linter suggestions * fixed golint errors	2022-08-04 20:44:16 +03:00
Aliaksandr Valialkin	d5df08e9c2	lib/mergeset: cleanup after de6dd1cd5a ... Remove unused getInmemoryPart and putInmemoryPart functions Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2249	2022-08-04 18:23:01 +03:00
Aliaksandr Valialkin	7c99b9eaad	lib/backup/actions: rename removeLockFile -> removeRestoreLock to have consistent naming with createRestoreLock function	2022-08-04 17:42:43 +03:00
Aliaksandr Valialkin	6b0550c023	app/{vmselect,vmalert}: properly generate http redirects if -http.pathPrefix command-line flag is set ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2918	2022-08-02 12:59:07 +03:00
Aliaksandr Valialkin	5a4c58f9a2	lib/storage: explain why the GetOrCreateTSIDByName function doesnt check whether the per-day entry for the given date exists if TSID is found in global index	2022-08-02 09:12:29 +03:00
Aliaksandr Valialkin	78520f2702	lib/storage: do not compress small number of tsids when storing them in tagFiltersCache ... This speeds up tsids retreival from the cache for 0-2 tsids	2022-07-30 00:08:51 +03:00
Aliaksandr Valialkin	de6dd1cd5a	lib/mergeset: optimize mergeInmemoryBlocks() function ... Do not spend CPU time on converting inmemoryBlock structs to inmemoryPart structs. Just merge inmemoryBlock structs directly. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2249	2022-07-27 23:58:05 +03:00
Aliaksandr Valialkin	a3f5822dc2	lib/mergeset: do not update blockStreamReader.bh.firstItem during the merge ... Just read the current item directly from blockStreamReader.Block.Items with the helper method - blockStreamReader.CurrItem()	2022-07-27 23:05:02 +03:00
Aliaksandr Valialkin	be1c82beb1	benchmark inmemoryBlock.{Marshal,Unmarshal} for different prefix length ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2254 This is needed for https://github.com/VictoriaMetrics/VictoriaMetrics/pull/2913	2022-07-27 22:20:27 +03:00
Aliaksandr Valialkin	5c84f09762	lib/mergeset: add tests and benchmarks for commonPrefixLen function ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2254 This is needed for https://github.com/VictoriaMetrics/VictoriaMetrics/pull/2913	2022-07-27 21:24:51 +03:00
Aliaksandr Valialkin	f5676123cc	lib/pushmetrics: make fmt	2022-07-26 20:40:19 +03:00
Aliaksandr Valialkin	da11056d85	all: rename -pushmetrics.extraLabels to -pushmetrics.extraLabel for the sake of consistency	2022-07-26 19:24:24 +03:00
Aliaksandr Valialkin	ad6b3cd47d	lib/pushmetrics: properly handle errors when initializing pushmetrics	2022-07-22 13:36:06 +03:00
Aliaksandr Valialkin	4c2f9a1a2e	lib/promscrape: set up=0 for partially failed scrape in stream parsing mode ... This behaviour aligns with Prometheus behavior	2022-07-22 13:29:44 +03:00
Roman Khavronenko	2914ce5ca5	vmalert: remove dependency on datasource pkg from config (#2905) ... * vmalert: remove dependency on datasource pkg from config Signed-off-by: hagen1778 <roman@victoriametrics.com>	2022-07-22 10:44:55 +02:00
Aliaksandr Valialkin	4ce5875fa8	all: add ability to push internal metrics to remote storage system specified via -pushmetrics.url	2022-07-21 20:36:27 +03:00
Roman Khavronenko	88edb3f6cf	vmalert: allow configuring custom headers per group (#2901) ... See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2860 Signed-off-by: hagen1778 <roman@victoriametrics.com>	2022-07-21 15:59:55 +02:00
Aliaksandr Valialkin	0fd86e2364	lib/promscrape: reload all the scrape configs when the global section is changed inside -promscrape.config ... See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2884	2022-07-18 17:15:07 +03:00
Boris Petersen	2f9668eba5	fix assume role when running in ECS. (#2876) ... This fixes #2875 Signed-off-by: Boris Petersen <boris.petersen@idealo.de>	2022-07-18 12:33:52 +03:00
Aliaksandr Valialkin	814bb1685f	all: fix other typos in the same way as 6f4d9b2a48 does	2022-07-18 12:08:15 +03:00
zhenyuxie	f3ea7823f3	fix inmemoryBlock's Less method (#2881)	2022-07-18 11:56:17 +03:00
Nikolay	7301aa678c	lib/promscrape: adds azure service discovery (#2743) ... * lib/promscrape: adds azure service discovery Adds azure service discovery mechanism implements authorization with oauth and msi lists virtual machines and virtual machines managed by scaleSet https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1364 * makes linter happy * Apply suggestions from code review Co-authored-by: Roman Khavronenko <roman@victoriametrics.com> * wip Co-authored-by: Roman Khavronenko <roman@victoriametrics.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-07-13 23:43:18 +03:00
guidao	91faa152a5	add next retention metric (#2863) ... Co-authored-by: wangfeng <wangfeng@zhihu.com>	2022-07-13 12:37:04 +03:00
Dmytro Kozlov	306ec10c39	lib/mergeset: fix linter error (#2864)	2022-07-13 12:31:35 +03:00
Aliaksandr Valialkin	17b5ac1608	lib/mergeset: optimize merge speed a bit ... Use heap.Fix instead of heap.Pop + heap.Push when merging blocks	2022-07-12 12:50:26 +03:00
Aliaksandr Valialkin	5c8eee26bf	all: make fmt via the upcoming Go1.19	2022-07-11 19:22:15 +03:00
Aliaksandr Valialkin	f97355d9fb	lib/promscrape: properly set Host header when sending requests via http proxy ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2794	2022-07-07 02:27:52 +03:00
Aliaksandr Valialkin	10cb67adb5	app/{vmagent,vminsert}: follow-up after d19e46de55 ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/2839	2022-07-07 01:30:58 +03:00
Aliaksandr Valialkin	01f55bc66b	lib/promscrape/discovery/kubernetes: properly populate service-level labels for role: endpointslice targets ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2823	2022-07-07 00:32:26 +03:00
Aliaksandr Valialkin	b186b63e07	lib/promscrape/discovery/kubernetes: allow attaching node-level labels to role: endpoints and role: endpointlice targets in the same way as Prometheus does ... See https://github.com/prometheus/prometheus/pull/10759	2022-07-06 23:18:59 +03:00
Aliaksandr Valialkin	e6ba2af7a1	lib/promscrape: fix a test after c66f676f3b	2022-07-06 13:26:35 +03:00
Aliaksandr Valialkin	c66f676f3b	lib/promscrape: push scrape_samples_limit metric to remote storage if sample_limit option is set in scrape_config for this target ... See https://github.com/VictoriaMetrics/operator/issues/497	2022-07-06 12:37:55 +03:00
Aliaksandr Valialkin	77cbbacfdb	lib/vmselectapi: pass storage.SearchQuery to API calls instead of []*storage.TagFilters + storage.TimeRange + maxMetrics ... This reduces the number of args to vmselectapi calls	2022-07-06 12:37:54 +03:00
Aliaksandr Valialkin	e1b8059086	lib/vmselectapi: rename deleteMetrics to more correct deleteSeries	2022-07-06 12:37:54 +03:00
Aliaksandr Valialkin	a60e03b3a7	lib/vmselectapi: use string type for tagKey and tagValuePrefix args at TagValueSuffixes() ... This improves the API consistency	2022-07-06 12:37:53 +03:00
Aliaksandr Valialkin	edc76286ac	lib/storage: put the (date, metricID) entry in dateMetricIDCache just after the corresponding series is registered in the per-day inverted index ... Previously the time series could be put into dateMetricIDCache without registering in the per-day inverted index if GetOrCreateTSIDByName finds TSID entry in the global index. This could lead to missing series in query results. The issue has been introduced in the commit 55e7afae3a, which has been included in VictoriaMetrics v1.78.0	2022-07-05 14:54:03 +03:00
Aliaksandr Valialkin	855436efd2	lib/promauth: refactor NewConfig in order to improve maintainability ... 1. Split NewConfig into smaller functions 2. Introduce Options struct for simplifying construction of the Config with various options This commit is based on https://github.com/VictoriaMetrics/VictoriaMetrics/pull/2684	2022-07-04 14:31:12 +03:00
Aliaksandr Valialkin	c392d6d173	app/vmagent/remotewrite: add -remoteWrite.header command-line flag for setting additional http headers to send to -remoteWrite.url ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2805	2022-06-30 20:00:23 +03:00
Aliaksandr Valialkin	e40b40afe6	Revert "lib/promscrape, vmagent: fix path to files (#2801)" ... This reverts commit 0a8e35835c. Reason for revert: it incorrectly fixes the https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2799 See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2799#issuecomment-1171392005	2022-06-30 18:23:56 +03:00
Aliaksandr Valialkin	3e2dd85f7d	all: readability improvements for query traces ... - show dates in human-readable format, e.g. 2022-05-07, instead of a numeric value - limit the maximum length of queries and filters shown in trace messages	2022-06-30 18:20:33 +03:00
Dmytro Kozlov	0a8e35835c	lib/promscrape, vmagent: fix path to files (#2801) ... vmagent: respect `-pathPrefix` flag for static files and links	2022-06-30 16:22:54 +02:00
ttyv	bdf9f4669a	lib/promscrape: fix vmagent tickerCh reload behaviour (#2786) ... Co-authored-by: Dmitriy <dab@ttyv.ru>	2022-06-30 12:33:01 +02:00
Aliaksandr Valialkin	a350d1e81c	lib/storage: return marshaled metric names from SearchMetricNames ... Previously SearchMetricNames was returning unmarshaled metric names. This wasn't great for vmstorage, which should spend additional CPU time for marshaling the metric names before sending them to vmselect. While at it, remove possible duplicate metric names, which could occur when multiple samples for new time series are ingested via concurrent requests. Also sort the metric names before returning them to the client. This simplifies debugging of the returned metric names across repeated requests to /api/v1/series	2022-06-28 18:17:15 +03:00
Aliaksandr Valialkin	2c836bd398	lib/storage: put into query trace the number of found entries in SearchMetricNames	2022-06-28 14:50:53 +03:00
Aliaksandr Valialkin	e578549b8a	app/vmselect: optimize /api/v1/series a bit for time ranges smaller than one day	2022-06-28 13:02:47 +03:00
Aliaksandr Valialkin	a963b2a0aa	all: show timeRange in traces in human-readable format instead of timestamps in milliseconds	2022-06-27 13:45:51 +03:00
Aliaksandr Valialkin	ba514284f1	lib/storage: add querytracer to more contexts ... querytracer has been added to the following storage.Storage methods: - RegisterMetricNames - DeleteMetrics - SearchTagValueSuffixes - SearchGraphitePaths	2022-06-27 13:45:51 +03:00
Aliaksandr Valialkin	134751e43e	all: locate throttled loggers via logger.WithThrottler() only once and then use them ... This reduces the contention on logThrottlerRegistryMu mutex when logger.WithThrottler() is called frequently from concurrent goroutines.	2022-06-27 13:45:50 +03:00
Aliaksandr Valialkin	52eadb729e	lib/promscrape: always send stale markers with the real scrape timestamp ... This guarantees that query won't return data just after the series is disappeared.	2022-06-23 11:34:18 +03:00
Aliaksandr Valialkin	1c4f67c5d2	lib/promauth: add ability to send additional http headers in requests to scrape targets ... This solves https://stackoverflow.com/questions/66032498/prometheus-scrape-metric-with-custom-header	2022-06-22 20:39:43 +03:00
Aliaksandr Valialkin	e6ed92529b	all: remove explicit "xxhash" name when importing github.com/cespare/xxhash/v2 package ... This package already has the same name, so there is no need in explicit name	2022-06-21 20:23:32 +03:00
Loki's Wager	ac411be904	BugFix part_header.go (#2763) ... https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2757 Co-authored-by: haotingyi <haotingyi@corp.netease.com>	2022-06-21 15:56:41 +03:00
Aliaksandr Valialkin	49586566a3	docs: follow-up after e4d6b750f6	2022-06-20 17:14:43 +03:00
Nikolay	e4d6b750f6	lib/httpserver: adds flagsAuthKey command-line flag (#2758) ... * lib/httpserver: adds flagsAuthKey command-line flag It protects /flags endpoint with authKey. https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2753O * Apply suggestions from code review Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-06-20 17:09:32 +03:00
Aliaksandr Valialkin	b958fc7846	lib/storage: properly take into account already registered series when -storage.maxHourlySeries or -storage.maxDailySeries limits are enabled ... The commit 5fb45173ae takes into account only newly registered series when applying cardinality limits. This means that the cardinality limit could be exceeded with already registered series. This commit returns back accounting for already registered series when applying cardinality limits.	2022-06-20 13:47:47 +03:00
Aliaksandr Valialkin	55e7afae3a	lib/storage: create per-day indexes together with global indexes when registering new time series ... Previously the creation of per-day indexes and global indexes for the newly registered time series was decoupled. Now global indexes and per-day indexes for the current day are created toghether for new time series. This should speed up registering new time series a bit.	2022-06-19 22:42:10 +03:00
Aliaksandr Valialkin	5fb45173ae	lib/storage: do not register new series if -storage.maxHourlySeries or -storage.maxDailySeries limits are exceeded ... Previously samples for new series weren't added as expected when series limits were reached, but new series were still registered in indexdb.	2022-06-19 22:42:09 +03:00
Aliaksandr Valialkin	62e2371a67	lib/storage: reset metric id caches for the previous and the current hour ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2698	2022-06-19 22:42:09 +03:00
Aliaksandr Valialkin	c18f8cccfa	lib/promrelabel: support action: graphite relabeling ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2737	2022-06-16 20:24:22 +03:00
Aliaksandr Valialkin	ec7963208d	app/vmselect: accept focusLabel query arg at /api/v1/status/tsdb ... This allows filling the seriesCountByFocusLabelValue list in the /api/v1/status/tsdb response with label values for the specified focusLabel, which contain the highest number of time series. TODO: add this to Cardinality explorer at VMUI - https://docs.victoriametrics.com/#cardinality-explorer	2022-06-14 18:36:54 +03:00
Aliaksandr Valialkin	b6c1ca12b7	lib/storage: show top labels with the highest number of series in cardinality explorer	2022-06-14 16:32:38 +03:00
Aliaksandr Valialkin	a75e59700f	lib/storage: improve error message when -search.max* command-line flag values are exceeded	2022-06-14 13:27:59 +03:00
Aliaksandr Valialkin	52cf05c6d2	lib/storage: test GetTSDBStatusWithFiltersForDate on a global time range	2022-06-12 14:27:40 +03:00
Aliaksandr Valialkin	374beb350e	app/vmselect: optimize /api/v1/labels and /api/v1/label/.../values handlers when match[] query arg is passed to them	2022-06-12 04:32:13 +03:00
Aliaksandr Valialkin	2bcb960f17	all: improve query tracing coverage for indexdb search ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1403	2022-06-09 20:07:07 +03:00
Howie	76f05f8670	feat: rule limit (#2676) ... vmalert: support `limit` param in groups definition `limit` param limits number of time series samples produced by a single rule during execution. On reaching the limit rule will return an err. Signed-off-by: lihaowei <haoweili35@gmail.com>	2022-06-09 08:21:30 +02:00
Aliaksandr Valialkin	12ac255dae	lib/querytracer: make it easier to use by passing trace context message to New and NewChild ... The context message can be extended by calling Donef. If there is no need to extend the message, then just call Done.	2022-06-08 21:06:52 +03:00
Dmytro Kozlov	018d2303c4	Cardinality explorer (#2625) ... * Cardinality explorer * vmui, vmselect: updated field name, added description to spinner * make vmui-update * updated const name, make vmui-update * lib/storage: changes calculation for totalSeries values * added static files * wip * wip * wip * wip * docs/CHANGELOG.md: document cardinality explorer feature See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2233 Co-authored-by: f41gh7 <nik@victoriametrics.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-06-08 18:43:05 +03:00
Roman Khavronenko	63b538ecd1	vmagent: update SD duration histogram metric if SD is active (#2677) ... The change updates histogram for registering SD update duration only SD is considered as `active`. SD is active if at least one scraper for this SD has started. This change supposed to reduce metrics cardinality produced by duration histogram which gets updated even if SD isn't configured. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2671 Signed-off-by: hagen1778 <roman@victoriametrics.com>	2022-06-07 15:46:44 +03:00
Roman Khavronenko	1ee1e986da	lib/storage: limit max mergeConcurrency value for systems with high number of CPUs (#2673) ... Workers count for merges affects the max part size during merges. Such behaviour protects storage from running out of disk space for scenario when all workers are merging parts with the max size. This works very well for most cases. But for systems where high number of CPUs is allocated for vmstorage components this could significantly impact the max part size and result in more unmerged parts than expected. While checking multiple production highly loaded setups it was discovered that `max_over_time(vm_active_merges{type="storage/big}[1h]}"` rarely exceeds 2, and `max_over_time(vm_active_merges{type="storage/small}[1h]}"` rarely exceeds 4. The change in this commit limits the max value for concurrency accordingly. Signed-off-by: hagen1778 <roman@victoriametrics.com>	2022-06-07 14:55:09 +03:00
Aliaksandr Valialkin	a5814fe16a	lib/promscrape/discovery/kubernetes: use unsupportedFieldError() function instead of errContext string ... This improves code readability and maintainability a bit, since the format string is passed as string literal into fmt.Errorf.	2022-06-07 01:22:07 +03:00
Aliaksandr Valialkin	8608dd093c	all: follow-up after 8edb390e21 ... - Remove unused js bloatware from /targets page. This strips down binary size by more than 100Kb - Add /service-discovery page for API compatibility with Prometheus - Properly load bootstrap.min.css from /prometheus/targets - Serve static contents for /targets page from app/vminsert instead of app/vmselect, because /targets page is served from there	2022-06-07 00:57:09 +03:00