147 commits

Author	SHA1	Message	Date
Aliaksandr Valialkin	ae6c7edf04	app/vmselect: do not export NaN values for stale metrics at /federate endpoint ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3185	2022-10-01 19:48:21 +03:00
Aliaksandr Valialkin	6f9ce3f6d6	lib/flagutil: rename Array to ArrayString ... This makes the ArrayString more consistent with other Array* types. While at it, add ArrayBytes type, which will be used for https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3071	2022-10-01 18:28:19 +03:00
Dmytro Kozlov	96ecec877d	vmselect/{promql, prometheus}: show flag names which user can update in error message (#3049) ... * vmselect/{promql, prometheus}: show flag names which user can update in error message * vmselect/{promql, prometheus}: fix typo	2022-09-06 14:48:20 +03:00
Aliaksandr Valialkin	b7f3569522	app/vmselect/prometheus: follow-up after 50e2524bc2 ... - Add getCommonParamsWithDefaultDuration function and use it at /api/v1/series, /api/v1/labels and /api/v1/label/.../values - Document the default behaviour for setting 5 minutes time range if start arg isn't passed to /api/v1/series, /api/v1/labels and /api/v1/label/.../values - Document the change at docs/CHANGELOG.md Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/3052	2022-09-05 11:57:08 +03:00
匠心零度	65d1124dc4	api prometheus/api/v1/label/../values time not specified, (#3052) ... modify default start values	2022-09-05 11:51:32 +03:00
匠心零度	80067fd03a	reduce unnecessary vmstorage query (#3031) ... * reduce unnecessary vmstorage query * reduce unnecessary vmstorage query * rollback limit logic /api/v1/label/*	2022-08-30 12:34:23 +03:00
Dmytro Kozlov	d32a6359b0	vmselect/promql: enable search.maxPointsSubqueryPerTimeseries for sub-queries (#2963) ... * vmselect/promql: enable search.maxPointsPerTimeSeriesSubquery for sub-queries * vmselect/promql: cleanup * vmselect/promql: rename config flag * vmselect/promql: add tests * vmselect/promql: use test object instead of log * vmselect/promql: fix posible panic is subquery has more points. add description * vmselect/promql: update tests descriptions * vmselect/promql: update doInternal validation * vmselect/promql: fix linter * vmselect/promql: fix linter * vmselect/promql: update documentation and release notes * wip - Properly apply -search.maxPointsSubqueryPerTimeseries limit to subqueries. Previously the -search.maxPointsPerTimeseries limit was unexpectedly applied to subqueries if it was smaller than the -search.maxPointsSubqueryPerTimeseries . - Clarify docs for -search.maxPointsSubqueryPerTimeseries command-line flag . - Document -search.maxPointsPerTimeseries and -search.maxPointsSubqueryPerTimeseries flags at https://docs.victoriametrics.com/#resource-usage-limits . - Update docs/CHANGELOG.md . Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2922 Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-08-24 15:27:41 +03:00
Roman Khavronenko	8a26ec435d	vmselect: introduce UserReadableError type of error (#2894) ... When read query fails, VM returns rich error message with all the details. While these details might be useful for debugging specific cases, they're usually too verbose for users. Introducing a new error type `UserReadableError` is supposed to allow to return to user only the most important parts of the error trace. This supposed to improve error readability in web interfaces such as VMUI or Grafana. The full error trace is still logged with the full context and can be found in vmselect logs. Signed-off-by: hagen1778 <roman@victoriametrics.com> Signed-off-by: hagen1778 <roman@victoriametrics.com>	2022-08-15 13:53:18 +03:00
Dmytro Kozlov	6734d77d97	vmselect/prometeus: Add limit param to api/v1/series api endpoint (#2851) ... * issue-2841: Add limit param to api/v1/series api endpoint * issue-2841: add change log * issue-2841: update logic * issue-2841: simplify logic * issue-2841: simplify logic, add information to documentation	2022-07-11 20:37:20 +03:00
Aliaksandr Valialkin	eab8ebbe11	all: make fmt via the upcoming Go1.19	2022-07-11 19:23:25 +03:00
Aliaksandr Valialkin	cdd89d9cc2	app/vmselect: properly generate response for /api/v1/series ... The response has been broken in 7d5d33fd71	2022-07-06 12:46:23 +03:00
Aliaksandr Valialkin	f4df43f7cc	app/vmselect/netstorage: remove unused auth.Token arg	2022-07-06 12:46:21 +03:00
Aliaksandr Valialkin	c21f5a508f	app/vmselect/prometheus: reduce the default value for -search.maxSeries from 100k to 30k ... Production experience shows that 100k is too big for /api/v1/series . It leads to increased CPU usage when Grafana queries /api/v1/series over VictoriaMetrics with big number of time series during auto-completion and when modifying template variables.	2022-06-28 18:22:24 +03:00
Aliaksandr Valialkin	7d5d33fd71	lib/storage: return marshaled metric names from SearchMetricNames ... Previously SearchMetricNames was returning unmarshaled metric names. This wasn't great for vmstorage, which should spend additional CPU time for marshaling the metric names before sending them to vmselect. While at it, remove possible duplicate metric names, which could occur when multiple samples for new time series are ingested via concurrent requests. Also sort the metric names before returning them to the client. This simplifies debugging of the returned metric names across repeated requests to /api/v1/series	2022-06-28 18:16:32 +03:00
Aliaksandr Valialkin	399d4c36ae	app/vmselect: optimize /api/v1/series a bit for time ranges smaller than one day	2022-06-28 12:55:20 +03:00
Aliaksandr Valialkin	bc9d704ef4	app/vmselect/netstorage: remove Get prefix from netstorage functions ... This makes these function names more consistent with the server side	2022-06-27 00:37:49 +03:00
Aliaksandr Valialkin	7429dfbe9e	app/vmselect: add -search.setLookbackToStep command-line flag for making the gap filling algorithm similar to InfluxDB data model ... This option should override `-search.maxStalenessInterval` for most cases when users migrate from InfluxDB to VictoriaMetrics	2022-06-22 14:20:02 +03:00
Roman Khavronenko	cbe39bbb8d	vmselect: limit end param max value by 2d in future (#2729) ... * vmselect: limit `end` param max value by 2d in future The change is applied only to service handlers like `/labels` or `/series` and limits the `end` param by max value <= now() + 2 days. The same limit is applied for the ingested data, so no reason to allow to request data in future far than that. The change is also needed for corner cases like https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2669 where too high `end` value triggers inefficient global index search. Signed-off-by: hagen1778 <roman@victoriametrics.com> * docs/CHANGELOG.md: document the bugfix Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-06-16 20:51:40 +03:00
Aliaksandr Valialkin	45fa9d798d	app/vmselect: accept focusLabel query arg at /api/v1/status/tsdb	2022-06-14 18:39:00 +03:00
Aliaksandr Valialkin	fb77843639	lib/storage: show top labels with the highest number of series in cardinality explorer	2022-06-14 16:34:13 +03:00
Aliaksandr Valialkin	61e03f172b	app/vmselect: optimize /api/v1/labels and /api/v1/label/.../values handlers when match[] query arg is passed to them	2022-06-12 14:06:24 +03:00
Aliaksandr Valialkin	4a94cd81ce	app/vmselect: add optional limit query arg to /api/v1/labels and /api/v1/label_values endpoints ... This arg allows limiting the number of sample values returned from these APIs	2022-06-10 10:24:07 +03:00
Aliaksandr Valialkin	1335698ba7	app/vmselect/prometheus: extract common code for obtaining common query args into getCommonParams() function	2022-06-09 20:33:36 +03:00
Aliaksandr Valialkin	cb39eada77	all: improve query tracing coverage for indexdb search ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1403	2022-06-09 20:04:02 +03:00
Aliaksandr Valialkin	7fe60dad10	app/vmselect: remove redundant calls to Request.ParseForm() ... Request.ParseForm() is implicitly called by the first call to Request.FormValue()	2022-06-09 13:09:52 +03:00
Aliaksandr Valialkin	a9ea3fee38	lib/querytracer: make it easier to use by passing trace context message to New and NewChild ... The context message can be extended by calling Donef. If there is no need to extend the message, then just call Done.	2022-06-08 21:16:12 +03:00
Dmytro Kozlov	f2754c3e90	Cardinality explorer (#2625) ... * Cardinality explorer * vmui, vmselect: updated field name, added description to spinner * make vmui-update * updated const name, make vmui-update * lib/storage: changes calculation for totalSeries values * added static files * wip * wip * wip * wip * docs/CHANGELOG.md: document cardinality explorer feature See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2233 Co-authored-by: f41gh7 <nik@victoriametrics.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-06-08 18:54:27 +03:00
Aliaksandr Valialkin	afced37c0b	all: add initial support for query tracing ... See https://docs.victoriametrics.com/Single-server-VictoriaMetrics.html#query-tracing Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1403	2022-06-01 02:31:44 +03:00
Dima Lazerka	b5fce4190c	Code cleanup (#343) ... * Small code cleanup: remove Request from params * Extract common params to all export handlers * Renamed ExportParams -> exportParams * wip Co-authored-by: Dzmitry Lazerka <dlazerka@gmail.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-05-03 15:53:58 +03:00
Aliaksandr Valialkin	4fa3cd701c	docs/Cluster-VictoriaMetrics.md: typo fix: serparated -> separated	2022-05-03 15:20:11 +03:00
Dima Lazerka	e6ee235707	Export "null" in jsonl instead of NaN (#2518) ... * Export "null" in jsonl instead of NaN The NaN appeared because of staleness markers that were added for compatibility. I think it's better to use json `null`, implemented here. Also maybe it also makes sense to add a flag like `?skip-staleness-markers=true` to `/export`, to skip nulls at all? * Update app/vmselect/prometheus/export.qtpl * app/vmselect/prometheus/export.qtpl.go: `make quicktemplate-gen` * docs/CHANGELOG.md: document the change Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-04-29 12:51:03 +03:00
Aliaksandr Valialkin	b843f0e229	app/vmselect: add fine-grained limits for the number of returned/scanned time series for various APIs	2022-03-26 11:28:14 +02:00
Aliaksandr Valialkin	c2b0a6109b	app/vmselect/prometheus: typo fix after bf0e3ad2171219b7883b149999c4dc0ac15b9797	2021-12-17 11:52:42 +02:00
Aliaksandr Valialkin	d9f075622b	app/vmselect: de-duplicate data exported via /api/v1/export/csv by default ... Previously the exported data wasn't de-duplicated. Now it is possible to export the raw data without deduplication by passing reduce_mem_usage=1 query arg to /api/v1/export/csv See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1837	2021-12-17 11:52:42 +02:00
Aliaksandr Valialkin	54d4a1c959	app/vmselect: accept optional extra_filters[] query args for all the supported Prometheus querying APIs ... See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1863	2021-12-06 17:33:49 +02:00
Aliaksandr Valialkin	4fb19fe34b	all: consistently return application/json content-type without charset=utf-8 ... The `application/json` content-type has utf-8 encoding by default. See https://stackoverflow.com/questions/9254891/what-does-content-type-application-json-charset-utf-8-really-mean Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/897	2021-11-09 18:07:22 +02:00
Aliaksandr Valialkin	a4eaf1a0a1	app/vmselect/prometheus: make more clear log messages for errors during sending data to remote clients	2021-09-16 13:35:37 +03:00
Aliaksandr Valialkin	7ad54041fe	app/{vminsert,vmselect}: automatically add missing port in -storageNode lists passed to vminsert and vmselect ... This should simplify manual setup of the cluster according to https://docs.victoriametrics.com/Cluster-VictoriaMetrics.html#cluster-setup	2021-09-15 18:04:30 +03:00
Roman Khavronenko	1ccb77904b	vmselect: update vm_request_duration_seconds value when request fails (#1537) ... Before, metric `vm_request_duration_seconds` was update only on successful attempts which could be misleading. For example, timeout errors on netstorage request may be not accounted in the metric and won't be visible on dashboards. Using `defer` statement to update the metric after query arguments validation may improve the situation.	2021-08-19 14:07:00 +03:00
Aliaksandr Valialkin	9add9d86a6	app/vmselect/promql: duration handling improvements in MetricsQL queries ... - Support durations anywhere in MetricsQL queries. E.g. sum_over_time(m[1h])/1h is equivalent to sum_over_time(m[1h])/3600 - Support durations without suffix. E.g. rate(m[300]) is equivalent to rate(m[5m])	2021-07-12 17:19:32 +03:00
John Belmonte	3e79f3994e	spelling fix: synonym (#1363)	2021-06-11 10:58:48 +03:00
Nikolay	be87be34a4	Adds tsdb match filters (#1282) ... * init work on filters * init propose for status filters * fixes tsdb status adds test * fix bug * removes checks from test	2021-05-12 17:16:58 +03:00
Aliaksandr Valialkin	6dc5d3b357	all: rename https://victoriametrics.github.io to https://docs.victoriametrics.com	2021-04-20 20:20:01 +03:00
Aliaksandr Valialkin	d8c769e6af	app/vmselect: add -search.maxStatusRequestDuration command-line flag for limiting the duration of requests to /api/v1/status/* and /api/v1/series/count	2021-03-30 21:39:32 +03:00
Aliaksandr Valialkin	698ccca6ad	app/vmselect/prometheus: explain why partial responses are disallowed during data export ... See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1148	2021-03-25 18:39:07 +02:00
Aliaksandr Valialkin	27bb614016	app/vmselect: move getEnforcedTagFiltersFromRequest to searchtuils, since it will be used in Graphite functions soon	2021-03-23 14:57:57 +02:00
Aliaksandr Valialkin	6b9bba7448	app/vmselect: add round_digits query arg to /api/v1/query and /api/v1/query_range handlers for limiting the number of decimal digits after the point	2021-03-15 12:38:59 +02:00
Aliaksandr Valialkin	b6dcb37fca	app/vmselect/prometheus: do not include datapoints with timestamps matching t-d when returning results from /api/v1/query?query=m[d]&time=t as Prometheus does	2021-03-12 12:18:37 +02:00
Aliaksandr Valialkin	ee4288987b	app/vmselect/prometheus: treat match query arg in the same way as match[] query arg	2021-02-11 15:01:55 +02:00
Aliaksandr Valialkin	4b930b9ffe	app/vmselect: add ability to set Graphite-compatible filter via {__graphite__="foo.*.bar"} syntax	2021-02-03 01:17:19 +02:00