2396 commits

Author	SHA1	Message	Date
Aliaksandr Valialkin	cb3cbdbac8	docs/CHANGELOG.md: cut v1.87.12 release	2023-12-10 13:46:31 +02:00
Aliaksandr Valialkin	6234d1b64d	deployment/docker: update base Docker image from alpine:3.18.5 to alpine:3.19.0 ... See https://www.alpinelinux.org/posts/Alpine-3.19.0-released.html	2023-12-10 02:30:17 +02:00
Roman Khavronenko	f0099c4db7	app/vmalert: sanitize label names before sending to Alertmanager (#5442) ... Before, vmalert would send notifications with labels containing characters not supported by Alertmanager validator, resulting into validation errors like `msg="Failed to validate alerts" err="invalid label set: invalid name "foo.bar"` Signed-off-by: hagen1778 <roman@victoriametrics.com>	2023-12-08 18:12:42 +02:00
Aliaksandr Valialkin	ae38a4db97	app/vmselect/prometheus: properly encode Prometheus label values at /federate endpoint ... Prometheus spec says that only \, \n and " must be escaped inside label values. See 995743836e/content/docs/instrumenting/exposition_formats.md (L90) See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5431	2023-12-07 16:13:59 +02:00
Aliaksandr Valialkin	4f82bde65a	deployment/docker: update Go builder from Go1.21.4 to Go1.21.5 ... See https://github.com/golang/go/issues?q=milestone%3AGo1.21.5+label%3ACherryPickApproved	2023-12-07 00:16:26 +02:00
Aliaksandr Valialkin	81d24dcf1f	deployment/docker: update backe Docker image from alpine 3.18.4 to 3.18.5 ... See https://www.alpinelinux.org/posts/Alpine-3.15.11-3.16.8-3.17.6-3.18.5-released.html	2023-12-03 18:58:31 +02:00
Aliaksandr Valialkin	1c536ee7d3	docs/CHANGELOG.md: cut v1.87.11 LTS release	2023-11-14 21:56:01 +01:00
Nikolay	a6fb5519d2	lib/querytracer: makes package concurrent safe to use (#5322) ... * lib/querytracer: makes package concurrent safe to use it must fix various issues with concurrent code usage. Especially, when it's not reasonable to wait for all goroutines to be finished * wip --------- Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2023-11-14 21:01:53 +01:00
Aliaksandr Valialkin	25877ddc03	deployment: update Go builder from Go1.21.3 to Go1.21.4 ... See https://github.com/golang/go/issues?q=milestone%3AGo1.21.4+label%3ACherryPickApproved	2023-11-13 18:32:06 +01:00
Aliaksandr Valialkin	2b3235414b	lib/regexutil: properly handle alternate regexps surrounded by .+ or .* ... Previously the following regexps were improperly handled: .+foo|bar.+ .*foo|bar.* This could lead to unexpected regexp match results. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5297 Thanks to @Haleygo for the initial attempt to fix the issue at https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5308	2023-11-13 18:29:42 +01:00
Roman Khavronenko	d550a2d85a	lib/storage: log warning about RO mode only on state change (#5191) ... Before, vmstorage would log the same message each second producing excessive amount of logs. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5159 Signed-off-by: hagen1778 <roman@victoriametrics.com>	2023-10-31 16:30:39 +01:00
Aliaksandr Valialkin	9407c0f038	docs/CHANGELOG.md: cut v1.87.10	2023-10-16 22:23:14 +02:00
Aliaksandr Valialkin	950edad2e3	deployment/docker: update Go builder from Go1.21.1 to Go1.21.3 ... See https://github.com/golang/go/issues?q=milestone%3AGo1.21.2+label%3ACherryPickApproved and https://github.com/golang/go/issues?q=milestone%3AGo1.21.3+label%3ACherryPickApproved	2023-10-15 18:58:02 +02:00
Aliaksandr Valialkin	24e178e910	docs/CHANGELOG.md: remove duplicate line after 14471496fe	2023-10-02 22:17:14 +02:00
Dmytro Kozlov	d8748a3398	app/vmagent: fix check of the DataDog agent path requests when requests have trailing slashes (#5106) ... * app/vmagent: fix check of the DataDog agent path requests when requests have trailing slashes * app/vmagent: fix CHANGELOG.md description * wip * wip --------- Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2023-10-02 21:22:39 +02:00
Aliaksandr Valialkin	d55ca23837	app/vmagent: follow-up for cfef814750 ... - Properly handle /insert/multitenant/api/put url for opentsdb handler at vmagent - Document that the bug has been introduced in v1.93.2 at docs/CHANGELOG.md - Add a link to multitenant url docs in bugfix description Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5061 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4910	2023-10-01 21:06:47 +02:00
Alexander Marshalov	d8cd6edd55	fixed ingestion via multitenant url for opentsdbhttp (#5061) (#5063)	2023-10-01 21:05:47 +02:00
Aliaksandr Valialkin	f5a1dc2015	docs/CHANGELOG.md: clarify the description of bugfixes at f7dda12b4d and b6ad581b45 ... This is a follow-up for 8b01bc4a5c Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/4999 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5009	2023-09-19 00:50:22 +02:00
Nikolay	14c874e840	docs: reflect recent changes at change logs (#5015)	2023-09-19 00:34:30 +02:00
Aliaksandr Valialkin	ba7892d1de	docs/CHANGELOG.md: cut v1.87.9	2023-09-10 20:40:05 +02:00
Aliaksandr Valialkin	f719fcb0b6	docs/CHANGELOG.md: fix the release where the issue has been introduced	2023-09-09 06:14:50 +02:00
Roman Khavronenko	ada9afc74c	vmalert: correctly add duplicated params to the query (#4955) ... Fix the bug when Group's `params` fields with multiple values were overriding each other instead of adding up. The bug was introduced in this commit eccecdf177 starting from v1.91.1 https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.91.1 https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4908 Signed-off-by: hagen1778 <roman@victoriametrics.com> (cherry picked from commit 6351d07da8)	2023-09-08 09:37:54 +02:00
Aliaksandr Valialkin	8ff9235717	app/vmselect: return 503 status code when partial responses are denied and some of vmstorage nodes are temporarily unavailable ... This should help detecting this case and automatic retrying the query at healthy cluster replica in another availability zone. This commit is needed as a preparation for automatic query retry at another backend at vmauth on 5xx errors as described at https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4792#issuecomment-1674338561	2023-09-07 16:17:14 +02:00
Aliaksandr Valialkin	841465d98a	all: update Go builder from Go1.21.0 to Go1.21.1 ... See https://github.com/golang/go/issues?q=milestone%3AGo1.21.1+label%3ACherryPickApproved	2023-09-07 11:42:57 +02:00
Aliaksandr Valialkin	fe63176d4c	docs/CHANGELOG.md: clarify the scope of recent bugfixes	2023-09-07 11:29:03 +02:00
Aliaksandr Valialkin	3ac6f89559	deployment/docker: properly build armv5 production builds for GOARCH=arm ... Pass GOARM=5 when building GOARCH=arm production builds, since the default value for this env var has been changed to GOARM=6 since Go1.21.0. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4965 and https://github.com/golang/go/issues/62475	2023-09-07 11:29:03 +02:00
Aliaksandr Valialkin	d651f70c96	docs/CHANGELOG.md: document the bugfix at 7db72dd7e6 ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4947	2023-09-06 12:13:14 +02:00
Nikolay	e97484640a	lib/vmselectapi: do not send empty label names for labelNames request (#4936) ... * lib/vmselectapi: do not send empty label names for labelNames request it breaks cluster communication, since vmselect incorrectly reads request buffer, leaving unread data on it https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4932 * typo fix * wip --------- Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2023-09-01 23:30:23 +02:00
Aliaksandr Valialkin	f8105cebc9	docs/CHANGELOG.md: move the bugfix description for 1f66d5624d to proper place	2023-09-01 18:06:40 +02:00
Nikolay	561dd2900a	app/vminsert: properly close vmstorage connection (#4935) ... * app/vminsert: properly close vmstorage connection previously vmstorage may stuck in broken state until vminsert restarts since vmstorage was marked as read-only and connection was broken to it. checkReadonly function never marked connection as broken https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4870 * wip --------- Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2023-09-01 18:03:53 +02:00
Aliaksandr Valialkin	d34ffb8f98	docs/CHANGELOG.md: cut v1.87.8	2023-09-01 12:07:35 +02:00
Nikolay	ab4c3817ed	app/vminsert: fixes readonly check (#4892) ... * app/vminsert: fixes readonly check previously vminsert doesn't check readOnly state for vmstorage, since check was never performed for nil buffer In this case every 30 second storage node loss readonly state and received some data. It caused re-routing and possible slow down for ingestion https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4870 * wip --------- Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2023-08-30 16:27:23 +02:00
Zakhar Bessarab	30c869dfc4	app/vmselect: fix panic when using /select/multitenant endpoint (#4912) ... app/vmselect: fix panic when using `/select/multitenant` endpoint Such requests must be rejected as not found since vmselect does not support multitenant endpoint. See: https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4910 Signed-off-by: Zakhar Bessarab <z.bessarab@victoriametrics.com>	2023-08-30 15:24:29 +02:00
Nikolay	0e9dea42a4	deployment/docker: disable provenance in buildx (#4911) ... * deployment/docker: disable provenance in buildx it must fix an issue with multi-platform manifest generation at buildx >= 0.10 backward compatibility was broken and generated image cannot be used with docker systems that doesn't support oci. disabling attestat temporary fixes it. https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4907 https://docs.docker.com/build/attestations/slsa-provenance/ * Update docs/CHANGELOG.md --------- Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2023-08-30 15:23:01 +02:00
Aliaksandr Valialkin	a5df1e2525	lib/envflag: do not allow unsupported form for boolean command-line flags in the form -boolFlag value ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4845	2023-08-17 14:17:03 +02:00
Aliaksandr Valialkin	27f790458b	lib/promrelabel: properly replace : char with _ in metric names when -usePromCompatibleNaming command-line flag is set ... This addresses https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3113#issuecomment-1275077071 comment from @johnseekins	2023-08-17 13:54:59 +02:00
Roman Khavronenko	0783be0d15	vmbackup: correctly check if specified -dst belongs to specified -storageDataPath (#4841) ... See this issue https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4837 Signed-off-by: hagen1778 <roman@victoriametrics.com>	2023-08-17 13:54:17 +02:00
Aliaksandr Valialkin	a783d88886	docs/CHANGELOG.md: cut v1.87.7	2023-08-12 13:52:30 -07:00
Nikolay	119bcedf17	lib/promscrape: adds validation for proxy_url scheme (#4823) ... * lib/promscrape: adds validation for proxy_url scheme adds tests https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4811 * Update lib/proxy/proxy.go * Update lib/proxy/proxy.go --------- Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2023-08-12 13:50:37 -07:00
Aliaksandr Valialkin	3c6e0cf26b	lib/promscrape: use local scrape timestamp for scraped metrics unless honor_timestamps: true is set explicitly ... This fixes the case with gaps for metrics collected from cadvisor, which exports invalid timestamps, which break staleness detection at VictoriaMetrics side. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4697 , https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4697#issuecomment-1654614799 and https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4697#issuecomment-1656540535 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1773	2023-08-12 13:48:02 -07:00
Roman Khavronenko	655d64b27f	vmctl: interrupt explore procedure in influx mode if no numeric fields were found (#4576) ... Signed-off-by: hagen1778 <roman@victoriametrics.com>	2023-08-12 13:41:50 -07:00
Dmytro Kozlov	ea38e35205	app/vmctl: fix panic --remote-read-filter-time-start flag not defined (#4605) ... * app/vmctl: fix panic `--remote-read-filter-time-start` flag not defined * app/vmctl: update CHANGELOG.md --------- Co-authored-by: Nikolay <nik@victoriametrics.com>	2023-08-12 13:39:43 -07:00
Roman Khavronenko	9b83737a75	vmalert: check for negative offset for missed rounds (#4628) ... It could happen for low evaluation intervals and irregular delays during execution that evaluation time would get a negative offset. This could result into cumulative discrepancy between the actual time and evaluation time for rules. Signed-off-by: hagen1778 <roman@victoriametrics.com>	2023-08-12 13:36:13 -07:00
Haleygo	22954607ba	vmalert: fix evalTS after modify group interval (#4629)	2023-08-12 13:34:33 -07:00
Haleygo	f5a25ba980	vmselect: fix result in Prometheus query when time is small (#4578) ... vmselect: fix result in Prometheus query when time is small Co-authored-by: Roman Khavronenko <roman@victoriametrics.com>	2023-08-12 13:32:46 -07:00
Aliaksandr Valialkin	973bbd16b0	lib/promscrape/discovery: close unused HTTP connections to service discovery servers ... This should prevent from connection leaks See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4724	2023-08-12 13:30:35 -07:00
Aliaksandr Valialkin	554eb2fc28	docs/CHANGELOG.md: add a link to Pushgateway protocol in the bugfix description for 74237ce5c0 ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4692	2023-08-12 13:24:50 -07:00
Alexander Marshalov	4bbf8692c3	fixed label values decoding for pushgateway compatibility (#4727) ... Fixed decoding of label values with slash for pushgateway and prometheus golang client compatibility + added some tests. (#4962)	2023-08-12 13:23:25 -07:00
Aliaksandr Valialkin	775fbe0c30	docs/CHANGELOG.md: clarify the description of the bugfix at ce7141383d	2023-08-12 13:21:17 -07:00
Zakhar Bessarab	1a75119a92	app/vmagent/remotewrite: fix vmagent panic on shutdown (#4407) ... app/vmagent/remotewrite: fix vmagent panic on shutdown Currently, when vmagent is stopping it first flushes pending series in remote write context and proceeds to stop streaming aggregation. This leads to streaming aggregation being unable to write results into pending timeseries (since it is already nil) and panic. This can lead to losing some aggregation results being lost almost silently. The fix is reordering flow to first stop streaming aggregation and flush all pending time series after that. Signed-off-by: Zakhar Bessarab <z.bessarab@victoriametrics.com>	2023-08-12 13:20:15 -07:00