mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2025-03-11 15:34:56 +00:00
9ca74d1fff
Previously if rule group parameters were changed, alerting rules related metrics could be deleted due to bug at `utils/metrics` package. This commit introduces `metrics.Set` per rule group. It holds group and alerting rules metrics. It properly unregister alerting rules metrics and addresses issue. In addition: - expose group metrics only once group is started - this helps to avoid exposing metrics for groups which are created during YAML unmarshaling and only used to update existing group. - properly close rules which are discarded after updating existing rules so that metrics are also correctly closed. - detect file renames and properly recreate groups "moved" between files. Related issue: https://github.com/VictoriaMetrics/VictoriaMetrics/issues/8229 |
||
|---|---|---|
| .. | ||
| alerting.go | ||
| alerting_test.go | ||
| group.go | ||
| group_test.go | ||
| recording.go | ||
| recording_test.go | ||
| rule.go | ||
| rule_test.go | ||
| test_helpers.go | ||
| utils.go | ||
| utils_test.go | ||