mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2025-03-21 15:45:01 +00:00

Fix parsing of IPv6 addresses after discovery. Previously, it could lead
to target being discovered and discarded afterwards.
See: https://github.com/VictoriaMetrics/VictoriaMetrics/issues/8374
---------
Signed-off-by: Zakhar Bessarab <z.bessarab@victoriametrics.com>
(cherry picked from commit 99de272b72
)
90 lines
2.1 KiB
Go
90 lines
2.1 KiB
Go
package discoveryutils
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestJoinHostPort(t *testing.T) {
|
|
f := func(host string, port int, resultExpected string) {
|
|
t.Helper()
|
|
for i := 0; i < 5; i++ {
|
|
result := JoinHostPort(host, port)
|
|
if result != resultExpected {
|
|
t.Fatalf("unexpected result for JoinHostPort(%q, %d); got %q; want %q", host, port, result, resultExpected)
|
|
}
|
|
}
|
|
}
|
|
f("foo", 123, "foo:123")
|
|
f("1:32::43", 80, "[1:32::43]:80")
|
|
}
|
|
|
|
func TestSanitizeLabelNameSerial(t *testing.T) {
|
|
if err := testSanitizeLabelName(); err != nil {
|
|
t.Fatalf("unexpected error: %s", err)
|
|
}
|
|
}
|
|
|
|
func TestSanitizeLabelNameParallel(t *testing.T) {
|
|
goroutines := 5
|
|
ch := make(chan error, goroutines)
|
|
for i := 0; i < goroutines; i++ {
|
|
go func() {
|
|
ch <- testSanitizeLabelName()
|
|
}()
|
|
}
|
|
tch := time.After(5 * time.Second)
|
|
for i := 0; i < goroutines; i++ {
|
|
select {
|
|
case <-tch:
|
|
t.Fatalf("timeout!")
|
|
case err := <-ch:
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %s", err)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func testSanitizeLabelName() error {
|
|
f := func(name, expectedSanitizedName string) error {
|
|
for i := 0; i < 5; i++ {
|
|
sanitizedName := SanitizeLabelName(name)
|
|
if sanitizedName != expectedSanitizedName {
|
|
return fmt.Errorf("unexpected sanitized label name %q; got %q; want %q", name, sanitizedName, expectedSanitizedName)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
if err := f("", ""); err != nil {
|
|
return err
|
|
}
|
|
if err := f("foo", "foo"); err != nil {
|
|
return err
|
|
}
|
|
return f("foo-bar/baz", "foo_bar_baz")
|
|
}
|
|
|
|
func TestIsIPv6Host(t *testing.T) {
|
|
f := func(host string, isIPv6Expected bool) {
|
|
t.Helper()
|
|
isIPv6 := IsIPv6Host(host)
|
|
if isIPv6 != isIPv6Expected {
|
|
t.Fatalf("unexpected result for IsIPv6Host(%q); got %v; want %v", host, isIPv6, isIPv6Expected)
|
|
}
|
|
}
|
|
f("foo", false)
|
|
f("1:32::43", true)
|
|
}
|
|
|
|
func TestEscapeIPv6Host(t *testing.T) {
|
|
f := func(host string, escapedHostExpected string) {
|
|
t.Helper()
|
|
escapedHost := EscapeIPv6Host(host)
|
|
if escapedHost != escapedHostExpected {
|
|
t.Fatalf("unexpected result for EscapeIPv6Host(%q); got %q; want %q", host, escapedHost, escapedHostExpected)
|
|
}
|
|
}
|
|
f("1:32::43", "[1:32::43]")
|
|
}
|