mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-11-21 14:44:00 +00:00
037652d5ae
Use local timezone of the host server in this case. The timezone can be overridden with TZ environment variable if needed. While at it, allow using whitespace instead of T as a delimiter between data and time in the ingested _time field. For example, '2024-09-20 10:20:30' is now accepted during data ingestion. This is valid ISO8601 format, which is used by some log shippers, so it should be supported. This format is also known as SQL datetime format. Also assume local time zone when time without timezone information is passed to querying APIs. Previously such a time was parsed in UTC timezone. Add `Z` to the end of the time string if the old behaviour is preferred. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/6721
72 lines
1.7 KiB
Go
72 lines
1.7 KiB
Go
package insertutils
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/logstorage"
|
|
)
|
|
|
|
func TestExtractTimestampRFC3339NanoFromFields_Success(t *testing.T) {
|
|
f := func(timeField string, fields []logstorage.Field, nsecsExpected int64) {
|
|
t.Helper()
|
|
|
|
nsecs, err := ExtractTimestampRFC3339NanoFromFields(timeField, fields)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %s", err)
|
|
}
|
|
if nsecs != nsecsExpected {
|
|
t.Fatalf("unexpected nsecs; got %d; want %d", nsecs, nsecsExpected)
|
|
}
|
|
|
|
for _, f := range fields {
|
|
if f.Name == timeField {
|
|
if f.Value != "" {
|
|
t.Fatalf("unexpected value for field %s; got %q; want %q", timeField, f.Value, "")
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
f("time", []logstorage.Field{
|
|
{Name: "foo", Value: "bar"},
|
|
{Name: "time", Value: "2024-06-18T23:37:20Z"},
|
|
}, 1718753840000000000)
|
|
|
|
f("time", []logstorage.Field{
|
|
{Name: "foo", Value: "bar"},
|
|
{Name: "time", Value: "2024-06-18T23:37:20+08:00"},
|
|
}, 1718725040000000000)
|
|
|
|
f("time", []logstorage.Field{
|
|
{Name: "foo", Value: "bar"},
|
|
{Name: "time", Value: "2024-06-18T23:37:20.123-05:30"},
|
|
}, 1718773640123000000)
|
|
|
|
f("time", []logstorage.Field{
|
|
{Name: "time", Value: "2024-06-18T23:37:20.123456789-05:30"},
|
|
{Name: "foo", Value: "bar"},
|
|
}, 1718773640123456789)
|
|
}
|
|
|
|
func TestExtractTimestampRFC3339NanoFromFields_Error(t *testing.T) {
|
|
f := func(s string) {
|
|
t.Helper()
|
|
|
|
fields := []logstorage.Field{
|
|
{Name: "time", Value: s},
|
|
}
|
|
nsecs, err := ExtractTimestampRFC3339NanoFromFields("time", fields)
|
|
if err == nil {
|
|
t.Fatalf("expecting non-nil error")
|
|
}
|
|
if nsecs != 0 {
|
|
t.Fatalf("unexpected nsecs; got %d; want %d", nsecs, 0)
|
|
}
|
|
}
|
|
|
|
f("foobar")
|
|
|
|
// incomplete time
|
|
f("2024-06-18")
|
|
f("2024-06-18T23:37")
|
|
}
|