mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-11-21 14:44:00 +00:00
0c7d46d637
* Introduce flagutil.Duration To avoid conversion bugs * Fix tests * Clarify documentation re. month=31 days * Add fasttime.UnixTime() to obtain time.Time The goal is to refactor out the last usage of `.Msecs`. * Use fasttime for time.Now() * wip - Remove fasttime.UnixTime(), since it doesn't improve code readability and maintainability - Run `make docs-sync` for syncing changes from README.md to docs/ folder - Make lib/flagutil.Duration.Msec private - Rename msecsPerMonth const to msecsPer31Days in order to be consistent with retention31Days --------- Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
81 lines
1.7 KiB
Go
81 lines
1.7 KiB
Go
package flagutil
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestDurationSetFailure(t *testing.T) {
|
|
f := func(value string) {
|
|
t.Helper()
|
|
var d Duration
|
|
if err := d.Set(value); err == nil {
|
|
t.Fatalf("expecting non-nil error in d.Set(%q)", value)
|
|
}
|
|
}
|
|
f("")
|
|
f("foobar")
|
|
f("5foobar")
|
|
f("ah")
|
|
f("134xd")
|
|
f("2.43sdfw")
|
|
|
|
// Too big value in months
|
|
f("12345")
|
|
|
|
// Too big duration
|
|
f("100000000000y")
|
|
|
|
// Negative duration
|
|
f("-1")
|
|
f("-34h")
|
|
|
|
// Duration in minutes is confused with duration in months
|
|
f("1m")
|
|
}
|
|
|
|
func TestDurationSetSuccess(t *testing.T) {
|
|
f := func(value string, expectedMsecs int64) {
|
|
t.Helper()
|
|
var d Duration
|
|
if err := d.Set(value); err != nil {
|
|
t.Fatalf("unexpected error in d.Set(%q): %s", value, err)
|
|
}
|
|
if d.msecs != expectedMsecs {
|
|
t.Fatalf("unexpected result; got %d; want %d", d.msecs, expectedMsecs)
|
|
}
|
|
valueString := d.String()
|
|
valueExpected := strings.ToLower(value)
|
|
if valueString != valueExpected {
|
|
t.Fatalf("unexpected valueString; got %q; want %q", valueString, valueExpected)
|
|
}
|
|
}
|
|
f("0", 0)
|
|
f("1", msecsPer31Days)
|
|
f("123.456", 123.456*msecsPer31Days)
|
|
f("1h", 3600*1000)
|
|
f("1.5d", 1.5*24*3600*1000)
|
|
f("2.3W", 2.3*7*24*3600*1000)
|
|
f("1w", 7*24*3600*1000)
|
|
f("0.25y", 0.25*365*24*3600*1000)
|
|
}
|
|
|
|
func TestDurationDuration(t *testing.T) {
|
|
f := func(value string, expected time.Duration) {
|
|
t.Helper()
|
|
var d Duration
|
|
if err := d.Set(value); err != nil {
|
|
t.Fatalf("unexpected error in d.Set(%q): %s", value, err)
|
|
}
|
|
if d.Duration() != expected {
|
|
t.Fatalf("unexpected result; got %v; want %v", d.Duration().String(), expected.String())
|
|
}
|
|
}
|
|
f("0", 0)
|
|
f("1", 31*24*time.Hour)
|
|
f("1h", time.Hour)
|
|
f("1.5d", 1.5*24*time.Hour)
|
|
f("1w", 7*24*time.Hour)
|
|
f("0.25y", 0.25*365*24*time.Hour)
|
|
}
|