VictoriaMetrics/lib/storage
Roman Khavronenko 1ee1e986da
lib/storage: limit max mergeConcurrency value for systems with high number of CPUs (#2673)
Workers count for merges affects the max part size during merges. Such behaviour
protects storage from running out of disk space for scenario when all workers
are merging parts with the max size.

This works very well for most cases. But for systems where high number of CPUs
is allocated for vmstorage components this could significantly impact the max
part size and result in more unmerged parts than expected.

While checking multiple production highly loaded setups it was discovered that
`max_over_time(vm_active_merges{type="storage/big}[1h]}"` rarely exceeds 2,
and `max_over_time(vm_active_merges{type="storage/small}[1h]}"` rarely exceeds 4.
The change in this commit limits the max value for concurrency accordingly.

Signed-off-by: hagen1778 <roman@victoriametrics.com>
2022-06-07 14:55:09 +03:00
..
block.go lib/storage: deduplicate samples more thoroughly 2021-12-15 15:59:58 +02:00
block_header.go lib/storage: correctly use maxBlockSize in various checks 2020-09-24 18:12:56 +03:00
block_header_test.go lib/storage: typo fix: umarshal -> unmarshal 2021-03-02 20:47:59 +02:00
block_stream_merger.go lib/storage: set bsm.Block to nil on error, so the previous block couldn't be used. 2022-01-20 20:13:14 +02:00
block_stream_reader.go lib/bytesutil: split Resize* funcs to MayOverallocate and NoOverallocate for more fine-grained control over memory allocations 2022-02-01 00:18:42 +02:00
block_stream_reader_test.go all: use %w instead of %s for wrapping errors in fmt.Errorf 2020-06-30 23:05:11 +03:00
block_stream_reader_timing_test.go all: use %w instead of %s for wrapping errors in fmt.Errorf 2020-06-30 23:05:11 +03:00
block_stream_writer.go lib/storage: deduplicate samples more thoroughly 2021-12-15 15:59:58 +02:00
block_stream_writer_timing_test.go lib/storage: deduplicate samples more thoroughly 2021-12-15 15:59:58 +02:00
block_test.go lib/storage: fix tests for 32-bit arches such as GOARCH=386 and GOARCH=arm 2020-09-29 13:10:22 +03:00
dedup.go lib/storage: leave the last sample per each discrete interval during the deduplicaton 2022-05-02 21:50:45 +03:00
dedup_test.go lib/storage: leave the last sample per each discrete interval during the deduplicaton 2022-05-02 21:50:45 +03:00
dedup_timing_test.go lib/storage: explicitly pass dedupInterval to DeduplicateSamples() and deduplicateSamplesDuringMerge() 2021-12-14 20:49:12 +02:00
index_db.go lib/storage: stop background merge when storage enters read-only mode 2022-06-01 14:36:45 +03:00
index_db_test.go lib/storage: stop background merge when storage enters read-only mode 2022-06-01 14:36:45 +03:00
index_db_timing_test.go lib/storage: stop background merge when storage enters read-only mode 2022-06-01 14:36:45 +03:00
inmemory_part.go lib/{mergeset,storage}: switch from sync.Pool to chan-based pool for inmemoryPart objects 2021-07-06 16:28:41 +03:00
inmemory_part_test.go all: open-sourcing single-node version 2019-05-23 00:18:06 +03:00
inmemory_part_timing_test.go all: open-sourcing single-node version 2019-05-23 00:18:06 +03:00
merge.go lib/storage: deduplicate samples more thoroughly 2021-12-15 15:59:58 +02:00
merge_test.go app/vmstorage: support for -retentionPeriod smaller than one month 2020-10-20 14:31:44 +03:00
merge_timing_test.go app/vmstorage: support for -retentionPeriod smaller than one month 2020-10-20 14:31:44 +03:00
metaindex_row.go lib/storage: correctly use maxBlockSize in various checks 2020-09-24 18:12:56 +03:00
metaindex_row_test.go lib/storage: correctly use maxBlockSize in various checks 2020-09-24 18:12:56 +03:00
metric_name.go lib/storage: document why job-like and instance-like labels must be stored at mn.Tags[0] and mn.Tags[1] 2022-02-25 13:21:07 +02:00
metric_name_test.go app/vminsert: add support for data ingestion via other vminsert nodes 2021-05-08 19:52:57 +03:00
part.go lib/mergeset: tune caches size limits for indexdb/dataBlocks and indexdb/indexBlocks 2022-01-21 12:45:43 +02:00
part_header.go lib/promscrape: support prometheus-like duration in scrape configs (#2169) 2022-02-11 16:17:00 +02:00
part_header_test.go all: open-sourcing single-node version 2019-05-23 00:18:06 +03:00
part_search.go lib/bytesutil: split Resize* funcs to MayOverallocate and NoOverallocate for more fine-grained control over memory allocations 2022-02-01 00:18:42 +02:00
part_search_test.go Revert "lib/storage: remove unused fetchData arg from BlockRef.MustReadBlock" 2020-09-24 22:44:23 +03:00
partition.go lib/storage: limit max mergeConcurrency value for systems with high number of CPUs (#2673) 2022-06-07 14:55:09 +03:00
partition_search.go optimized code (#2103) 2022-01-28 14:15:41 +02:00
partition_search_test.go lib/storage: stop background merge when storage enters read-only mode 2022-06-01 14:36:45 +03:00
partition_test.go lib/{mergeset,storage}: improve the detection of the needed free space for background merge 2021-08-25 09:35:44 +03:00
raw_block.go all: open-sourcing single-node version 2019-05-23 00:18:06 +03:00
raw_row.go lib/storage: deduplicate samples more thoroughly 2021-12-15 15:59:58 +02:00
search.go all: add initial support for query tracing 2022-06-01 02:29:23 +03:00
search_test.go all: add initial support for query tracing 2022-06-01 02:29:23 +03:00
storage.go lib/storage: stop background merge when storage enters read-only mode 2022-06-01 14:36:45 +03:00
storage_test.go all: add initial support for query tracing 2022-06-01 02:29:23 +03:00
storage_timing_test.go app/vmstorage: add ability to limit series cardinality via -storage.maxHourlySeries and -storage.maxDailySeries command-line flags 2021-05-20 14:15:19 +03:00
table.go lib/storage: stop background merge when storage enters read-only mode 2022-06-01 14:36:45 +03:00
table_search.go optimized code (#2103) 2022-01-28 14:15:41 +02:00
table_search_test.go lib/storage: stop background merge when storage enters read-only mode 2022-06-01 14:36:45 +03:00
table_search_timing_test.go lib/storage: stop background merge when storage enters read-only mode 2022-06-01 14:36:45 +03:00
table_test.go lib/storage: stop background merge when storage enters read-only mode 2022-06-01 14:36:45 +03:00
table_timing_test.go lib/storage: stop background merge when storage enters read-only mode 2022-06-01 14:36:45 +03:00
tag_filters.go lib/{storage,regexpcache}: replaces regexpCacheMap with LRU cache (#2293) 2022-03-26 12:54:50 +02:00
tag_filters_test.go lib/storage: properly handle series selector matching multiple metric names plus a negative filter 2022-02-24 12:15:54 +02:00
tag_filters_timing_test.go lib/storage: small code adjustements after d2960a20e0 2020-10-17 01:16:54 +03:00
time.go all: add initial support for query tracing 2022-06-01 02:29:23 +03:00
time_test.go all: open-sourcing single-node version 2019-05-23 00:18:06 +03:00
tsid.go all: remove the remaining mentions of cluster version 2019-11-21 23:18:22 +02:00
tsid_test.go all: open-sourcing single-node version 2019-05-23 00:18:06 +03:00