mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-01 14:47:38 +00:00
8138499439
The change removes artificial delay before returning error, which sometimes caused less retry events than expected. Signed-off-by: hagen1778 <roman@victoriametrics.com>
109 lines
2.4 KiB
Go
109 lines
2.4 KiB
Go
package backoff
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestRetry_Do(t *testing.T) {
|
|
counter := 0
|
|
tests := []struct {
|
|
name string
|
|
backoffRetries int
|
|
backoffFactor float64
|
|
backoffMinDuration time.Duration
|
|
retryableFunc retryableFunc
|
|
cancelTimeout time.Duration
|
|
want uint64
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "return bad request",
|
|
retryableFunc: func() error {
|
|
return ErrBadRequest
|
|
},
|
|
want: 0,
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "empty retries values",
|
|
retryableFunc: func() error {
|
|
time.Sleep(time.Millisecond * 100)
|
|
return nil
|
|
},
|
|
want: 0,
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "only one retry test",
|
|
backoffRetries: 5,
|
|
backoffFactor: 1.7,
|
|
backoffMinDuration: time.Millisecond * 10,
|
|
retryableFunc: func() error {
|
|
t := time.NewTicker(time.Millisecond * 5)
|
|
defer t.Stop()
|
|
for range t.C {
|
|
counter++
|
|
if counter%2 == 0 {
|
|
return fmt.Errorf("got some error")
|
|
}
|
|
if counter%3 == 0 {
|
|
return nil
|
|
}
|
|
}
|
|
return nil
|
|
},
|
|
want: 1,
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "all retries failed test",
|
|
backoffRetries: 5,
|
|
backoffFactor: 0.1,
|
|
backoffMinDuration: time.Millisecond * 10,
|
|
retryableFunc: func() error {
|
|
t := time.NewTicker(time.Millisecond * 5)
|
|
defer t.Stop()
|
|
for range t.C {
|
|
return fmt.Errorf("got some error")
|
|
}
|
|
return nil
|
|
},
|
|
want: 5,
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "cancel context",
|
|
backoffRetries: 5,
|
|
backoffFactor: 1.7,
|
|
backoffMinDuration: time.Millisecond * 10,
|
|
retryableFunc: func() error {
|
|
return fmt.Errorf("got some error")
|
|
},
|
|
cancelTimeout: time.Millisecond * 40,
|
|
want: 3,
|
|
wantErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
r := &Backoff{retries: tt.backoffRetries, factor: tt.backoffFactor, minDuration: tt.backoffMinDuration}
|
|
ctx := context.Background()
|
|
if tt.cancelTimeout != 0 {
|
|
newCtx, cancelFn := context.WithTimeout(context.Background(), tt.cancelTimeout)
|
|
ctx = newCtx
|
|
defer cancelFn()
|
|
}
|
|
got, err := r.Retry(ctx, tt.retryableFunc)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("Retry() error = %v, wantErr %v", err, tt.wantErr)
|
|
return
|
|
}
|
|
if got != tt.want {
|
|
t.Errorf("Retry() got = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|