VictoriaMetrics/app/vmselect/promql
Anton Tykhyy 51af1dfff7
Fix sum(aggr_over_time) 'got 1 args' error (#3028) (#5414)
app/vmselect/promql/eval.go:evalAggrFunc shunts evaluation
of AggrFuncExpr over rollupFunc over MetricsExpr to an optimized
path. tryGetArgRollupFuncWithMetricExpr() checks whether expression
can be shunted, but it mangles the AggrFuncExpr when the aggregation
function has more than one argument. This results in queries like
`sum(aggr_over_time("avg_over_time",m))` failing with error message
'expecting at least 2 args to "aggr_over_time"; got 1 args' while
the analogous query `sum(avg_over_time(m))` executes successfully.
This fix removes the unnecessary mangling.

Signed-off-by: Anton Tykhyy <atykhyy@gmail.com>
2023-12-14 12:49:01 +02:00
..
active_queries.go Makefile: update golangci-lint from v1.51.2 to v1.54.2 2023-09-01 10:25:49 +02:00
aggr.go app/vmselect/promql: add outliers_iqr(q) and outlier_iqr_over_time(m[d]) functions 2023-10-31 22:14:14 +01:00
aggr_incremental.go app/vmselect/promql: optimize repeated SLI-like instant queries with lookbehind windows >= 1d 2023-10-31 20:08:38 +01:00
aggr_incremental_test.go app/vmselect/promql: fix TestIncrementalAggr test on systems less than 3 CPU cores 2023-03-20 20:37:44 -07:00
aggr_test.go app/vmselect/promql: add mode() aggregate function 2020-07-20 15:30:11 +03:00
binary_op.go app/vmselect: reduce lock contention for heavy aggregation requests (#5119) 2023-10-10 13:44:02 +02:00
eval.go Fix sum(aggr_over_time) 'got 1 args' error (#3028) (#5414) 2023-12-14 12:49:01 +02:00
eval_test.go all: add support for or filters in series selectors 2023-07-15 23:56:18 -07:00
exec.go app/vmselect: add -search.maxResponseSeries command-line flag for limiting the number of time series a single response can return 2023-12-10 00:54:32 +02:00
exec_test.go app/vmselect/promql: add day_of_year() function (#5368) 2023-11-28 12:49:48 +01:00
memory_limiter.go app/vmselect: return back the logic for limits the amounts of memory occupied by concurrently executed queries if -search.maxMemoryPerQuery isn't set 2022-10-10 21:54:18 +03:00
memory_limiter_test.go app/vmselect: return back the logic for limits the amounts of memory occupied by concurrently executed queries if -search.maxMemoryPerQuery isn't set 2022-10-10 21:54:18 +03:00
parser.go all: add support for or filters in series selectors 2023-07-15 23:56:18 -07:00
rollup.go app/vmselect: properly adjust the lower bound for the time range where raw samples must be selected for default_rollup() function 2023-12-06 14:46:18 +02:00
rollup_result_cache.go app/vmselect/promql: properly handle duplicate series when merging cached results with the results obtained from the database 2023-11-16 16:16:17 +01:00
rollup_result_cache_test.go app/vmselect/promql: properly handle duplicate series when merging cached results with the results obtained from the database 2023-11-16 16:16:17 +01:00
rollup_test.go fix: apply correct bounds to sf and tf (#5274) 2023-11-14 01:19:47 +01:00
rollup_timing_test.go app/vmselect: use consistent randomizer in tests 2023-01-23 19:27:40 -08:00
timeseries.go app/vmselect/promql: optimize repeated SLI-like instant queries with lookbehind windows >= 1d 2023-10-31 20:08:38 +01:00
timeseries_test.go app/vmselect/promql: add test to ensure 8-byte alignment (#3948) 2023-03-16 22:07:13 -07:00
transform.go app/vmselect/promql: add day_of_year() function (#5368) 2023-11-28 12:49:48 +01:00
transform_test.go app/vmselect/promql: follow-up for 79e1c6a6fc 2023-03-27 18:04:30 -07:00
tzdata.go all: cleanup: remove // +build ... lines, since they are no longer needed after Go1.17, and the minimum supported Go version for VictoriaMetrics source code is Go1.20 2023-11-13 19:15:42 +01:00