VictoriaMetrics/app
rtm0 bdc0e688e8
Fix inconsistent error handling in Storage.AddRows() (#6583)
### Describe Your Changes

`Storage.AddRows()` returns an error only in one case: when
`Storage.updatePerDateData()` fails to unmarshal a `metricNameRaw`. But
the same error is treated as a warning when it happens inside
`Storage.add()` or returned by `Storage.prefillNextIndexDB()`.

This commit fixes this inconsistency by treating the error returned by
`Storage.updatePerDateData()` as a warning as well. As a result
`Storage.add()` does not need a return value anymore and so doesn't
`Storage.AddRows()`.

Additionally, this commit adds a unit test that checks all cases that
result in a row not being added to the storage.



---------

Signed-off-by: Artem Fetishev <wwctrsrx@gmail.com>
Co-authored-by: Nikolay <nik@victoriametrics.com>
2024-07-17 12:07:14 +02:00
..
victoria-logs app/victoria-logs/Makefile: add make victoria-logs-linux-loong64 build rule 2024-07-12 23:12:48 +02:00
victoria-metrics app: consistently use t.Fatal* instead of t.Error* (except of app/vmalert and app/vmctl - these packages will be processed in a separate commit) 2024-07-11 15:59:08 +02:00
vlinsert app/vlinsert/loki: use easyproto instead for parsing Loki protobuf messages 2024-07-10 03:05:17 +02:00
vlogsgenerator lib/logstorage: work-in-progress 2024-05-25 00:30:58 +02:00
vlselect app/vlselect/vmui: run make vmui-logs-update after 662e026279 2024-07-10 00:50:10 +02:00
vlstorage vendor: update github.com/VictoriaMetrics/metrics from v1.34.1 to v1.35.0 2024-07-15 10:43:37 +02:00
vmagent lib/httpserver: skip basic auth check for additional request paths, which should call httpserver.CheckAuthFlag() 2024-07-16 01:00:45 +02:00
vmalert lib/httpserver: skip basic auth check for additional request paths, which should call httpserver.CheckAuthFlag() 2024-07-16 01:00:45 +02:00
vmalert-tool app/vmalert-tool/Makefile: add make vmalert-tool-linux-loong64 build rule 2024-07-12 23:19:04 +02:00
vmauth app/vmauth: properly handle the case when zero backend hosts are resolved at SRV DNS 2024-07-17 11:31:05 +02:00
vmbackup app: consistently use t.Fatal* instead of t.Error* (except of app/vmalert and app/vmctl - these packages will be processed in a separate commit) 2024-07-11 15:59:08 +02:00
vmbackupmanager all: replace old https://docs.victoriametrics.com/vmbackupmanager.html url with the new one - https://docs.victoriametrics.com/vmbackupmanager/ 2024-04-18 02:03:58 +02:00
vmctl app/vmalert: switch from table-driven tests to f-tests 2024-07-12 22:41:11 +02:00
vmgateway all: replace old https://docs.victoriametrics.com/vmgateway.html url with the new one - https://docs.victoriametrics.com/vmgateway/ 2024-04-18 02:08:18 +02:00
vminsert lib/httpserver: skip basic auth check for additional request paths, which should call httpserver.CheckAuthFlag() 2024-07-16 01:00:45 +02:00
vmrestore deployment: build image for vmagent streamaggr benchmark (#6515) 2024-06-24 16:28:50 +02:00
vmselect lib/httpserver: skip basic auth check for additional request paths, which should call httpserver.CheckAuthFlag() 2024-07-16 01:00:45 +02:00
vmstorage Fix inconsistent error handling in Storage.AddRows() (#6583) 2024-07-17 12:07:14 +02:00
vmui vmui/logs: add spinner to bar chart (#6577) 2024-07-09 14:58:48 +02:00