mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-11-21 14:44:00 +00:00
a4ea3b87d7
This eliminates possible bugs related to forgotten Query.Optimize() calls.
This also allows removing optimize() function from pipe interface.
While at it, drop filterNoop inside filterAnd.
(cherry picked from commit 66b2987f49
)
96 lines
2.1 KiB
Go
96 lines
2.1 KiB
Go
package logstorage
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/logger"
|
|
)
|
|
|
|
// pipeDelete implements '| delete ...' pipe.
|
|
//
|
|
// See https://docs.victoriametrics.com/victorialogs/logsql/#delete-pipe
|
|
type pipeDelete struct {
|
|
// fields contains a list of fields to delete
|
|
fields []string
|
|
}
|
|
|
|
func (pd *pipeDelete) String() string {
|
|
if len(pd.fields) == 0 {
|
|
logger.Panicf("BUG: pipeDelete must contain at least a single field")
|
|
}
|
|
|
|
return "delete " + fieldNamesString(pd.fields)
|
|
}
|
|
|
|
func (pd *pipeDelete) canLiveTail() bool {
|
|
return true
|
|
}
|
|
|
|
func (pd *pipeDelete) updateNeededFields(neededFields, unneededFields fieldsSet) {
|
|
if neededFields.contains("*") {
|
|
unneededFields.addFields(pd.fields)
|
|
} else {
|
|
neededFields.removeFields(pd.fields)
|
|
}
|
|
}
|
|
|
|
func (pd *pipeDelete) hasFilterInWithQuery() bool {
|
|
return false
|
|
}
|
|
|
|
func (pd *pipeDelete) initFilterInValues(_ map[string][]string, _ getFieldValuesFunc) (pipe, error) {
|
|
return pd, nil
|
|
}
|
|
|
|
func (pd *pipeDelete) newPipeProcessor(_ int, _ <-chan struct{}, _ func(), ppNext pipeProcessor) pipeProcessor {
|
|
return &pipeDeleteProcessor{
|
|
pd: pd,
|
|
ppNext: ppNext,
|
|
}
|
|
}
|
|
|
|
type pipeDeleteProcessor struct {
|
|
pd *pipeDelete
|
|
ppNext pipeProcessor
|
|
}
|
|
|
|
func (pdp *pipeDeleteProcessor) writeBlock(workerID uint, br *blockResult) {
|
|
if br.rowsLen == 0 {
|
|
return
|
|
}
|
|
|
|
br.deleteColumns(pdp.pd.fields)
|
|
pdp.ppNext.writeBlock(workerID, br)
|
|
}
|
|
|
|
func (pdp *pipeDeleteProcessor) flush() error {
|
|
return nil
|
|
}
|
|
|
|
func parsePipeDelete(lex *lexer) (*pipeDelete, error) {
|
|
if !lex.isKeyword("delete", "del", "rm", "drop") {
|
|
return nil, fmt.Errorf("expecting 'delete', 'del', 'rm' or 'drop'; got %q", lex.token)
|
|
}
|
|
|
|
var fields []string
|
|
for {
|
|
lex.nextToken()
|
|
field, err := parseFieldName(lex)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("cannot parse field name: %w", err)
|
|
}
|
|
|
|
fields = append(fields, field)
|
|
|
|
switch {
|
|
case lex.isKeyword("|", ")", ""):
|
|
pd := &pipeDelete{
|
|
fields: fields,
|
|
}
|
|
return pd, nil
|
|
case lex.isKeyword(","):
|
|
default:
|
|
return nil, fmt.Errorf("unexpected token: %q; expecting ',', '|' or ')'", lex.token)
|
|
}
|
|
}
|
|
}
|